[linter] Do not promote migration of Version class (yet)
#12136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updating docs! |
4 tasks
jcar87
approved these changes
Aug 10, 2022
There was a problem hiding this comment.
LGTM
This is just precautionary - conan.tools.scm.Version is correct for Conan 2, and exists in Conan 1.x, but in current 1.x releases it does not have the correct properties due to a bug which is being fixed for the new release and backported as path releases. Documentation will be updated to reflect the interface.
In the meantime - this removing this from the linter will help well intentioned users - otherwise we are in the catch-22 situation where CI jobs for Pull Requests show it as a linter error, but the recipe does not work for current 1.x releases.
prince-chrismc
approved these changes
Aug 10, 2022
uilianries
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not promote the new
Versionclass as its interface will be broken in the upcoming Conan release (1.52). The future interface might be backported to 1.50.x and 1.51.x, but better not to use the current one.Please, @jcar87, explain what is the future
Versionclass to be used and the expected interface (maybe it is already documented and it can be just linked).