(#12358): NuRaft recipe #12360

szmyd · 2022-08-18T16:46:23Z

Specify library name and version: nuraft/cci.20220801

A robust RAFT implementation in C++11 used throughout eBay storage services.

closes #12358

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the conan-center hook activated.

github-actions · 2022-08-20T00:12:39Z

Hooks produced the following warnings for commit 243c5ad

nuraft/cci.20220801

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libnuraft.so' links to system library 'm' but it is not in cpp_info.system_libs.

recipes/nuraft/all/conanfile.py

prince-chrismc

Couple small comments and questions

Overall it's super close

recipes/nuraft/all/conanfile.py

prince-chrismc · 2022-09-15T00:53:12Z

recipes/nuraft/all/patches/0001-cmake_patches.patch

+     set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-pessimizing-move")
+-    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11")
+-    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -g")
+     set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fPIC")


This should be managed by Conan

If I let it, then the shared library option does not include PIC and I end up with:

/usr/bin/ld: CMakeFiles/RAFT_CORE_OBJ.dir/src/handle_commit.cxx.o: relocation R_X86_64_TPOFF32 against `_ZZN6nuraft11raft_server11reconfigureERKSt10shared_ptrINS_14cluster_configEEE8temp_buf' can not be used when making a shared object; recompile with -fPIC

So it seems fPIC is needed regardless which conan is not managing correctly?

conan does not pass -fPIC, but the CMAKE_POSITION_INDEPENDENT_CODE definition

https://docs.conan.io/en/latest/reference/conanfile/tools/cmake/cmaketoolchain.html#cmaketoolchain

Correct, and it seems to not be present with the shared option enabled (I’ll double check), so I had to leave the original author’s -fPIC flag in the cmake rules.

😕 by default CMake does the right thing https://cmake.org/cmake/help/latest/prop_tgt/POSITION_INDEPENDENT_CODE.html#prop_tgt:POSITION_INDEPENDENT_CODE

So there must be some hackery in the build script tripping up the sensible default 🙈

prince-chrismc · 2022-09-15T00:54:16Z

recipes/nuraft/all/patches/0001-cmake_patches.patch

 -
 -    set(ASIO_INCLUDE_DIR ${BOOST_INCLUDE_PATH})
 -    set(LIBBOOST_SYSTEM "${BOOST_LIBRARY_PATH}/libboost_system.a")
 -
-else ()
-    # If not, ASIO standalone mode.
+    set(ASIO_DEP boost::boost)


I noticed this was replaced below 🤔

Should we not use the asio target?

I think it is? If Boost_FOUND tests false I find the asio package and set ASIO_DEP to asio::asio and use ${ASIO_DEP} as the target_link_library. Am I missing the point?

I thought there was Boost::asio but it's not official now that I double check https://cmake.org/cmake/help/latest/module/FindBoost.html#imported-targets

uilianries · 2022-09-16T13:25:42Z

recipes/nuraft/all/conanfile.py

+            raise ConanInvalidConfiguration("Building Shared Object for {} unsupported".format(self.info.settings.os))
+        if self.info.settings.compiler.cppstd:
+            check_min_cppstd(self, 11)
+


Suggested change

def layout(self):

cmake_layout(self, src_folder="src")

uilianries · 2022-09-16T13:25:54Z

recipes/nuraft/all/conanfile.py

+from conan import ConanFile
+from conan.errors import ConanInvalidConfiguration
+from conan.tools.files import copy, get, apply_conandata_patches
+from conan.tools.cmake import CMake, CMakeDeps, CMakeToolchain


Suggested change

from conan.tools.cmake import CMake, CMakeDeps, CMakeToolchain

from conan.tools.cmake import CMake, CMakeDeps, CMakeToolchain, cmake_layout

uilianries · 2022-09-16T13:27:09Z

recipes/nuraft/all/conanfile.py

+
+    def requirements(self):
+        if self.options.asio == "boost":
+            self.requires("boost/1.79.0")


Suggested change

self.requires("boost/1.79.0")

self.requires("boost/1.80.0")

We have Boost 1.80.0 available on Conan Center.

Is it not better to target a lower MINOR since it won’t require recompile should someone want 1.80.0 as opposed to the reverse which would?

soon or later, all recipes will use 1.80.0, then your recipe will need to be updated too. Doing it now, it are just doing what should be done later.

In ConanCenter we always try to stay on latest to avoid conflicts... two recipes using boost should work together (hopefully)

prince-chrismc · 2022-09-20T15:57:21Z

recipes/nuraft/all/test_package/conanfile.py

+
+class TestPackageConan(ConanFile):
+    settings = "os", "compiler", "build_type", "arch"
+    generators = "cmake", "cmake_find_package_multi"


This should be the test for the new generators and this can be moved to test_v1_package/

prince-chrismc

needs a new test package https://github.com/conan-io/conan-center-index/pull/12360/files#r975553072

conan-center-bot · 2022-11-21T19:19:07Z

Conan v1 pipeline

All green in build 31 (f4798d4cb65770407c63b624be2b5a393c8030bc):

nuraft/2.0.0@:
All packages built successfully! (All logs)

danimtb

although there are still some comments to be resolved, I think there is a reasonable amount of work here to move the PR forward. So let's do it and keep the details for another one 👊

szmyd added 5 commits August 18, 2022 09:45

(conan-io#12358): NuRaft recipe

d3f3c52

Remove old test runner.

3479815

Adjust tools imports

760f049

New tools defined as member methods.

e15648c

Adjust variable name.

1b7b17a

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Aug 18, 2022

This comment has been minimized.

Sign in to view

Remove shared library option from Macos.

4508f76

conan-center-bot removed the Failed label Aug 18, 2022

szmyd added 2 commits August 18, 2022 11:48

Do not remove options later referenced.

1a4fc0f

Fix import for v2.

6e34aca

github-actions bot mentioned this pull request Aug 18, 2022

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Aug 19, 2022

Remove running unit tests.

54c0077

conan-center-bot removed the Failed label Aug 19, 2022

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Aug 19, 2022

szmyd added 2 commits August 19, 2022 15:38

Remove fPIC option on Windows.

4cd84fe

Cleanup recipe with 2.x migrations.

3cfbbe0

conan-center-bot removed the Failed label Aug 19, 2022

szmyd added 2 commits August 19, 2022 16:19

Disable Windows builds entirely.

d99e916

Typo

243c5ad

This comment has been minimized.

Sign in to view

Add libm to systemlibs linkages.

a25ae02

This comment has been minimized.

Sign in to view

szmyd added 2 commits August 26, 2022 08:38

Provide patch descriptions.

4b4d568

Simplify test_package.

936eea4

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Sep 14, 2022

uilianries reviewed Sep 14, 2022

View reviewed changes

recipes/nuraft/all/conanfile.py Show resolved Hide resolved

Fix missing namespace.

4d342a3

conan-center-bot removed the Failed label Sep 14, 2022

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Sep 14, 2022

Add back original fPIC option from upstream CMake.

08b2020

conan-center-bot removed the Failed label Sep 14, 2022

This comment has been minimized.

Sign in to view

prince-chrismc reviewed Sep 15, 2022

View reviewed changes

Review comments addressed.

872ea8a

This comment has been minimized.

Sign in to view

conan-center-bot requested a review from uilianries September 15, 2022 12:00

uilianries reviewed Sep 16, 2022

View reviewed changes

prince-chrismc reviewed Sep 20, 2022

View reviewed changes

conan-center-bot requested a review from franramirez688 September 30, 2022 11:58

SSE4 previously approved these changes Oct 15, 2022

View reviewed changes

prince-chrismc reviewed Oct 17, 2022

View reviewed changes

conan-center-bot requested review from jcar87 and removed request for jgsogo October 19, 2022 11:58

conan-center-bot requested a review from danimtb November 18, 2022 12:00

Update to v2.0.0

ee6e727

szmyd dismissed SSE4’s stale review via ee6e727 November 21, 2022 18:30

Remove old reference.

f4798d4

danimtb approved these changes Nov 24, 2022

View reviewed changes

prince-chrismc approved these changes Nov 25, 2022

View reviewed changes

conan-center-bot merged commit 8740901 into conan-io:master Nov 25, 2022

szmyd deleted the nuraft branch February 22, 2023 17:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(#12358): NuRaft recipe #12360

(#12358): NuRaft recipe #12360

szmyd commented Aug 18, 2022 •

edited

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Aug 20, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

prince-chrismc left a comment

prince-chrismc Sep 15, 2022

szmyd Sep 15, 2022

uilianries Sep 16, 2022

szmyd Sep 18, 2022

prince-chrismc Sep 20, 2022

prince-chrismc Sep 15, 2022

szmyd Sep 15, 2022

prince-chrismc Sep 20, 2022

This comment has been minimized.

uilianries Sep 16, 2022

uilianries Sep 16, 2022

uilianries Sep 16, 2022

szmyd Sep 18, 2022

uilianries Sep 19, 2022

prince-chrismc Sep 20, 2022

prince-chrismc Sep 20, 2022

prince-chrismc left a comment

conan-center-bot commented Nov 21, 2022

danimtb left a comment

	from conan.tools.cmake import CMake, CMakeDeps, CMakeToolchain
	from conan.tools.cmake import CMake, CMakeDeps, CMakeToolchain, cmake_layout

(#12358): NuRaft recipe #12360

(#12358): NuRaft recipe #12360

Conversation

szmyd commented Aug 18, 2022 • edited

closes #12358

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Aug 20, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

prince-chrismc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment has been minimized.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prince-chrismc left a comment

Choose a reason for hiding this comment

conan-center-bot commented Nov 21, 2022

Conan v1 pipeline

danimtb left a comment

Choose a reason for hiding this comment

szmyd commented Aug 18, 2022 •

edited