ImageMagick on Windows #12371
Closed
ImageMagick on Windows #12371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theartful
force-pushed
the
imagemagick-windows
branch
from
78c1f1c
to
d904b1a
Compare
This comment has been minimized.
This comment has been minimized.
|
Failing due to missing dependencies (#11684). |
|
@hesham-essam Thank your for reporting |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
theartful
force-pushed
the
imagemagick-windows
branch
from
fa51d7d
to
440fe2f
Compare
This comment has been minimized.
This comment has been minimized.
theartful
force-pushed
the
imagemagick-windows
branch
from
440fe2f
to
dbf33a9
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@hesham-essam I believe that's related to issue conan-io/conan#11867. |
|
@jwillikers Related but not quite. The issue in my case is simply the space in between the -F flag and the directory, not the existence of the paths (which they mostly don't btw, and I get warnings that they don't exist). |
|
@jwillikers Which contains the section because the directory is added afterwards, and clang thinks it's a library path. |
This comment has been minimized.
This comment has been minimized.
ghost
mentioned this pull request
4 tasks
|
The bot showed me this PR now when updating my old one which solves building on Windows with a cmake patch instead, its only for 7.1 but maybe it is a cleaner solution? (I didn't read the entire thread here so sorry if I missed the reason for this) |
|
@Cyriuz I'm okay with either solution. When I first created this PR I wasn't aware of yours. In my opinion using cmake is indeed cleaner, but since autotools is the one supported upstream, I'd prefer using it (on linux at least). I also have a personal bias for this solution since it's the one a project I'm contributing to is already using (but with vcpkg). |
|
Understandable, I tried getting the cmake accepted by the imagemagick maintainers but they wanted adoption before they would take it so my plan was to prove that it worked through the conan package. I've just been extremely low on time to get it accepted here... You can check the issues I linked in my PR if you care. Though your solution might be easier to maintain as long as the cmake is not merged to imagemagick main, but it probably never will if we don't use it here, so I guess it would be up to the reviewers what they prefer. |
jwillikers
approved these changes
Oct 14, 2022
|
Failure in build 50 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
|
Missing libraries for Macos M1 |
|
@hesham-essam Please, update to harfbuzz/5.3.0 |
|
@uilianries This recipe is not directly using harfbuzz or cairo. |
|
@hesham-essam We will need those missing packages and regenerate them. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Do you think this huge work might been merge one day ? |
ghost
mentioned this pull request
4 tasks
|
Hesham Essam seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
I will close this for now. Once #14517 is merged, I will reopen this, which will make my life easier since my changes would only affect Windows then (unlike now). Sorry I didn't have much time to invest in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: ImageMagick
This enables ImageMagick on Windows. The previous solution is to use VisualMagick, which is not the best, since VisualMagick builds all of its dependencies from scratch, and then links against those. This is problematic since it would cause symbols being redefined if anything links against both ImageMagick and one of its dependencies (which will be provided both by VisualMagick custom recipes, and conan).