openmpi: modernize for conan v2 attempt 2

[paulharris]

This continues on from PR: #10479 and #11832

[paulharris]

My first problem is that "package-version" (aka PACKAGE_VERSION) is not set in the makefiles/config files, which then panics half way into the build.

I'm not sure when or how that is supposed to be set...

Option package-version requires an argument
Usage: /build/conandata/conan-data/openmpi/4.1.0/conan/test1/build/f814d0edbc078f0e26ba4c4062accfcf2c7ca6c5/src/config/make_manpage.pl --package-name=<package name> --package-version=<package version> --ompi-date=<ompi date> --opal-date=<opal date> --orte-date=<orte date> --input=<input file> --output=<output file> [--nocxx] [ --nofortran] [--nof08]

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[paulharris]

The OpenMPI recipe sets self.env_info.MPI_HOME = self.package_path, and the test_package does:

            mpiexec = os.path.join(os.environ['MPI_BIN'], 'mpiexec')
            bin_path = os.path.join(self.cpp.build.bindirs[0], "test_package")
            command = f"{mpiexec} -mca plm_rsh_agent yes -np 2 {bin_path}"
            self.run(command, env="conanrun")

Which results in:

ERROR: openmpi/4.1.0@ccitest/test2 (test package): Error in test() method, line 25
	mpiexec = os.path.join(os.environ['MPI_BIN'], 'mpiexec')
	KeyError: 'MPI_BIN'

Shouldn't MPI_BIN be available? or only during the self.run() and not the def test() ? What should be done instead?

[conan-center-bot]

Conan v1 pipeline

Failure in build 6 (bff279658d7374ecced8b0494e304cdd5b6f37e0):

• openmpi/4.1.0@:
  CI failed to create some packages (All logs)

  Logs for packageID 178a998996d1f56b2ddef382b4783b6926ac29ff:

  [settings]
  arch=x86_64
  build_type=Release
  compiler=gcc
  compiler.libcxx=libstdc++
  compiler.version=10
  os=Linux
  [options]
  openmpi:shared=False
  

  [...]
  /home/conan/w/prod/BuildSingleReference/.conan/data/openmpi/4.1.0/_/_/build/178a998996d1f56b2ddef382b4783b6926ac29ff/src/ompi/tools/ompi_info/param.c: In function ‘ompi_info_do_config’:
  /home/conan/w/prod/BuildSingleReference/.conan/data/openmpi/4.1.0/_/_/build/178a998996d1f56b2ddef382b4783b6926ac29ff/src/ompi/tools/ompi_info/param.c:334:77: warning: unknown escape sequence: '\$'
    334 |     opal_info_out("Configure command line", "config:cli", OPAL_CONFIGURE_CLI);
        |                                                                             ^
  /home/conan/w/prod/BuildSingleReference/.conan/data/openmpi/4.1.0/_/_/build/178a998996d1f56b2ddef382b4783b6926ac29ff/src/ompi/tools/ompi_info/param.c:334:77: warning: unknown escape sequence: '\$'
  /home/conan/w/prod/BuildSingleReference/.conan/data/openmpi/4.1.0/_/_/build/178a998996d1f56b2ddef382b4783b6926ac29ff/src/ompi/tools/ompi_info/param.c:334:77: warning: unknown escape sequence: '\$'
  /home/conan/w/prod/BuildSingleReference/.conan/data/openmpi/4.1.0/_/_/build/178a998996d1f56b2ddef382b4783b6926ac29ff/src/ompi/tools/ompi_info/param.c:334:77: warning: unknown escape sequence: '\$'
  /home/conan/w/prod/BuildSingleReference/.conan/data/openmpi/4.1.0/_/_/build/178a998996d1f56b2ddef382b4783b6926ac29ff/src/ompi/tools/ompi_info/param.c:334:77: warning: unknown escape sequence: '\$'
  /home/conan/w/prod/BuildSingleReference/.conan/data/openmpi/4.1.0/_/_/build/178a998996d1f56b2ddef382b4783b6926ac29ff/src/ompi/tools/ompi_info/param.c:334:77: warning: unknown escape sequence: '\$'
  /home/conan/w/prod/BuildSingleReference/.conan/data/openmpi/4.1.0/_/_/build/178a998996d1f56b2ddef382b4783b6926ac29ff/src/ompi/tools/ompi_info/param.c:296:15: warning: ignoring return value of ‘asprintf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
    296 |         (void)asprintf(&fortran_mpifh, "yes (%s)",
        |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    297 |                        (OPAL_HAVE_WEAK_SYMBOLS ? "all" :
        |                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    298 |                         (OMPI_FORTRAN_CAPS ? "caps" :
        |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    299 |                          (OMPI_FORTRAN_PLAIN ? "lower case" :
        |                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    300 |                           (OMPI_FORTRAN_SINGLE_UNDERSCORE ? "single underscore" : "double underscore")))));
        |                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  /home/conan/w/prod/BuildSingleReference/.conan/data/openmpi/4.1.0/_/_/build/178a998996d1f56b2ddef382b4783b6926ac29ff/src/ompi/tools/ompi_info/param.c:310:15: warning: ignoring return value of ‘asprintf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
    310 |         (void)asprintf(&fortran_have_ignore_tkr, "yes (%s)",
        |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    311 |                        OMPI_FORTRAN_IGNORE_TKR_PREDECL);
        |                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  /home/conan/w/prod/BuildSingleReference/.conan/data/openmpi/4.1.0/_/_/build/178a998996d1f56b2ddef382b4783b6926ac29ff/src/ompi/tools/ompi_info/param.c:317:11: warning: ignoring return value of ‘asprintf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
    317 |     (void)asprintf(&threads, "%s (MPI_THREAD_MULTIPLE: yes, OPAL support: yes, OMPI progress: %s, ORTE progress: yes, Event lib: yes)",
        |           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    318 |                    "posix", OPAL_ENABLE_PROGRESS_THREADS ? "yes" : "no");
        |                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  /home/conan/w/prod/BuildSingleReference/.conan/data/openmpi/4.1.0/_/_/build/178a998996d1f56b2ddef382b4783b6926ac29ff/src/ompi/tools/ompi_info/param.c:324:11: warning: ignoring return value of ‘asprintf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
    324 |     (void)asprintf(&ft_support, "%s (checkpoint thread: %s)",
        |           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    325 |                    OPAL_ENABLE_FT ? "yes" : "no", OPAL_ENABLE_FT_THREAD ? "yes" : "no");
        |                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  /home/conan/w/prod/BuildSingleReference/.conan/data/openmpi/4.1.0/_/_/build/178a998996d1f56b2ddef382b4783b6926ac29ff/src/ompi/tools/ompi_info/param.c:327:11: warning: ignoring return value of ‘asprintf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
    327 |     (void)asprintf(&crdebug_support, "%s",
        |           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    328 |                    OPAL_ENABLE_CRDEBUG ? "yes" : "no");
        |                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  libtool: warning: remember to run 'libtool --finish //lib'
  libtool: warning: remember to run 'libtool --finish //lib'
  libtool: warning: remember to run 'libtool --finish //lib/openmpi'
  libtool: warning: remember to run 'libtool --finish //lib'
  libtool: warning: remember to run 'libtool --finish //lib'
  openmpi/4.1.0: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
  openmpi/4.1.0: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
  [HOOK - conan-center.py] post_package(): ERROR: [LIBTOOL FILES PRESENCE (KB-H018)] Libtool files found (*.la). Do not package *.la files but library files (.a)  (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H018) 
  [HOOK - conan-center.py] post_package(): ERROR: [LIBTOOL FILES PRESENCE (KB-H018)] Found files: ./lib/openmpi/libompi_dbg_msgq.la (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H018) 
  ERROR: [HOOK - conan-center.py] post_package(): Some checks failed running the hook, check the output
  

---

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[paulharris]

I'm abandoning this PR due to lack of time, and I can avoid using MPI for now.
@prince-chrismc you might want to put this in the pile of "nearly completed PRs", or just assume it'll be done from scratch in the future.