Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ms-gsl/3.0.0 #1388

Merged
merged 10 commits into from Apr 30, 2020
Merged

add ms-gsl/3.0.0 #1388

merged 10 commits into from Apr 30, 2020

Conversation

gocarlos
Copy link
Contributor

Specify library name and version: ms-gsl/3.0.0

fixes #1377

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@gocarlos gocarlos changed the title Feat update ms-gsl add ms-gsl/3.0.0 Apr 17, 2020
@conan-center-bot
Copy link
Collaborator

Failure in build 1 (b69018f0836fcaa489ef1f512f9b55279c063c9f):
ms-gsl/3.0.0:

'conan export' command failed:

ERROR: Package recipe with version 3.0.0!=2.0.0

@conan-center-bot
Copy link
Collaborator

Some configurations of 'ms-gsl/2.0.0' failed in build 2 (3d166c5514fc740b8be1b9aa822d495c09ae93f6):

  • Linux x86_64, Release, gcc 5, libstdc++
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [TEST PACKAGE - RUN ENVIRONMENT (KB-H029)] The 'RunEnvironment()' build helper is no longer needed. It has been integrated into the self.run(..., run_environment=True) (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H029)
    • Log download
    • Log error Download
    • Profile
  • Access to all the logs

@conan-center-bot
Copy link
Collaborator

All green in build 3 (8bebd46fe08f7d576d08eb5b5eedb5eebb310c7d)! 😊

@gocarlos
Copy link
Contributor Author

@uilianries @danimtb the latest release of gsl does not have the option anymore for terminate or throw... -> https://github.com/microsoft/GSL/releases/tag/v3.0.0

Contract violations are no longer configurable.

version 2 was configurable... should we just use the cmake script which has support for this or still using defines and header files?

uilianries
uilianries previously approved these changes Apr 17, 2020
View reviewed changes
@uilianries uilianries requested a review from SSE4 April 17, 2020 13:58
SSE4
SSE4 previously approved these changes Apr 19, 2020
View reviewed changes
@gocarlos gocarlos dismissed stale reviews from SSE4 and uilianries via dbf720e April 20, 2020 08:39
@conan-center-bot
Copy link
Collaborator

All green in build 4 (dbf720e14129113c955372649d4be0035f762e35)! 😊

@prince-chrismc prince-chrismc mentioned this pull request Apr 21, 2020
Merged
4 tasks
@danimtb
Copy link
Member

danimtb commented Apr 23, 2020

@gocarlos please solve conflicts here coming after merging #1206. Thank you!

@conan-center-bot
Copy link
Collaborator

All green in build 5 (dbf720e14129113c955372649d4be0035f762e35)! 😊

uilianries
uilianries requested changes Apr 24, 2020
View reviewed changes
recipes/ms-gsl/all/conanfile.py Outdated Show resolved Hide resolved
recipes/ms-gsl/all/conanfile.py Show resolved Hide resolved
@conan-center-bot
Copy link
Collaborator

All green in build 6 (c93d2eb4e498b1d68cfa498d0521fc116a755d9a)! 😊

SSE4
SSE4 previously approved these changes Apr 27, 2020
View reviewed changes
@conan-center-bot
Copy link
Collaborator

All green in build 7 (f103fab206015cd1e0b253500ca10774e6c0fa0d)! 😊

uilianries
uilianries requested changes Apr 28, 2020
View reviewed changes
recipes/ms-gsl/all/conanfile.py Outdated Show resolved Hide resolved
recipes/ms-gsl/all/conanfile.py Show resolved Hide resolved
@gocarlos @uilianries
Update recipes/ms-gsl/all/conanfile.py
1b366a3 
Co-Authored-By: Uilian Ries <uilianries@gmail.com>
@conan-center-bot
Copy link
Collaborator

All green in build 8 (1b366a36f00c391fbc120c8e26f2e384ca7cb453)! 😊

uilianries
uilianries previously approved these changes Apr 29, 2020
View reviewed changes
danimtb
danimtb previously approved these changes Apr 29, 2020
View reviewed changes
@gocarlos @danimtb
Update recipes/ms-gsl/all/test_package/conanfile.py
6941c5b 
Co-Authored-By: Daniel <danimanzaneque@gmail.com>
@gocarlos gocarlos dismissed stale reviews from danimtb and uilianries via 6941c5b April 29, 2020 13:49
@conan-center-bot
Copy link
Collaborator

An unexpected error happened and has been reported. Help is on its way! 🏇

@uilianries uilianries closed this Apr 30, 2020
@uilianries uilianries reopened this Apr 30, 2020
@conan-center-bot
Copy link
Collaborator

All green in build 10 (6941c5bc0a9d89359b9075c9bfe7aa4720a14054)! 😊

@danimtb danimtb merged commit 59d87ab into conan-io:master Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prince-chrismc prince-chrismc prince-chrismc left review comments

@uilianries uilianries uilianries approved these changes

@danimtb danimtb danimtb approved these changes

@SSE4 SSE4 SSE4 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add microsoft GSL 3.0
6 participants
@gocarlos @conan-center-bot @danimtb @SSE4 @uilianries @prince-chrismc