Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mimalloc: add version 1.7.7/2.0.7, support conan v2 #14174

Merged
merged 13 commits into from
Nov 29, 2022
Merged

mimalloc: add version 1.7.7/2.0.7, support conan v2 #14174

merged 13 commits into from
Nov 29, 2022

Conversation

toge
Copy link
Contributor

@toge toge commented Nov 13, 2022

Specify library name and version: mimalloc/*

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@github-actions github-actions bot mentioned this pull request Nov 13, 2022
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
This was referenced Nov 13, 2022
Open
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
prince-chrismc
prince-chrismc reviewed Nov 20, 2022
View reviewed changes
Copy link
Contributor

@prince-chrismc prince-chrismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor nits but it looks really good

recipes/mimalloc/all/conandata.yml Outdated
- patch_file: "patches/2.0.2-0002-include-cstddef-to-get-std-size-t.patch"
base_path: "source_subfolder"
"1.7.7":
- patch_file: "patches/1.7.7-0001-change-install-paths-avoid-symlink.patch"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch fields please!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prince-chrismc
Thank you for your review!
I added patch_descriptions.

recipes/mimalloc/all/conanfile.py Outdated Show resolved Hide resolved
recipes/mimalloc/all/conanfile.py Outdated Show resolved Hide resolved
recipes/mimalloc/all/conanfile.py Outdated Show resolved Hide resolved
recipes/mimalloc/all/conanfile.py Outdated Show resolved Hide resolved
recipes/mimalloc/all/test_package/conanfile.py Outdated Show resolved Hide resolved
toge and others added 6 commits November 21, 2022 09:59
@toge @prince-chrismc
fix comment
06f023d 
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
@toge @prince-chrismc
fix error message
927c349 
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
@toge @prince-chrismc
fix copy function call
06812fc 
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
@toge @prince-chrismc
fix copy function call
7023f46 
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
@toge @prince-chrismc
remove duplicated import
82ee4be 
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
@toge
add patch_description
5eac40a
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
uilianries
uilianries reviewed Nov 22, 2022
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • please, use if self.options.override and \ with self.info.options.override at line 107

recipes/mimalloc/all/conanfile.py Outdated Show resolved Hide resolved
prince-chrismc
prince-chrismc previously approved these changes Nov 25, 2022
View reviewed changes
@toge @uilianries
use self.info.options
efa97d1 
Co-authored-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline

All green in build 12 (efa97d15d50a696df0007d6caed192896623f077):

  • mimalloc/2.0.5@:
    All packages built successfully! (All logs)

  • mimalloc/2.0.6@:
    All packages built successfully! (All logs)

  • mimalloc/1.6.7@:
    All packages built successfully! (All logs)

  • mimalloc/2.0.2@:
    All packages built successfully! (All logs)

  • mimalloc/1.7.5@:
    All packages built successfully! (All logs)

  • mimalloc/2.0.3@:
    All packages built successfully! (All logs)

  • mimalloc/1.7.6@:
    All packages built successfully! (All logs)

  • mimalloc/2.0.7@:
    All packages built successfully! (All logs)

  • mimalloc/1.7.7@:
    All packages built successfully! (All logs)

uilianries
uilianries approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 9c9f44e into conan-io:master Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uilianries uilianries uilianries approved these changes

@prince-chrismc prince-chrismc prince-chrismc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@toge @conan-center-bot @uilianries @prince-chrismc