Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a big confusion in current assumption of the interaction between
MSBuildToolchain
/MSBuildDeps
generators andMSBuild
helper: actually there is no automagic injection of these props files inMSBuild
currently.I've proposed conan-io/conan#12817 which should allow smooth usage like other families of generators + build helper (
CMakeToolchain
/CMakeDeps
+CMake
,AutotoolsToolchain
/AutotoolsDeps
+Autotools
,MesonToolchain
/MesonDeps
+Meson
etc), but meanwhile this msbuild template is broken. So here is a workaround.Moreover:
configuration
attribute ofMSBuildToolchain
&MSBuildDeps
should be set (usually to the same value thanbuild_type
attribute ofMSBuild
helper, but it can be more tricky).platform
attribute ofMSBuild
should not be overridden usually (and if it's overridden, the one ofMSBuildDeps
should also be overridden accordingly I guess). The default one is more robust than the one proposed previously in this template.VCVars.generate()
, it's already called under the hood byMSBuildToolchain.generate()
(and actually it's more robust because it handles IntelCC).