Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openssl: add embed-bitcode if tools.apple:enable_bitcode is set #15336

Merged
merged 14 commits into from
Mar 21, 2023

Conversation

kletoz
Copy link
Contributor

@kletoz kletoz commented Jan 17, 2023

Specify library name and version: openssl/1.x.x and openssl/3.x.x.

Add -fembed-bitcode if tools.apple:enable_bitcode is configured; only for iOS, tvOS, and watchOS.

It replaces #14580, after rebasing with recent changes from master.


@kletoz kletoz changed the title Openssl bitcode openssl: add embed-bitcode if tools.apple:enable_bitcode is set #14580 Jan 17, 2023
@kletoz kletoz changed the title openssl: add embed-bitcode if tools.apple:enable_bitcode is set #14580 openssl: add embed-bitcode if tools.apple:enable_bitcode is set Jan 17, 2023
@conan-center-bot

This comment has been minimized.

@ghost
Copy link

ghost commented Jan 17, 2023

I detected other pull requests that are modifying openssl/3.x.x recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@ghost ghost mentioned this pull request Jan 19, 2023
3 tasks
@conan-center-bot

This comment has been minimized.

@Nekto89
Copy link
Contributor

Nekto89 commented Jan 26, 2023

isn't bitcode already deprecated by Apple?

@kletoz
Copy link
Contributor Author

kletoz commented Jan 26, 2023

yes, it's deprecated in Xcode 14, but still valid in previous Xcode versions

https://developer.apple.com/documentation/Xcode-Release-Notes/xcode-14-release-notes

@ghost ghost mentioned this pull request Jan 26, 2023
3 tasks
@kletoz
Copy link
Contributor Author

kletoz commented Jan 30, 2023

It seems the error is the same @jngrb is facing in #14426, and it's not strictly related to this PR:

Loading legacy provider failed with this error:
	error:12800067:DSO support routines::could not load the shared library
ERROR: openssl/3.0.5 (test package): Error in test() method, line 33
	self.run(bin_legacy_path, run_environment=True)
	ConanException: Error 1 while executing DYLD_LIBRARY_PATH="/Users/jenkins/w/prod/BuildSingleReference@3/.conan/data/openssl/3.0.5/_/_/package/bfa69ef33bf4f0614c15a5124fd26f840a267c52/lib:/Users/jenkins/w/prod/BuildSingleReference@3/.conan/data/zlib/1.2.13/_/_/package/647afeb69d3b0a2d3d316e80b24d38c714cc6900/lib" DYLD_FRAMEWORK_PATH="" bin/digest_legacy

Should I cherry-pick his commit to here or wait for the merge of this PR? Any suggestion?

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

1 similar comment
@conan-center-bot

This comment has been minimized.

@prince-chrismc
Copy link
Contributor

#16510 must have been added by mistake

@prince-chrismc
Copy link
Contributor

v1 is still working 🤞

@conan-center-bot

This comment has been minimized.

@ghost ghost mentioned this pull request Mar 14, 2023
3 tasks
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 11 (119e0f594b2c4a45249981a0e346e4935544a285):

  • openssl/3.0.7@:
    All packages built successfully! (All logs)

  • openssl/3.0.8@:
    All packages built successfully! (All logs)

  • openssl/1.0.2u@:
    All packages built successfully! (All logs)

  • openssl/3.0.5@:
    All packages built successfully! (All logs)

  • openssl/1.1.1t@:
    All packages built successfully! (All logs)

  • openssl/1.1.1q@:
    All packages built successfully! (All logs)

  • openssl/1.1.0l@:
    All packages built successfully! (All logs)

  • openssl/1.1.1s@:
    All packages built successfully! (All logs)


Conan v2 pipeline (informative, not required for merge) ❌

Note: Conan v2 builds are informative and they are not required for the PR to be merged.

The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future.

See details:

Failure in build 11 (119e0f594b2c4a45249981a0e346e4935544a285):

  • openssl/3.0.7@:
    Error running command conan export --name openssl --version 3.0.7 recipes/openssl/3.x.x/conanfile.py:

    ======== Exporting recipe to the cache ========
    ERROR: Error loading conanfile at '/home/conan/w/prod-v2_cci_PR-15336/recipes/openssl/3.x.x/conanfile.py': Unable to load conanfile in /home/conan/w/prod-v2_cci_PR-15336/recipes/openssl/3.x.x/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod-v2_cci_PR-15336/recipes/openssl/3.x.x/conanfile.py", line 6, in <module>
        from conans import AutoToolsBuildEnvironment, tools
    ImportError: cannot import name 'AutoToolsBuildEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    
  • openssl/3.0.5@:
    Error running command conan export --name openssl --version 3.0.5 recipes/openssl/3.x.x/conanfile.py:

    ======== Exporting recipe to the cache ========
    ERROR: Error loading conanfile at '/home/conan/w/prod-v2_cci_PR-15336/recipes/openssl/3.x.x/conanfile.py': Unable to load conanfile in /home/conan/w/prod-v2_cci_PR-15336/recipes/openssl/3.x.x/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod-v2_cci_PR-15336/recipes/openssl/3.x.x/conanfile.py", line 6, in <module>
        from conans import AutoToolsBuildEnvironment, tools
    ImportError: cannot import name 'AutoToolsBuildEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    
  • openssl/3.0.8@:
    Error running command conan export --name openssl --version 3.0.8 recipes/openssl/3.x.x/conanfile.py:

    ======== Exporting recipe to the cache ========
    ERROR: Error loading conanfile at '/home/conan/w/prod-v2_cci_PR-15336/recipes/openssl/3.x.x/conanfile.py': Unable to load conanfile in /home/conan/w/prod-v2_cci_PR-15336/recipes/openssl/3.x.x/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod-v2_cci_PR-15336/recipes/openssl/3.x.x/conanfile.py", line 6, in <module>
        from conans import AutoToolsBuildEnvironment, tools
    ImportError: cannot import name 'AutoToolsBuildEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@prince-chrismc
Copy link
Contributor

Please do not merge master, the GitHub UI is not the same as the bot logic and it can be confusing.

IT's enabled for maintaers to fix merge conflicts easily :)

@conan-center-bot conan-center-bot merged commit c852cf6 into conan-io:master Mar 21, 2023
RubenRBS pushed a commit to RubenRBS/conan-center-index that referenced this pull request Mar 27, 2023
…code is set

* openssl: add embed-bitcode if tools.apple:enable_bitcode is set

* openssl: add embed-bitcode to watchOS

* openssl: do not override CFLAGS, append instead

* openssl: set bitcode in templates instead of env vars

---------

Co-authored-by: Chris Mc <christopherm@jfrog.com>
@kletoz kletoz deleted the openssl-bitcode branch March 30, 2023 21:14
0xFireWolf pushed a commit to 0xFireWolf/conan-center-index that referenced this pull request Apr 2, 2023
…code is set

* openssl: add embed-bitcode if tools.apple:enable_bitcode is set

* openssl: add embed-bitcode to watchOS

* openssl: do not override CFLAGS, append instead

* openssl: set bitcode in templates instead of env vars

---------

Co-authored-by: Chris Mc <christopherm@jfrog.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants