(#16749) openldap: conan v2 support #16762

grabowski-d · 2023-03-29T08:30:39Z

Specify library name and version: openldap/2.6.1

It solves the issue #16749

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

CLAassistant · 2023-03-29T08:30:46Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ jcar87
❌ grabowski-d
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

ghost · 2023-03-29T08:39:09Z

I detected other pull requests that are modifying openldap/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

github-actions · 2023-04-04T11:28:37Z

Hooks produced the following warnings for commit c4ca47a

openldap/2.6.1

post_package(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './home/conan/w/prod/BuildSingleReference/.conan/data/openldap/2.6.1/_/_/package/f20155a1034f15bf2a5c5a17a93903433764d61b/res/slapd.service' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.

prince-chrismc

Your off to a great start, dropped a bunch of hints for you 😉

prince-chrismc · 2023-04-04T16:05:18Z

recipes/openldap/all/conanfile.py


    @property
    def _source_subfolder(self):
        return "source_subfolder"
-
+    
    def configure(self):
        if self.options.shared:
            del self.options.fPIC


Suggested change

del self.options.fPIC

self.options.rm_safe("fPIC")

prince-chrismc · 2023-04-04T16:05:47Z

recipes/openldap/all/conanfile.py

    }
-    _autotools = None
-    _configure_vars = None

    @property
    def _source_subfolder(self):


This can be removed in favor of a basic_layout

prince-chrismc · 2023-04-04T16:05:58Z

recipes/openldap/all/conanfile.py

+from conan.tools.files import get, apply_conandata_patches, rmdir, rm, copy
+from conan.tools.gnu import AutotoolsToolchain, Autotools, AutotoolsDeps
+from conan.tools.apple import fix_apple_shared_install_name
+from conan.errors import ConanInvalidConfiguration
 required_conan_version = ">=1.43.0"


This should be 1.55

prince-chrismc · 2023-04-04T16:06:14Z

recipes/openldap/all/conanfile.py

    def configure(self):
        if self.options.shared:
            del self.options.fPIC

    def source(self):
-        tools.get(**self.conan_data["sources"][self.version],
+        get(self, **self.conan_data["sources"][self.version],
                  strip_root=True, destination=self._source_subfolder)


You can drop destination

prince-chrismc · 2023-04-04T16:07:03Z

recipes/openldap/all/conanfile.py

@@ -49,55 +49,38 @@ def validate(self):
            raise ConanInvalidConfiguration(
                f"{self.name} is only supported on Linux")


Better to print the same thing as you need for cli or profile for the reference

Suggested change

f"{self.name} is only supported on Linux")

f"{self.ref} is only supported on Linux")

prince-chrismc · 2023-04-04T16:08:01Z

recipes/openldap/all/conanfile.py

+        autotools = Autotools(self)
+        autotools.install()
+        fix_apple_shared_install_name(self)
+        copy(self, "LICENSE", dst="licenses", src=self._source_subfolder)


Suggested change

copy(self, "LICENSE", dst="licenses", src=self._source_subfolder)

copy(self, "LICENSE", dst=os.pathc.join(self.package_folder, "licenses"), src=self.source_folder)

prince-chrismc · 2023-04-04T16:08:52Z

recipes/openldap/all/test_v1_package/test_package.cpp

@@ -0,0 +1,83 @@
+/* ldapurl -- a tool for generating LDAP URLs */


You should check the docs package template this file can be drop if you use the improved CMakeLists.txt 😉

github-actions · 2023-04-11T07:05:12Z

Hooks produced the following warnings for commit 18478c2

openldap/2.6.1

post_package(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './home/conan/w/prod/BuildSingleReference/.conan/data/openldap/2.6.1/_/_/package/646073c4d09549d2aecd80f61e34c49c8205bb5b/res/slapd.service' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.

github-actions · 2023-04-11T10:12:58Z

Hooks produced the following warnings for commit 8f5bed8

openldap/2.6.1

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libldap.so' links to system library 'resolv' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/liblber.so' links to system library 'resolv' but it is not in cpp_info.system_libs.

github-actions · 2023-04-11T12:03:39Z

Hooks produced the following warnings for commit 708ed46

openldap/2.6.1

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libldap.so' links to system library 'resolv' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/liblber.so' links to system library 'resolv' but it is not in cpp_info.system_libs.

stale · 2023-06-18T02:16:34Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions · 2023-06-29T15:10:23Z

Hooks produced the following warnings for commit 4338a2d

openldap/2.6.1

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libldap.so' links to system library 'resolv' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/liblber.so' links to system library 'resolv' but it is not in cpp_info.system_libs.

conan-center-bot · 2023-08-03T09:16:22Z

Conan v1 pipeline ❌

Failure in build 3 (4338a2df3e617a1a992467c69f1ff66abfc90030):

openldap/2.6.1@:
CI failed to create some packages (All logs)

Logs for packageID 435c67b1bf8b94754e1246b0c446e0d2b8c7865e:

[settings]
arch=x86_64
build_type=Debug
compiler=gcc
compiler.libcxx=libstdc++11
compiler.version=9
os=Linux
[options]
openldap:shared=True

[...]
openldap/2.6.1 (test package): Calling build()
openldap/2.6.1 (test package): CMake command: cmake -G "Unix Makefiles" -DCMAKE_TOOLCHAIN_FILE="/home/conan/w/prod-v1/BuildSingleReference/cci-2d5f6f7d/recipes/openldap/all/test_package/build-debug/conan/conan_toolchain.cmake" -DCMAKE_POLICY_DEFAULT_CMP0091="NEW" -DCMAKE_BUILD_TYPE="Debug" "/home/conan/w/prod-v1/BuildSingleReference/cci-2d5f6f7d/recipes/openldap/all/test_package/."

----Running------
> cmake -G "Unix Makefiles" -DCMAKE_TOOLCHAIN_FILE="/home/conan/w/prod-v1/BuildSingleReference/cci-2d5f6f7d/recipes/openldap/all/test_package/build-debug/conan/conan_toolchain.cmake" -DCMAKE_POLICY_DEFAULT_CMP0091="NEW" -DCMAKE_BUILD_TYPE="Debug" "/home/conan/w/prod-v1/BuildSingleReference/cci-2d5f6f7d/recipes/openldap/all/test_package/."
-----------------
-- Using Conan toolchain: /home/conan/w/prod-v1/BuildSingleReference/cci-2d5f6f7d/recipes/openldap/all/test_package/build-debug/conan/conan_toolchain.cmake
-- The CXX compiler identification is GNU 9.2.1
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/g++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Conan: Target declared 'openldap::openldap'
-- Conan: Component target declared 'OpenSSL::Crypto'
-- Conan: Component target declared 'OpenSSL::SSL'
-- Conan: Target declared 'openssl::openssl'
-- Conan: Target declared 'ZLIB::ZLIB'
-- Conan: Including build module from '/home/conan/w/prod-v1/BuildSingleReference/.conan/data/openssl/3.1.1/_/_/package/0a969fabc5bb3a3c9bdf93aca6ce2de02eb34d3a/lib/cmake/conan-official-openssl-variables.cmake'
-- Conan: Target declared 'cyrus-sasl::cyrus-sasl'
-- Configuring done
-- Generating done
-- Build files have been written to: /home/conan/w/prod-v1/BuildSingleReference/cci-2d5f6f7d/recipes/openldap/all/test_package/build-debug
openldap/2.6.1 (test package): CMake command: cmake --build "/home/conan/w/prod-v1/BuildSingleReference/cci-2d5f6f7d/recipes/openldap/all/test_package/build-debug" '--' '-j3'

----Running------
> cmake --build "/home/conan/w/prod-v1/BuildSingleReference/cci-2d5f6f7d/recipes/openldap/all/test_package/build-debug" '--' '-j3'
-----------------
Scanning dependencies of target test_package
[ 50%] Building CXX object CMakeFiles/test_package.dir/test_package.cpp.o
[100%] Linking CXX executable test_package
[100%] Built target test_package
openldap/2.6.1 (test package): Running test()

----Running------
> ./test_package
-----------------
CMake Warning:
  Manually-specified variables were not used by the project:

    CMAKE_POLICY_DEFAULT_CMP0091


./test_package: error while loading shared libraries: liblber.so.2: cannot open shared object file: No such file or directory
WARN: cyrus-sasl/2.1.27: requirement openssl/[>=1.1 <4] overridden by openldap/2.6.1 to openssl/3.1.1 
openldap/2.6.1 (test package): WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
openldap/2.6.1 (test package): WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
ERROR: openldap/2.6.1 (test package): Error in test() method, line 27
	self.run(cmd, env="conanrun")
	ConanException: Error 127 while executing ./test_package

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

Conan v2 pipeline ❌

Note: Conan v2 builds may be required once they are on the v2 ready list

The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future.

See details:

Failure in build 3 (4338a2df3e617a1a992467c69f1ff66abfc90030):

openldap/2.6.1@:
CI failed to create some packages (All logs)

Logs for packageID 0957d559808830755204230e756d5aa007765da2:

[settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.cppstd=17
compiler.libcxx=libstdc++11
compiler.version=11
os=Linux
[options]
*/*:shared=True

[...]
cyrus-sasl/2.1.27: Retrieving package 2bd06dda301f01453ec48e52cfeb25c9be7c3da8 from remote 'conan-center' 
cyrus-sasl/2.1.27: Package installed 2bd06dda301f01453ec48e52cfeb25c9be7c3da8
cyrus-sasl/2.1.27: Downloaded package revision 7f59e8115742f27c279c0e519ba80ff1
openldap/2.6.1: Calling source() in /home/conan/w/prod-v2/BuildSingleReference/p/openl0758234878568/s/src
openldap/2.6.1: Apply patch (file): patches/configure-2.6.1.patch

-------- Installing package openldap/2.6.1 (4 of 4) --------
openldap/2.6.1: Building from source
openldap/2.6.1: Package openldap/2.6.1:0957d559808830755204230e756d5aa007765da2
openldap/2.6.1: Copying sources to build folder
openldap/2.6.1: Building your package in /home/conan/w/prod-v2/BuildSingleReference/p/b/openl11c8f5bcdedc8/b
openldap/2.6.1: Calling generate()
openldap/2.6.1: Generators folder: /home/conan/w/prod-v2/BuildSingleReference/p/b/openl11c8f5bcdedc8/b/build-release/conan
openldap/2.6.1: Generating aggregated env files
openldap/2.6.1: Generated aggregated env files: ['conanbuild.sh', 'conanrun.sh']
openldap/2.6.1: Calling build()
openldap/2.6.1: Calling:
 > "/home/conan/w/prod-v2/BuildSingleReference/p/b/openl11c8f5bcdedc8/b/src/configure" --enable-shared --disable-static --prefix=/ '--bindir=${prefix}/bin' '--sbindir=${prefix}/bin' '--libdir=${prefix}/lib' '--includedir=${prefix}/include' '--oldincludedir=${prefix}/include' --with-cyrus_sasl=yes --with-pic=yes --without-fetch --with-tls=openssl --enable-auditlog '--libexecdir=${prefix}/bin' 
openldap/2.6.1: RUN: "/home/conan/w/prod-v2/BuildSingleReference/p/b/openl11c8f5bcdedc8/b/src/configure" --enable-shared --disable-static --prefix=/ '--bindir=${prefix}/bin' '--sbindir=${prefix}/bin' '--libdir=${prefix}/lib' '--includedir=${prefix}/include' '--oldincludedir=${prefix}/include' --with-cyrus_sasl=yes --with-pic=yes --without-fetch --with-tls=openssl --enable-auditlog '--libexecdir=${prefix}/bin' 
Configuring OpenLDAP 2.6.1-Release ...
checking build system type... x86_64-pc-linux-gnu
checking host system type... x86_64-pc-linux-gnu
checking target system type... x86_64-pc-linux-gnu
checking configure arguments... done
checking for cc... cc
checking for ar... ar
checking for strip... strip
checking whether make sets $(MAKE)... yes
checking how to print strings... printf
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables... 
checking whether we are cross compiling... configure: error: in `/home/conan/w/prod-v2/BuildSingleReference/p/b/openl11c8f5bcdedc8/b/build-release':
configure: error: cannot run C compiled programs.
If you meant to cross compile, use `--host'.
See `config.log' for more details

openldap/2.6.1: ERROR: 
Package '0957d559808830755204230e756d5aa007765da2' build failed
openldap/2.6.1: WARN: Build folder /home/conan/w/prod-v2/BuildSingleReference/p/b/openl11c8f5bcdedc8/b/build-release
*********************************************************
Recipe 'openldap/2.6.1' cannot build its binary
It is possible that this recipe is not Conan 2.0 ready
If the recipe comes from ConanCenter check: https://conan.io/cci-v2.html
If it is your recipe, check if it is updated to 2.0
*********************************************************

ERROR: openldap/2.6.1: Error in build() method, line 75
	autotools.configure()
	ConanException: Error 1 while executing

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

github-actions · 2023-08-03T09:16:40Z

Hooks produced the following warnings for commit 4338a2d

openldap/2.6.1

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libldap.so' links to system library 'resolv' but it is not in cpp_info.system_libs.

stale · 2023-10-15T11:08:12Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions · 2024-02-16T06:36:40Z

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

uilianries · 2024-04-19T13:24:31Z

The openldap is now working with Conan 2.x. Please, update your local copy and feel free to open an issue in case finding something wrong.

conan install -r conancenter --update --requires=openldap/2.6.7

conan-center-bot added the User-approval pending label Mar 29, 2023

This comment has been minimized.

Sign in to view

grabowski-d mentioned this pull request Mar 29, 2023

[!!] Access request #4

Open

This comment has been minimized.

Sign in to view

ghost mentioned this pull request Mar 29, 2023

[service] Potentially conflicting recipes #3571

Closed

ghost mentioned this pull request Mar 29, 2023

openldap: improve compatibility with different build environments #16589

Closed

3 tasks

This comment has been minimized.

Sign in to view

prince-chrismc mentioned this pull request Mar 29, 2023

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

grabowski-d force-pushed the master branch from 819e5a6 to 65c3417 Compare March 29, 2023 10:56

This comment has been minimized.

Sign in to view

grabowski-d force-pushed the master branch from 65c3417 to 3700dfb Compare March 30, 2023 18:40

This comment has been minimized.

Sign in to view

prince-chrismc mentioned this pull request Mar 30, 2023

[bot] Update authorized users list (2023-03-30) #16791

Merged

prince-chrismc closed this Apr 1, 2023

prince-chrismc reopened this Apr 1, 2023

conan-center-bot added Failed and removed User-approval pending labels Apr 1, 2023

This comment has been minimized.

Sign in to view

grabowski-d force-pushed the master branch from 3700dfb to c4ca47a Compare April 4, 2023 11:00

This comment has been minimized.

Sign in to view

prince-chrismc reviewed Apr 4, 2023

View reviewed changes

grabowski-d force-pushed the master branch from c4ca47a to 18478c2 Compare April 11, 2023 06:52

This comment has been minimized.

Sign in to view

grabowski-d force-pushed the master branch from 18478c2 to 8f5bed8 Compare April 11, 2023 09:49

This comment has been minimized.

Sign in to view

conan-center-bot added Unexpected Error and removed Failed labels May 5, 2023

This comment has been minimized.

Sign in to view

conan-center-bot added Failed and removed Unexpected Error labels May 7, 2023

This comment has been minimized.

Sign in to view

stale bot added the stale label Jun 18, 2023

jcar87 self-assigned this Jun 29, 2023

stale bot removed the stale label Jun 29, 2023

jcar87 added 2 commits June 29, 2023 15:49

openldap: fixes

9b0c70c

fix yaml indentation

4338a2d

This comment has been minimized.

Sign in to view

ghost mentioned this pull request Jul 22, 2023

openldap: migrate to Conan v2 #18800

Merged

conan-center-bot added Service Under Maintenance and removed Failed labels Jul 24, 2023

This comment has been minimized.

Sign in to view

conan-center-bot added Failed and removed Service Under Maintenance labels Aug 3, 2023

stale bot added the stale label Oct 15, 2023

valgur mentioned this pull request Nov 8, 2023

Conan 2.0 migration: the final 100 #20992

Closed

github-actions bot closed this Feb 16, 2024

		@@ -49,55 +49,38 @@ def validate(self):
		raise ConanInvalidConfiguration(
		f"{self.name} is only supported on Linux")

	f"{self.name} is only supported on Linux")
	f"{self.ref} is only supported on Linux")

	copy(self, "LICENSE", dst="licenses", src=self._source_subfolder)
	copy(self, "LICENSE", dst=os.pathc.join(self.package_folder, "licenses"), src=self.source_folder)

		@@ -0,0 +1,83 @@
		/* ldapurl -- a tool for generating LDAP URLs */

(#16749) openldap: conan v2 support #16762

(#16749) openldap: conan v2 support #16762

Conversation

grabowski-d commented Mar 29, 2023 • edited

CLAassistant commented Mar 29, 2023 • edited

This comment has been minimized.

This comment has been minimized.

ghost commented Mar 29, 2023 • edited by ghost

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Apr 4, 2023

prince-chrismc left a comment

Choose a reason for hiding this comment

prince-chrismc Apr 4, 2023

Choose a reason for hiding this comment

prince-chrismc Apr 4, 2023

Choose a reason for hiding this comment

prince-chrismc Apr 4, 2023

Choose a reason for hiding this comment

prince-chrismc Apr 4, 2023

Choose a reason for hiding this comment

prince-chrismc Apr 4, 2023

Choose a reason for hiding this comment

prince-chrismc Apr 4, 2023

Choose a reason for hiding this comment

prince-chrismc Apr 4, 2023

Choose a reason for hiding this comment

This comment has been minimized.

github-actions bot commented Apr 11, 2023

This comment has been minimized.

github-actions bot commented Apr 11, 2023

This comment has been minimized.

github-actions bot commented Apr 11, 2023

This comment has been minimized.

This comment has been minimized.

stale bot commented Jun 18, 2023

This comment has been minimized.

github-actions bot commented Jun 29, 2023

This comment has been minimized.

conan-center-bot commented Aug 3, 2023

Conan v1 pipeline ❌

Conan v2 pipeline ❌

github-actions bot commented Aug 3, 2023

stale bot commented Oct 15, 2023

github-actions bot commented Feb 16, 2024

uilianries commented Apr 19, 2024

grabowski-d commented Mar 29, 2023 •

edited

CLAassistant commented Mar 29, 2023 •

edited

ghost commented Mar 29, 2023 •

edited by ghost