openvr: Bump deps and upgrade for conan v2 #16913
Conversation
paulharris
changed the title
This comment has been minimized.
This comment has been minimized.
|
Seems like a pretty cryptic error... Which I assume is enough to test the library was able to link and execute... |
This comment has been minimized.
This comment has been minimized.
recipes/openvr/all/conanfile.py
Outdated
| @property | ||
| def _source_subfolder(self): | ||
| return "source_subfolder" | ||
| def _compilers_minimum_version(self): | ||
| return { | ||
| "Visual Studio": "15", | ||
| "msvc": "14.1", | ||
| "gcc": "5", | ||
| "clang": "5", | ||
| "apple-clang": "5.1", | ||
| } |
There was a problem hiding this comment.
Besides wrong msvc version, why do you restrict more than before? It was raising for gcc < 5 only, so we know it works for Visual Studio 2015 for example. You should keep previous logic.
There was a problem hiding this comment.
ok then, I've reverted :)
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
|
I detected other pull requests that are modifying openvr/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
Conan v1 pipeline ❌Sorry, the system is under maintenance and it doesn't accept builds right now. Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future. See details:Sorry, the system is under maintenance and it doesn't accept builds right now. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
I'm happy to close this in preference for #18788, which appears to supersede this PR. |
Specify library name and version: lib/1.0