Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rocksdb: conan v2 support #17186

Merged
merged 12 commits into from
Nov 15, 2023
Merged

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Apr 24, 2023

Specify library name and version: lib/1.0


@conan-center-bot

This comment has been minimized.

@CLAassistant
Copy link

CLAassistant commented May 18, 2023

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@RubenRBS RubenRBS self-assigned this Oct 5, 2023
Copy link
Member

@RubenRBS RubenRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The recipe migration looks good but the ctest thingy we've come to the conclusion that it's not wanted - could you please go back to the usual way there? Thanks!

recipes/rocksdb/all/test_package/conanfile.py Show resolved Hide resolved
@ghost
Copy link

ghost commented Oct 18, 2023

I detected other pull requests that are modifying rocksdb/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Oct 20, 2023

It should work hopefully. There was an issue while cross-building from Intel to M1 on macOS, but it works fine for me locally after these fixes.

There was also an issue in 6.0.2, where static and shared were installed together (catched by very last hook KB-H076). Since CMakeLists is significantly different in this version compared to other versions maintained in this recipe, I've dropped this version.

@conan-center-bot

This comment has been minimized.

@RubenRBS
Copy link
Member

Let us know if you need any help @SpaceIm :)

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Oct 27, 2023

Let us know if you need any help @SpaceIm :)

Yep, any help would be appreciated. Cross build works fine on my mac with rocksdb/6.29.5, I've not tested rocksdb/6.8.1 but I don't understand why it fails in c3i.

@Bronek
Copy link
Contributor

Bronek commented Nov 11, 2023

Let us know if you need any help @SpaceIm :)

Yep, any help would be appreciated. Cross build works fine on my mac with rocksdb/6.29.5, I've not tested rocksdb/6.8.1 but I don't understand why it fails in c3i.

I think this is caused by linker errors, right ?

rocksdb/6.8.1 (test package): Running CMake.build()
rocksdb/6.8.1 (test package): RUN: cmake --build "/Users/jenkins/w/prod-v2/bsr/cci-44d8b8dd/recipes/rocksdb/all/test_package/build/apple-clang-13-armv8-17-release" -- -j4
[ 25%] Building CXX object CMakeFiles/test_package_cpp.dir/test_package.cpp.o
[ 50%] Building CXX object CMakeFiles/test_package_stable_abi.dir/test_package_stable_abi.cpp.o
[ 75%] Linking CXX executable test_package_stable_abi
Undefined symbols for architecture arm64:
  "_rocksdb_close", referenced from:
      _main in test_package_stable_abi.cpp.o
  "_rocksdb_free", referenced from:
      _main in test_package_stable_abi.cpp.o
  "_rocksdb_open", referenced from:
      _main in test_package_stable_abi.cpp.o
  "_rocksdb_options_create", referenced from:
      _main in test_package_stable_abi.cpp.o
  "_rocksdb_options_set_create_if_missing", referenced from:
      _main in test_package_stable_abi.cpp.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [test_package_stable_abi] Error 1
make[1]: *** [CMakeFiles/test_package_stable_abi.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[100%] Linking CXX executable test_package_cpp
[100%] Built target test_package_cpp
make: *** [all] Error 2

*********************************************************
Recipe 'rocksdb/6.8.1 (test package)' cannot build its binary

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Nov 11, 2023

Yes sure, the problem is what is the root cause and how to fix it?

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 9 (5a6052deba7a40eca091c5865a8cf81255bdd70f):

  • rocksdb/6.29.5:
    All packages built successfully! (All logs)

  • rocksdb/6.27.3:
    All packages built successfully! (All logs)

  • rocksdb/6.20.3:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 9 (5a6052deba7a40eca091c5865a8cf81255bdd70f):

  • rocksdb/6.20.3:
    All packages built successfully! (All logs)

  • rocksdb/6.29.5:
    All packages built successfully! (All logs)

  • rocksdb/6.27.3:
    All packages built successfully! (All logs)

@Bronek
Copy link
Contributor

Bronek commented Nov 14, 2023

Thank you for porting #21049 . Note, the same fix also applies to version 6.27.3 (but not 6.20.3)

@conan-center-bot conan-center-bot merged commit 8c827c5 into conan-io:master Nov 15, 2023
23 checks passed
@SpaceIm SpaceIm deleted the rocksdb-conan-v2 branch November 15, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants