-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rocksdb: conan v2 support #17186
rocksdb: conan v2 support #17186
Conversation
20f53cb
to
121d7e3
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! The recipe migration looks good but the ctest thingy we've come to the conclusion that it's not wanted - could you please go back to the usual way there? Thanks!
I detected other pull requests that are modifying rocksdb/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
It should work hopefully. There was an issue while cross-building from Intel to M1 on macOS, but it works fine for me locally after these fixes. There was also an issue in 6.0.2, where static and shared were installed together (catched by very last hook KB-H076). Since CMakeLists is significantly different in this version compared to other versions maintained in this recipe, I've dropped this version. |
This comment has been minimized.
This comment has been minimized.
Let us know if you need any help @SpaceIm :) |
Yep, any help would be appreciated. Cross build works fine on my mac with rocksdb/6.29.5, I've not tested rocksdb/6.8.1 but I don't understand why it fails in c3i. |
I think this is caused by linker errors, right ?
|
Yes sure, the problem is what is the root cause and how to fix it? |
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 9 (
Conan v2 pipeline ✔️
All green in build 9 ( |
Thank you for porting #21049 . Note, the same fix also applies to version 6.27.3 (but not 6.20.3) |
Specify library name and version: lib/1.0