android-ndk: do not use wrapper scripts for clang #17636
Conversation
|
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
I detected other pull requests that are modifying android-ndk/all recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 3 (
Conan v2 pipeline ✔️
All green in build 3 (
|
| # For x86 targets prior to Android Nougat (API 24), -mstackrealign is needed to properly align stacks for global constructors. See https://github.com/android/ndk/issues/635. | ||
| # https://android.googlesource.com/platform/ndk/+/refs/heads/ndk-release-r21/docs/BuildSystemMaintainers.md#additional-required-arguments | ||
| if self.settings_target.arch == "x86" and int(str(self.settings_target.os.api_level)) < 24: | ||
| compiler_flags.append("-mstackrealign") |
There was a problem hiding this comment.
I think this flag is not needed for newer versions of the ndk, as since 2018 this is already fixed: android/ndk#635 (comment)
Which ndk version are you using?
There was a problem hiding this comment.
I am using NDK version 23.1.7779620 (r23b). The change you linked appears to be a fix for the wrapper scripts. Since this PR aims to stop using the wrapper scripts, the flags need to be passed manually.
| # https://github.com/android/ndk/issues/1856 | ||
| compiler_flags = [f"--target={self._clang_target}"] |
There was a problem hiding this comment.
Having a closer look at the issue it is not clear this solves the issue. As it is still in discussion, I would like to know if you have checked this isolated fix by yourself.
There was a problem hiding this comment.
The issue I encountered closely resembled one I experienced when building my project with the libsodium package as a dependency. I traced the problem to the wrapper scripts, as described here, which resolved the issue for me.
I then attempted to modify the android-ndk recipe so I wouldn't have to manually adjust the NDK scripts on my machine. I tested the build both without my changes in the recipe (where it failed) and with them (where it succeeded). I've been using the android-ndk package with these modifications for several months now and haven't faced any issues. However, I should note that I only use it for cross-compiling from Windows to Android.
If necessary, I can provide a minimal reproducible example to demonstrate the issue.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions. |
Specify library name and version: android-ndk/all
This changes are meant to fix the issue of
.cmdwrapper scripts forclang, which is described here android/ndk#1856. I stumbled across this issue when I was trying to cross build (Windows to Android)libsodiumpackage withandroid-ndkas a build requirement.