Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ncurses] Add conan 2.0 compatibility #17805

Closed

Conversation

samuel-emrys
Copy link
Contributor

This is a continuation of previous attempts to add conan 2 compatibility in #16780 and #15062


@CLAassistant
Copy link

CLAassistant commented Jun 3, 2023

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@samuel-emrys samuel-emrys marked this pull request as draft July 4, 2023 10:51
@ghost ghost mentioned this pull request Jul 15, 2023
@ghost
Copy link

ghost commented Jul 15, 2023

I detected other pull requests that are modifying ncurses/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@samuel-emrys
Copy link
Contributor Author

samuel-emrys commented Jul 16, 2023

@madebr I resurrected this PR (originally authored in #16780) in the hope of resolving its issues and getting ncurses integrated for conan 2.0. It looks to already be in a really good state, but it's currently failing on shared MSVC builds (see the error in CI) - it's failing to build the terminfo database. There appears to be very little in the way of error messages or logs for me to latch onto here, so I'm having a hard time identifying what the problem actually is.

To make matters worse, I'm also having a hard time getting the 1.x variant to work, which would have helped me identify the difference between the two recipes to close the gap and hopefully resolve the issue.

I noticed that you were responsible for facilitating the upstreaming of the MSVC compatibility a few years ago in mirror/ncurses#1 - wondering if you're able to point me in the right direction here? Any ideas what might be breaking? Any help you can provide is appreciated.

@madebr
Copy link
Contributor

madebr commented Jul 16, 2023

Comparing the failed log with the output of these logs, the only difference I see is conan v2 adding DESTDIR=.. to make install.

@conan-center-bot

This comment has been minimized.

1 similar comment
@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Failure in build 3 (8e33b8d2c4bd854e6632a822716886a91a378f43):

  • ncurses/6.3@:
    Didn't run or was cancelled before finishing

  • ncurses/6.4@:
    CI failed to create some packages (All logs)

    Logs for packageID d8750081d569e70303761db379eaccc3ef395e6e:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=Visual Studio
    compiler.runtime=MD
    compiler.version=16
    os=Windows
    [options]
    ncurses:shared=True
    
    [...]
    /c/j2/w/prod-v1/buildsinglereference/s/48ae5e/1/bin/msys64/usr/bin/install -c -m 755 ../lib/formw6.dll /c/j2/w/prod-v1/buildsinglereference/.conan/data/ncurses/6.4/_/_/package/d8750081d569e70303761db379eaccc3ef395e6e/bin/formw6.dll
    installing ../lib/formw.dll.lib as /c/j2/w/prod-v1/buildsinglereference/.conan/data/ncurses/6.4/_/_/package/d8750081d569e70303761db379eaccc3ef395e6e/lib/formw.dll.lib
    /c/j2/w/prod-v1/buildsinglereference/s/48ae5e/1/bin/msys64/usr/bin/install -c -m 644 ../lib/formw.dll.lib /c/j2/w/prod-v1/buildsinglereference/.conan/data/ncurses/6.4/_/_/package/d8750081d569e70303761db379eaccc3ef395e6e/lib/formw.dll.lib
    installing /c/j2/w/prod-v1/buildsinglereference/.conan/data/ncurses/6.4/_/_/build/d8750081d569e70303761db379eaccc3ef395e6e/form/form.h in /c/j2/w/prod-v1/buildsinglereference/.conan/data/ncurses/6.4/_/_/package/d8750081d569e70303761db379eaccc3ef395e6e/include
    make[1]: Leaving directory '/c/J2/w/prod-v1/BuildSingleReference/.conan/data/ncurses/6.4/_/_/build/d8750081d569e70303761db379eaccc3ef395e6e/form'
    ( cd misc && make DESTDIR="/c/j2/w/prod-v1/buildsinglereference/.conan/data/ncurses/6.4/_/_/package/d8750081d569e70303761db379eaccc3ef395e6e" RPATH_LIST="/lib" install )
    make[1]: Entering directory '/c/J2/w/prod-v1/BuildSingleReference/.conan/data/ncurses/6.4/_/_/build/d8750081d569e70303761db379eaccc3ef395e6e/misc'
    mkdir -p /c/j2/w/prod-v1/buildsinglereference/.conan/data/ncurses/6.4/_/_/package/d8750081d569e70303761db379eaccc3ef395e6e//share
    mkdir -p /c/j2/w/prod-v1/buildsinglereference/.conan/data/ncurses/6.4/_/_/package/d8750081d569e70303761db379eaccc3ef395e6e//share/tabset
    DESTDIR=/c/j2/w/prod-v1/buildsinglereference/.conan/data/ncurses/6.4/_/_/package/d8750081d569e70303761db379eaccc3ef395e6e \
    prefix=/ \
    exec_prefix=/ \
    bindir=/bin \
    top_srcdir=/c/j2/w/prod-v1/buildsinglereference/.conan/data/ncurses/6.4/_/_/build/d8750081d569e70303761db379eaccc3ef395e6e \
    srcdir=/c/j2/w/prod-v1/buildsinglereference/.conan/data/ncurses/6.4/_/_/build/d8750081d569e70303761db379eaccc3ef395e6e/misc \
    datadir=//share \
    ticdir=//share/terminfo \
    source=terminfo.tmp \
    cross_compiling=no \
    /bin/sh ./run_tic.sh
    ** Building terminfo database, please wait...
    Running sh /c/j2/w/prod-v1/buildsinglereference/.conan/data/ncurses/6.4/_/_/build/d8750081d569e70303761db379eaccc3ef395e6e/misc/shlib tic to install /c/j2/w/prod-v1/buildsinglereference/.conan/data/ncurses/6.4/_/_/package/d8750081d569e70303761db379eaccc3ef395e6e//share/terminfo ...
    
    	You may see messages regarding extended capabilities, e.g., AX.
    	These are extended terminal capabilities which are compiled
    	using
    		tic -x
    	If you have ncurses 4.2 applications, you should read the INSTALL
    	document, and install the terminfo without the -x option.
    
    ncurses 6.4.20221231
    ? tic could not build /c/j2/w/prod-v1/buildsinglereference/.conan/data/ncurses/6.4/_/_/package/d8750081d569e70303761db379eaccc3ef395e6e//share/terminfo
    make[1]: Leaving directory '/c/J2/w/prod-v1/BuildSingleReference/.conan/data/ncurses/6.4/_/_/build/d8750081d569e70303761db379eaccc3ef395e6e/misc'
    configure: WARNING: your environment uses the CC variable to hold CFLAGS/CPPFLAGS options
    configure: WARNING: pkg-config is not installed
    configure: WARNING: _POSIX_C_SOURCE definition is not usable
    configure: WARNING: _XOPEN_SOURCE feature test macro appears to be predefined
    configure: WARNING: cannot find regular expression library
    configure: WARNING: no regular expression header found
    mv: cannot stat 'conftest.o': No such file or directory
    mv: cannot stat 'conftest.o': No such file or directory
    cl : Command line warning D9035 : option 'o' has been deprecated and will be removed in a future release
    cl : Command line warning D9035 : option 'o' has been deprecated and will be removed in a future release
    cl : Command line warning D9035 : option 'o' has been deprecated and will be removed in a future release
    make[1]: *** [Makefile:109: install.data] Error 1
    make: *** [Makefile:139: install] Error 2
    ncurses/6.4: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    ERROR: ncurses/6.4: Error in package() method, line 262
    	autotools.install()
    	ConanException: Error 2 while executing make install DESTDIR=/c/j2/w/prod-v1/buildsinglereference/.conan/data/ncurses/6.4/_/_/package/d8750081d569e70303761db379eaccc3ef395e6e -j8
    
  • ncurses/6.2@:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.


Conan v2 pipeline ❌

Note: Conan v2 builds may be required once they are on the v2 ready list

The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future.

See details:

Sorry, the system is under maintenance and it doesn't accept builds right now.
Please, check https://status.conan.io to obtain more information.
Thanks for your understanding and help with the Conan Center Index!

@samuel-emrys samuel-emrys mentioned this pull request Sep 3, 2023
3 tasks
@stale
Copy link

stale bot commented Sep 17, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 17, 2023
@samuel-emrys
Copy link
Contributor Author

bump

@benny-edlund
Copy link

Bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants