Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spdlog: bump fmt10.0.0 and apply patch to fix build error #17976

Merged
merged 1 commit into from
Jun 28, 2023
Merged

spdlog: bump fmt10.0.0 and apply patch to fix build error #17976

merged 1 commit into from
Jun 28, 2023

Conversation

pwqbot
Copy link
Contributor

@pwqbot pwqbot commented Jun 20, 2023 •
edited

Specify library name and version: spdlog/1.11.0

problems:
spdlog 1.11.0 do not support. fmt 10
gabime/spdlog#2782
gabime/spdlog#2767

relate pr:
gabime/spdlog#2694
spack/spack#38082

@CLAassistant
Copy link

CLAassistant commented Jun 20, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

pwqbot
pwqbot commented Jun 20, 2023
View reviewed changes
recipes/spdlog/all/conandata.yml
- patch_file: "patches/1.11.0-0001-fix-fmt10-build.patch"
patch_description: "Fix fmt 10.0.0 build"
patch_type: "conan"
patch_source: "https://github.com/gabime/spdlog/pull/2694"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to a commit that modified this file prior to this commit, it was not possible to directly apply the patch file of this PR. Therefore, I copied the changes from this commit and created a patch file myself.

@prince-chrismc prince-chrismc mentioned this pull request Jun 20, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@pwqbot pwqbot changed the title spdlog: fix build error with fmt10.0.0 spdlog: bump fmt10.0.0 and apply patch to fix build error Jun 20, 2023
@prince-chrismc prince-chrismc mentioned this pull request Jun 26, 2023
Merged
@pwqbot pwqbot closed this Jun 27, 2023
@pwqbot pwqbot reopened this Jun 27, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@jcar87 jcar87 self-assigned this Jun 27, 2023
@jcar87
Copy link
Contributor

jcar87 commented Jun 27, 2023

Hi @pwqbot - thank you for your contribution. In order to keep traceability and for us to understand the motivation behind these changes, could you update the PR description with details of the compiler error that would experienced if this patch is not applied?

@pwqbot
Copy link
Contributor Author

pwqbot commented Jun 27, 2023 •
edited

Hi @pwqbot - thank you for your contribution. In order to keep traceability and for us to understand the motivation behind these changes, could you update the PR description with details of the compiler error that would experienced if this patch is not applied?

@jcar87 Sure, I have updated the related issue and pull request in the description.

@jcar87
Copy link
Contributor

jcar87 commented Jun 27, 2023

Hi @pwqbot - thank you for your contribution. In order to keep traceability and for us to understand the motivation behind these changes, could you update the PR description with details of the compiler error that would experienced if this patch is not applied?

@jcar87 Sure, I have updated the related issue and pull request in the description.

Awesome, thanks so much!

jcar87
jcar87 approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@jcar87 jcar87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for taking the time and effort to investigate and resolve this issue. The added details are really helpful and will help review whether the patch is needed in the future.

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 6 (b9ed9c2dde7a62b7e6b15f776fb1955b95aeaa8f):

  • spdlog/1.11.0@:
    All packages built successfully! (All logs)

  • spdlog/1.8.5@:
    All packages built successfully! (All logs)

  • spdlog/1.10.0@:
    All packages built successfully! (All logs)

  • spdlog/1.9.1@:
    All packages built successfully! (All logs)

  • spdlog/1.9.2@:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 4 (b9ed9c2dde7a62b7e6b15f776fb1955b95aeaa8f):

  • spdlog/1.11.0@:
    All packages built successfully! (All logs)

  • spdlog/1.10.0@:
    All packages built successfully! (All logs)

  • spdlog/1.8.5@:
    All packages built successfully! (All logs)

  • spdlog/1.9.2@:
    All packages built successfully! (All logs)

  • spdlog/1.9.1@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit d51d126 into conan-io:master Jun 28, 2023
39 checks passed
@Seadex-GmbH
Copy link
Contributor

The last PR introduced a bug (which can be a chain breaker for other libraries): #18134

@jwidauer jwidauer mentioned this pull request Jul 4, 2023
Open
@prince-chrismc prince-chrismc mentioned this pull request Jul 4, 2023
Merged
conan-center-bot pushed a commit that referenced this pull request Jul 6, 2023
@Seadex-GmbH @czoido
(#17505) Add seadex-genesis library recipe - Conan 2 ready
6b6f154 
* Add seadex-genesis library recipe

* Update recipes/seadex-genesis/all/test_package/CMakeLists.txt

* Make seadex-essentials transitive

* Removed header only requirement flag for fmt, spdlog

* Use fmt 10.0.0 because of PR #17976

---------

Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
tannerbitz pushed a commit to tannerbitz/conan-center-index that referenced this pull request Jul 8, 2023
@pwqbot @tannerbitz
(conan-io#17976) spdlog: bump fmt10.0.0 and apply patch to fix build …
62c5984 
…error
pezy pushed a commit to pezy/conan-center-index that referenced this pull request Jul 15, 2023
@pwqbot @pezy
(conan-io#17976) spdlog: bump fmt10.0.0 and apply patch to fix build …
62b09a1 
…error
pezy pushed a commit to pezy/conan-center-index that referenced this pull request Jul 15, 2023
@Seadex-GmbH @czoido @pezy
(conan-io#17505) Add seadex-genesis library recipe - Conan 2 ready
37e61e5 
* Add seadex-genesis library recipe

* Update recipes/seadex-genesis/all/test_package/CMakeLists.txt

* Make seadex-essentials transitive

* Removed header only requirement flag for fmt, spdlog

* Use fmt 10.0.0 because of PR conan-io#17976

---------

Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CJCombrink CJCombrink CJCombrink approved these changes

@jcar87 jcar87 jcar87 approved these changes

@czoido czoido czoido approved these changes

Assignees

@jcar87 jcar87

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@pwqbot @CLAassistant @conan-center-bot @jcar87 @Seadex-GmbH @CJCombrink @czoido