sdl_ttf: and 2.20.2, bump dep sdl, conan v2 fixes #18366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
…15 + add support for 2.20.2 :)
This comment has been minimized.
This comment has been minimized.
prince-chrismc
commented
Jul 6, 2023
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit c0b8b37sdl_ttf/2.0.15sdl_ttf/2.0.18 |
jcar87
reviewed
Jul 7, 2023
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 5ec9cd1sdl_ttf/2.0.18sdl_ttf/2.0.15 |
|
This never built with v2 #15560 (comment) And v2 is not required 🙄 |
prince-chrismc
commented
Jul 8, 2023
prince-chrismc
changed the title
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 79d3824sdl_ttf/2.0.18sdl_ttf/2.0.15 |
This was referenced Jul 9, 2023
Conan v1 pipeline ✔️All green in build 7 (
Conan v2 pipeline ✔️
All green in build 6 ( |
czoido
approved these changes
Jul 10, 2023
SSE4
approved these changes
Jul 10, 2023
amrox
pushed a commit
to exyntech/conan-center-index
that referenced
this pull request
Jul 12, 2023
* sdl_ttf: bump dep sdl * patch 3.17 requirements to keep in line with Conan's min supported 3.15 + add support for 2.20.2 :) * Update recipes/sdl_ttf/all/conandata.yml * Update recipes/sdl_ttf/all/conanfile.py * Update recipes/sdl_ttf/all/conanfile.py * Add missing ios frameworks --------- Co-authored-by: Luis Caro Campos <3535649+jcar87@users.noreply.github.com>
pezy
pushed a commit
to pezy/conan-center-index
that referenced
this pull request
Jul 15, 2023
* sdl_ttf: bump dep sdl * patch 3.17 requirements to keep in line with Conan's min supported 3.15 + add support for 2.20.2 :) * Update recipes/sdl_ttf/all/conandata.yml * Update recipes/sdl_ttf/all/conanfile.py * Update recipes/sdl_ttf/all/conanfile.py * Add missing ios frameworks --------- Co-authored-by: Luis Caro Campos <3535649+jcar87@users.noreply.github.com>
SpaceIm
reviewed
Aug 7, 2023
Comment on lines
+126
to
+129
| if Version(self.version) <= "2.0.18" and is_apple_os(self) and self.options.shared: | ||
| self.cpp_info.components["_sdl2_ttf"].frameworks = [ | ||
| "AppKit", "CoreGraphics", "CoreFoundation", "CoreServices" | ||
| ] |
There was a problem hiding this comment.
It makes no sense, it should be for static only, not shared.
There was a problem hiding this comment.
Please open an issue with more information :) If the hooks are incorrect #18366 (comment) please open an issue there so we can track it 🙏
There was a problem hiding this comment.
Hook is correct, but your interpretation of its result is incorrect.
There was a problem hiding this comment.
This hook just says that shared lib links to some system libs or frameworks, so it means that these system libs/frameworks must be added if static. This hook has always been an indirect way to find system libs or frameworks to add if static (for shared it doesn't matter since it's already linked obviously).
There was a problem hiding this comment.
I'd argue the hooks are bad for providing misleading information
Library './lib/libSDL2_ttf.dylib' links to system library
implies the shared one needs it, if that incorrect -- then the messages are unclear -- it should have included the settings and options to be more concise :)
There was a problem hiding this comment.
Feel free to update message hook if you think it's misleading.
Instead of:
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2_ttf.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
it could be:
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2_ttf.dylib' links to system library 'CoreServices', therefore 'CoreServices' should be in cpp_info.frameworks if static, but it's missing.
There was a problem hiding this comment.
Done, thanks for the suggestion!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: lib/1.0