Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libidn2: migrate to Conan v2, add shared MSVC build #18642

Merged
merged 12 commits into from
Apr 17, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 19, 2023

No description provided.

@conan-center-bot

This comment has been minimized.

@valgur valgur closed this Jul 21, 2023
@valgur valgur reopened this Jul 21, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@valgur
Copy link
Contributor Author

valgur commented Jul 26, 2023

Closing temporarily to avoid unnecessary load on the CI. Will reopen when I'm actively working on the PR again.

@conan-center-bot

This comment has been minimized.

@stale
Copy link

stale bot commented Sep 17, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 17, 2023
@stale stale bot removed the stale label Oct 16, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Member

@RubenRBS RubenRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping me when you get to fix this so we can unblock the linked PR, thanks! :)

@valgur valgur changed the title libidn2: migrate to Conan v2 libidn2: migrate to Conan v2, add shared MSVC build Dec 8, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

Hooks produced the following warnings for commit 9ede667
libidn2/2.3.0@#0ffe32a803cfe741f78289de244095f8
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libidn2.0.dylib, libidn2.dylib

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 15 (13044bab64a80af287613d42760ac72885b4566b):

  • libidn2/2.3.0:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 15 (13044bab64a80af287613d42760ac72885b4566b):

  • libidn2/2.3.0:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 4e27949 into conan-io:master Apr 17, 2024
13 checks passed
franramirez688 pushed a commit to toge/conan-center-index that referenced this pull request Apr 23, 2024
* libidn2: migrate to Conan v2

* libidn2: bump deps

* libidn2: tidy

* libidn2: fix shared lib not being found in v1

* libidn2: fix test_package

* libidn2: fix MSVC build

* libidn2: add shared MSVC build support

* libidn2: tc.extra_cflags.append("-FS")

* libidn2: fix_apple_shared_install_name()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants