Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wineditline: migrate to Conan v2 #18652

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

wineditline: migrate to Conan v2 #18652

wants to merge 2 commits into from
+92 −106

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 19, 2023 •
edited

No description provided.

@conan-center-bot

This comment has been minimized.

Sign in to view
@prince-chrismc prince-chrismc mentioned this pull request Jul 19, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur
Copy link
Contributor Author

valgur commented Jul 26, 2023

Closing temporarily to avoid unnecessary load on the CI. Will reopen when I'm actively working on the PR again.

@valgur valgur closed this Jul 26, 2023
@valgur valgur reopened this Aug 18, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@stale
Copy link

stale bot commented Sep 17, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 17, 2023
@stale stale bot removed the stale label Oct 16, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@uilianries uilianries self-assigned this Nov 6, 2023
@valgur valgur mentioned this pull request Nov 8, 2023
Closed
uilianries
uilianries reviewed Mar 11, 2024
View reviewed changes
recipes/wineditline/all/CMakeLists.txt

project(WinEditLineWrapper C)
add_library(edit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upstream uses different names. Why not keeping the upstream cmake instead?

https://sourceforge.net/p/mingweditline/code/HEAD/tree/mingweditline/trunk/src/CMakeLists.txt

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @valgur

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't remember at all anymore why I ignored the project CMakeLists.txt. I'll look into it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @valgur, thanks for your contributions, any update on this?

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 23, 2024
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label May 26, 2024
@valgur valgur closed this May 26, 2024
@valgur valgur reopened this May 26, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (b9de317242cd7d7c8331079076d4873fb50f82f7):

  • wineditline/2.206:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 2 (b9de317242cd7d7c8331079076d4873fb50f82f7):

  • wineditline/2.206:
    All packages built successfully! (All logs)

@perseoGI perseoGI self-requested a review June 7, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uilianries uilianries uilianries left review comments

@RubenRBS RubenRBS Awaiting requested review from RubenRBS

@danimtb danimtb Awaiting requested review from danimtb

@perseoGI perseoGI Awaiting requested review from perseoGI

At least 2 approving reviews are required to merge this pull request.

Assignees

@uilianries uilianries

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@valgur @conan-center-bot @uilianries @danimtb @perseoGI