Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libelfin: migrate to Conan v2 #18681

Merged
merged 9 commits into from
Dec 18, 2023
Merged

libelfin: migrate to Conan v2 #18681

merged 9 commits into from
Dec 18, 2023

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 19, 2023 •
edited

TODO

  • v1: incorrect test file path

    terminate called after throwing an instance of 'std::system_error'
    what(): finding file length: Bad file descriptor

@prince-chrismc prince-chrismc mentioned this pull request Jul 19, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 5214245
libelfin/0.3 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdwarf++.so' links to system library 'm' but it is not in cpp_info.system_libs.

@valgur valgur mentioned this pull request Jul 19, 2023
Merged
2 tasks
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 5214245
libelfin/0.3 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdwarf++.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libelf++.so' links to system library 'm' but it is not in cpp_info.system_libs.

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

Hooks produced the following warnings for commit da00de2
libelfin/0.3 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libelf++.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdwarf++.so' links to system library 'm' but it is not in cpp_info.system_libs.

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur valgur mentioned this pull request Nov 8, 2023
Closed
@valgur
Copy link
Contributor Author

valgur commented Dec 13, 2023

@franramirez688 Friendly ping, just in case. The build succeeded a while ago already.

@franramirez688 franramirez688 self-assigned this Dec 13, 2023
franramirez688
franramirez688 reviewed Dec 13, 2023
View reviewed changes
Copy link
Contributor

@franramirez688 franramirez688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great. Only one minor comment @valgur

recipes/libelfin/all/conanfile.py Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 10 (36a4b8abe18df6775157542466575cf0503f6070):

  • libelfin/0.3:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 10 (36a4b8abe18df6775157542466575cf0503f6070):

  • libelfin/0.3:
    All packages built successfully! (All logs)

@github-actions GitHub Actions
Copy link
Contributor

Hooks produced the following warnings for commit 36a4b8a
libelfin/0.3@#315564a24c534bf6f90b593a276ec06d 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdwarf++.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libelf++.so' links to system library 'm' but it is not in cpp_info.system_libs.

@conan-center-bot conan-center-bot merged commit 5ff3625 into conan-io:master Dec 18, 2023
13 checks passed
valgur added a commit to valgur/conan-center-index that referenced this pull request Jan 1, 2024
@valgur @franramirez688
(conan-io#18681) libelfin: migrate to Conan v2
0c3c53e 
* libelfin: migrate to Conan v2

* libelfin: restore VirtualRunEnv in test_package

* libelfin: fix v1 build

* libelfin: fix patched sources not being used

* libelfin: add legacy pkg_config names

---------

Co-authored-by: Francisco Ramírez <franchuti688@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franramirez688 franramirez688 franramirez688 approved these changes

@czoido czoido czoido approved these changes

@jwillikers jwillikers jwillikers approved these changes

Assignees

@franramirez688 franramirez688

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@valgur @conan-center-bot @franramirez688 @czoido @jwillikers