sleef: migrate to Conan v2 #18721
sleef: migrate to Conan v2 #18721
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 13175fasleef/3.5.1 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Closing temporarily to avoid unnecessary load on the CI. Will reopen when I'm actively working on the PR again. |
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 8923ed8sleef/3.5.1 |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
recipes/sleef/all/conandata.yml
Outdated
| @@ -1,4 +1,7 @@ | |||
| sources: | |||
| "cci.20210405": | |||
There was a problem hiding this comment.
Could please update the version 3.6 instead: https://github.com/shibatch/sleef/releases/tag/3.6
recipes/sleef/all/conanfile.py
Outdated
| # Fails with "No rule to make target `/bin/mkrename'" | ||
| # https://github.com/shibatch/sleef/issues/308 | ||
| raise ConanInvalidConfiguration(f"{self.ref} does not support cross-building with apple-clang") | ||
| if self.settings.arch == "armv8": |
There was a problem hiding this comment.
The version 3.6 supports Mac M1. Tested locally and I can build both static and shared 👍
| "shared sleef not supported on Windows, it produces runtime errors" | ||
| ) | ||
| if self.settings.compiler == "apple-clang": | ||
| if cross_building(self): |
There was a problem hiding this comment.
Confirmed that it does not work in 3.6 too.
|
|
||
| def generate(self): | ||
| tc = CMakeToolchain(self) | ||
| tc.cache_variables["BUILD_SHARED_LIBS"] = self.options.shared |
There was a problem hiding this comment.
Some options changed in 3.6, including for testing. Please, check in the new release.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Conan v1 pipeline ✔️All green in build 14 (
Conan v2 pipeline ✔️
All green in build 14 ( |
TODO
Package with 'shared=False' option did not contain any static artifact