Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

djinni-support-lib: migrate to Conan v2, remove deprecated option #18736

Merged
merged 8 commits into from
Nov 29, 2023

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 20, 2023

TODO

  • too many blank lines in YAML
  • #include <memory> missing in 1.x package

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@valgur
Copy link
Contributor Author

valgur commented Jul 26, 2023

Closing temporarily to avoid unnecessary load on the CI. Will reopen when I'm actively working on the PR again.

@conan-center-bot

This comment has been minimized.

@stale
Copy link

stale bot commented Sep 17, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 17, 2023
@conan-center-bot

This comment has been minimized.

@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 9f30014
djinni-support-lib/1.0.0@#14490de5a5c3dbe38e28fde6575f1af3
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdjinni_support_lib.so' links to system library 'm' but it is not in cpp_info.system_libs.

@conan-center-bot

This comment has been minimized.

@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 51bfa74
djinni-support-lib/1.0.0@#6ab2cd7bf465a8f213e1d878d2c0f870
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdjinni_support_lib.so' links to system library 'm' but it is not in cpp_info.system_libs.

@conan-center-bot

This comment has been minimized.

@conan-center-bot conan-center-bot added the Missing dependencies Build failed due missing dependencies in Conan Center label Nov 3, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Nov 5, 2023

Hooks produced the following warnings for commit 8713066
djinni-support-lib/1.1.0@#02b4f2de990501536caf9b346f8db7a7
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdjinni_support_lib.dylib' links to system library 'Foundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdjinni_support_lib.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
djinni-support-lib/1.2.0@#18ee05022811773c9079ffe8d396e0fa
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdjinni_support_lib.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdjinni_support_lib.dylib' links to system library 'Foundation' but it is not in cpp_info.frameworks.
djinni-support-lib/1.0.0@#3b66a27a08396772831da9126e4bffc5
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdjinni_support_lib.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdjinni_support_lib.dylib' links to system library 'Foundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdjinni_support_lib.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
djinni-support-lib/1.2.1@#7e85041b9fb62bb51d86d721ee21f460
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdjinni_support_lib.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdjinni_support_lib.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdjinni_support_lib.dylib' links to system library 'Foundation' but it is not in cpp_info.frameworks.

@conan-center-bot conan-center-bot removed the Missing dependencies Build failed due missing dependencies in Conan Center label Nov 6, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Nov 7, 2023

Hooks produced the following warnings for commit f1cfcbb
djinni-support-lib/0.0.1@#1837bf5a2456f1379960eacfcde058d8
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdjinni_support_lib.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdjinni_support_lib.dylib' links to system library 'Foundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdjinni_support_lib.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 11 (ce0c6352ac325b16954b9a01c27a3896b0c90f61):

  • djinni-support-lib/1.0.0:
    All packages built successfully! (All logs)

  • djinni-support-lib/1.1.0:
    All packages built successfully! (All logs)

  • djinni-support-lib/1.2.0:
    All packages built successfully! (All logs)

  • djinni-support-lib/1.2.1:
    All packages built successfully! (All logs)

  • djinni-support-lib/0.0.1:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 11 (ce0c6352ac325b16954b9a01c27a3896b0c90f61):

  • djinni-support-lib/1.0.0:
    All packages built successfully! (All logs)

  • djinni-support-lib/1.2.0:
    All packages built successfully! (All logs)

  • djinni-support-lib/1.1.0:
    All packages built successfully! (All logs)

  • djinni-support-lib/1.2.1:
    All packages built successfully! (All logs)

  • djinni-support-lib/0.0.1:
    All packages built successfully! (All logs)

Copy link
Contributor

Hooks produced the following warnings for commit ce0c635
djinni-support-lib/0.0.1@#685795e354e18d415d51f4bbd9259062
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdjinni_support_lib.so' links to system library 'm' but it is not in cpp_info.system_libs.

@franramirez688
Copy link
Contributor

@uilianries @valgur Why are we keeping the 0.0.1 version? The whole all folder is meant to keep only that version. IMO, I think we should remove it and change the config.yml to:

versions:
  "1.0.0":
    folder: "all"
  "1.1.0":
    folder: "all"
  "1.2.0":
    folder: "all"
  "1.2.1":
    folder: "all"

@valgur
Copy link
Contributor Author

valgur commented Nov 28, 2023

@franramirez688 Regarding v0.0.1, I did not see any reason to remove it, simple as that. I don't mind dropping it, but I would merge this PR first, so there's a working revision for it available, if anyone really needs it for whatever reason.

@franramirez688
Copy link
Contributor

@franramirez688 Regarding v0.0.1, I did not see any reason to remove it, simple as that. I don't mind dropping it, but I would merge this PR first, so there's a working revision for it available, if anyone really needs it for whatever reason.

Agree 😁

@conan-center-bot conan-center-bot merged commit 5f553ba into conan-io:master Nov 29, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants