qxmpp: migrate to Conan v2 #18743

valgur · 2023-07-20T15:29:12Z

No description provided.

valgur · 2023-07-26T10:20:07Z

Closing temporarily to avoid unnecessary load on the CI. Will reopen when I'm actively working on the PR again.

stale · 2023-09-17T15:39:07Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions · 2023-10-23T20:27:09Z

Hooks produced the following warnings for commit 828a492

qxmpp/1.4.0@#6a014b324991b9f46f86a6d55cc5e8ec

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libqxmpp.1.4.0.dylib' links to system library 'CFNetwork' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libqxmpp.dylib' links to system library 'CFNetwork' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libqxmpp.3.dylib' links to system library 'CFNetwork' but it is not in cpp_info.frameworks.

stale · 2023-12-15T07:06:53Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

conan-center-bot · 2024-03-05T08:34:41Z

Conan v1 pipeline ✔️

All green in build 9 (74ff43e134d9f22d882b3ce6a1b4ed6727b17b9c):

qxmpp/1.4.0:
All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 8 (74ff43e134d9f22d882b3ce6a1b4ed6727b17b9c):

qxmpp/1.4.0:
All packages built successfully! (All logs)

uilianries

Looking good, only some question related to Qt as dependency.

uilianries · 2024-03-08T11:14:32Z

recipes/qxmpp/all/conanfile.py

+from conan.tools.files import apply_conandata_patches, copy, export_conandata_patches, get, mkdir, rename, rmdir
+from conan.tools.scm import Version
+
+required_conan_version = ">=1.56.0 <2 || >=2.0.6"


Suggested change

required_conan_version = ">=1.56.0 <2 || >=2.0.6"

required_conan_version = ">=1.60.0 <2 || >=2.0.6"

https://docs.conan.io/1/changelog.html#id34

uilianries · 2024-03-08T11:32:10Z

recipes/qxmpp/all/conanfile.py

@@ -27,62 +33,90 @@ class QxmppConan(ConanFile):
        "with_gstreamer": False,


Suggested change

"with_gstreamer": False,

"with_gstreamer": False,

"with_qt": 5,

Please, add an option for Qt, the upstream supports both version 5 and 6.

with_qt: [5, 6]

Using version 5 as default will build this package and make it available in Conan Center. Some users may be affect in case using Qt6, but who is using Qt6 right now, needs to build from source, so they probably are using a profile or something prepared.

uilianries · 2024-03-08T11:35:00Z

recipes/qxmpp/all/conanfile.py


    def requirements(self):
-        self.requires("qt/6.2.4")
+        self.requires("qt/6.6.1", transitive_headers=True, transitive_libs=True)


Suggested change

self.requires("qt/6.6.1", transitive_headers=True, transitive_libs=True)

if self.options.with_qt == 5:

self.requires("qt/5.15.12", transitive_headers=True, transitive_libs=True)

else:

self.requires("qt/6.6.1", transitive_headers=True, transitive_libs=True)

uilianries · 2024-03-08T11:39:31Z

recipes/qxmpp/all/conanfile.py

+            )
+
+    def build_requirements(self):
+        self.tool_requires("qt/<host_version>")


Could you please explain is Qt needed as a build requirement? Please, in case needing it, show a log or link indicating it.

github-actions · 2024-05-28T06:36:53Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

conan-center-bot added the Failed label Jul 20, 2023