Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

srt: migrate to Conan v2 #18795

Merged
merged 8 commits into from
Jan 23, 2024
Merged

srt: migrate to Conan v2 #18795

merged 8 commits into from
Jan 23, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 22, 2023

No description provided.

@prince-chrismc prince-chrismc mentioned this pull request Jul 22, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 1c60697
srt/1.4.1 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libsrt.so' links to system library 'm' but it is not in cpp_info.system_libs.

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur
Copy link
Contributor Author

valgur commented Jul 26, 2023

Closing temporarily to avoid unnecessary load on the CI. Will reopen when I'm actively working on the PR again.

@valgur valgur closed this Jul 26, 2023
@valgur valgur reopened this Aug 13, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@stale
Copy link

stale bot commented Sep 17, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@valgur valgur closed this Sep 17, 2023
@valgur valgur reopened this Sep 17, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 1c888a5
srt/1.4.3@#9216b27415fd91fccb1ed7558feb3d94 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libsrt.so' links to system library 'm' but it is not in cpp_info.system_libs.

@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Hooks produced the following warnings for commit 64bde3b
srt/1.4.2@#99f2a1714cd1035f917844bc2eae5225 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libsrt.so' links to system library 'm' but it is not in cpp_info.system_libs.

@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur valgur mentioned this pull request Nov 8, 2023
Closed
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 10 (931845f77cc851777007e7e96637242b5b9363c9):

  • srt/1.5.3:
    All packages built successfully! (All logs)

  • srt/1.4.4:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 10 (931845f77cc851777007e7e96637242b5b9363c9):

  • srt/1.5.3:
    All packages built successfully! (All logs)

  • srt/1.4.4:
    All packages built successfully! (All logs)

@github-actions GitHub Actions
Copy link
Contributor

Hooks produced the following warnings for commit 931845f
srt/1.5.3@#6c3e73911e168d2443b91b52fdd97606 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libsrt.so' links to system library 'm' but it is not in cpp_info.system_libs.
srt/1.4.4@#baac167275f6c3cfc5342a2a6b4aeed0 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libsrt.so' links to system library 'm' but it is not in cpp_info.system_libs.

@danimtb danimtb self-assigned this Jan 23, 2024
uilianries
uilianries approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 3bdb9ee into conan-io:master Jan 23, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpaceIm SpaceIm SpaceIm left review comments

@uilianries uilianries uilianries approved these changes

@danimtb danimtb danimtb approved these changes

Assignees

@danimtb danimtb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@valgur @conan-center-bot @uilianries @danimtb @SpaceIm @qchateau