Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libpq] Add support for dynamic builds with Visual Studio #188

Closed
wants to merge 4 commits into from

Conversation

SSE4
Copy link
Contributor

@SSE4 SSE4 commented Oct 9, 2019

  • Fix source file lists to avoid link errors and to behave be as close as possible to the original MSVC projects.
  • Generate more complete pg_config.h.
  • Use .def file to make exported symbols work as expected.
  • Add missing wldap32 library link in package_info().
  • Enable dynamc build in conanfile.py

Specify library name and version: libpq/11.5

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

Original related bug report: bincrafters/conan-libpq#25
Original PR: #143

* Fix source file lists to avoid link errors and to behave be as close as possible to the original MSVC projects.
* Generate more complete pg_config.h.
* Use .def file to make exported symbols work as expected.
* Add missing wldap32 library link in package_info().
* Enable dynamc build in conanfile.py
@SSE4
Copy link
Contributor Author

SSE4 commented Oct 9, 2019

@Talkless FYI I am going to implement an official way to build project for Visual Studio:
https://www.postgresql.org/docs/8.3/install-win32-libpq.html
https://github.com/postgres/postgres/blob/master/src/tools/msvc/README

@Talkless
Copy link
Contributor

Talkless commented Oct 9, 2019

@Talkless FYI I am going to implement an official way to build project for Visual Studio:

That would be best of course, good luck!

@Talkless
Copy link
Contributor

Talkless commented Oct 10, 2019

@SSE4 I believe PostgreSQL requires ActivePerl, while Conan has Strawberry Perl only? And for ActivePerl you need to register to download.. so I kinda doubt we can package that..?

@SSE4
Copy link
Contributor Author

SSE4 commented Oct 10, 2019

@Talkless I'll check it and let you know

@SSE4 SSE4 changed the title Add support for dynamic builds with Visual Studio [libpq] Add support for dynamic builds with Visual Studio Oct 10, 2019
@conan-center-bot
Copy link
Collaborator

Some configurations of 'libpq/11.5' have failed:

  • Linux x86_64, Release, gcc 5, libstdc++ . Options: libpq:shared-True
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [META LINES (KB-H025)] PEP 263 (encoding) is not allowed in the conanfile. Remove the line 1 (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H025)
      • [HOOK - conan-center.py] pre_export(): ERROR: [TEST PACKAGE - RUN ENVIRONMENT (KB-H029)] The 'RunEnvironment()' build helper is no longer needed. It has been integrated into the self.run(..., run_environment=True) (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H029)
    • Log download
    • Log error Download
    • Profile
  • Access to all the logs

Signed-off-by: SSE4 <tomskside@gmail.com>
@SSE4
Copy link
Contributor Author

SSE4 commented Oct 10, 2019

@Talkless I've checked locally, and it builds fine with StrawberryPerl

@conan-center-bot
Copy link
Collaborator

Some configurations of 'libpq/11.5' have failed:

  • Linux x86_64, Release, gcc 5, libstdc++ . Options: libpq:shared-True
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [META LINES (KB-H025)] PEP 263 (encoding) is not allowed in the conanfile. Remove the line 1 (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H025)
      • [HOOK - conan-center.py] pre_export(): ERROR: [TEST PACKAGE - RUN ENVIRONMENT (KB-H029)] The 'RunEnvironment()' build helper is no longer needed. It has been integrated into the self.run(..., run_environment=True) (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H029)
    • Log download
    • Log error Download
    • Profile
  • Access to all the logs

@conan-center-bot
Copy link
Collaborator

Some configurations of 'libpq/11.5' have failed:

@SSE4
Copy link
Contributor Author

SSE4 commented Oct 10, 2019

@lasote is it possible some slave(s) use older (cached) version of packages?
e.g. strawberry perl still misses pc files:

Can't locate Win32API/File/cFile.pc in @INC (@INC contains: C:\J\c3ipr\pr_188_3_0_2\.conan\data\libpq\11.5\_\_\build\3a39ecdadc1d316422be7204374ad529b5fd8b77\source_subfolder\src\tools\msvc C:/J/c3ipr/pr_188_3_0_2/.short/574618/1/lib) at C:/J/c3ipr/pr_188_3_0_2/.short/574618/1/lib/Win32API/File.pm line 177.

but it was fixed at #189 (and works locally)

@SSE4 SSE4 closed this Oct 23, 2019
@SSE4 SSE4 reopened this Oct 23, 2019
@SSE4 SSE4 closed this Oct 23, 2019
@SSE4 SSE4 reopened this Oct 23, 2019
Signed-off-by: SSE4 <tomskside@gmail.com>
@lasote lasote marked this pull request as ready for review October 24, 2019 09:55
@lasote lasote closed this Oct 24, 2019
@lasote lasote reopened this Oct 24, 2019
Signed-off-by: SSE4 <tomskside@gmail.com>
@SSE4 SSE4 closed this Oct 24, 2019
@Talkless
Copy link
Contributor

What's up with all these closes-reopnes? :)

@SSE4
Copy link
Contributor Author

SSE4 commented Oct 25, 2019

@Talkless CI didn't relaunch build, and nothing helped (tried new commit, force push, open/close PR, open new PR, etc.). the only thing helped - creating another branch. there is an issue on CI side, but don't worry, there is new PR: #231

artem-kamyshev pushed a commit to artem-kamyshev/conan-center-index that referenced this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants