Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gf-complete: migrate to Conan v2 #18854

Merged
merged 8 commits into from
Jan 17, 2024
Merged

gf-complete: migrate to Conan v2 #18854

merged 8 commits into from
Jan 17, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 23, 2023

No description provided.

@prince-chrismc prince-chrismc mentioned this pull request Jul 23, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 03c9ebb
gf-complete/1.03 
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libgf_complete.1.dylib, libgf_complete.dylib

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur
Copy link
Contributor Author

valgur commented Jul 26, 2023

Closing temporarily to avoid unnecessary load on the CI. Will reopen when I'm actively working on the PR again.

@valgur valgur closed this Jul 26, 2023
@valgur valgur reopened this Aug 16, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit c7e6a99
gf-complete/1.03 
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libgf_complete.1.dylib, libgf_complete.dylib

@stale
Copy link

stale bot commented Sep 17, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 17, 2023
@conan-center-bot conan-center-bot added Missing dependencies Build failed due missing dependencies in Conan Center and removed stale labels Oct 16, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur
Copy link
Contributor Author

valgur commented Oct 16, 2023

@uilianries @RubenRBS ERROR: Missing prebuilt package for 'm4/1.4.19'

@RubenRBS
Copy link
Member

Once the current build in the main branch completes, we can restart this one, no need to rebuild anything now

@RubenRBS RubenRBS self-assigned this Oct 16, 2023
RubenRBS
RubenRBS reviewed Oct 16, 2023
View reviewed changes
Copy link
Member

@RubenRBS RubenRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One question about the autotoolsdeps workaround, else looks good :)

recipes/gf-complete/all/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot conan-center-bot removed the Missing dependencies Build failed due missing dependencies in Conan Center label Oct 17, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2023

Hooks produced the following warnings for commit 842a7b9
gf-complete/1.03@#fc51316f0a11f80f390cdd4aa49db0a0 
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libgf_complete.1.dylib, libgf_complete.dylib

@valgur valgur mentioned this pull request Nov 8, 2023
Closed
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

Hooks produced the following warnings for commit cecf172
gf-complete/1.03@#e86c29bb83e362ba142765a8e1461428 
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libgf_complete.1.dylib, libgf_complete.dylib

@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

Hooks produced the following warnings for commit 0b95687
gf-complete/cci.20170410@#232c253a606531901862c914bb1a9a5e 
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libgf_complete.1.dylib, libgf_complete.dylib
gf-complete/1.03@#195aa9074976b936ec0c8e5f6fb0f32f 
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libgf_complete.1.dylib, libgf_complete.dylib

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 13 (7a39132268b9258a194d571e4bfbfd59ffd37784):

  • gf-complete/1.03:
    All packages built successfully! (All logs)

  • gf-complete/cci.20170410:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 14 (7a39132268b9258a194d571e4bfbfd59ffd37784):

  • gf-complete/cci.20170410:
    All packages built successfully! (All logs)

  • gf-complete/1.03:
    All packages built successfully! (All logs)

RubenRBS
RubenRBS reviewed Jan 15, 2024
View reviewed changes
Copy link
Member

@RubenRBS RubenRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question about the new msvc shared build code, otherwise looks great, thanks a lot for your patience @valgur

recipes/gf-complete/all/conanfile.py Show resolved Hide resolved
uilianries
uilianries reviewed Jan 16, 2024
View reviewed changes
recipes/gf-complete/all/conanfile.py

def package_info(self):
self.cpp_info.libs = ["gf_complete"]
self.cpp_info.libs = collect_libs(self)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, avoid collect_libs. It's hard to predict what's expected, plus, it does not respect link order.

@conan-center-bot conan-center-bot merged commit fbe9143 into conan-io:master Jan 17, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uilianries uilianries uilianries left review comments

@RubenRBS RubenRBS RubenRBS approved these changes

@jwillikers jwillikers jwillikers approved these changes

Assignees

@RubenRBS RubenRBS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@valgur @conan-center-bot @RubenRBS @uilianries @jwillikers