Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

verilator: migrate to Conan v2 #18897

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

verilator: migrate to Conan v2 #18897

wants to merge 11 commits into from
+247 −529

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 25, 2023

No description provided.

@prince-chrismc prince-chrismc mentioned this pull request Jul 25, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur
Copy link
Contributor Author

valgur commented Jul 26, 2023

Closing temporarily to avoid unnecessary load on the CI. Will reopen when I'm actively working on the PR again.

@valgur valgur closed this Jul 26, 2023
@valgur valgur reopened this Aug 16, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@stale
Copy link

stale bot commented Oct 15, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 15, 2023
@valgur valgur force-pushed the migrate/verilator branch 2 times, most recently from ea14953 to 85b74ea Compare October 28, 2023 08:17
@stale stale bot removed the stale label Oct 28, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur valgur mentioned this pull request Nov 8, 2023
Closed
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 14 (b2e8c2d21c405e23be4d577701bf3c09800b8b8c):

  • verilator/5.004:
    All packages built successfully! (All logs)

  • verilator/4.200:
    All packages built successfully! (All logs)

  • verilator/4.224:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 14 (b2e8c2d21c405e23be4d577701bf3c09800b8b8c):

  • verilator/5.004:
    All packages built successfully! (All logs)

  • verilator/4.200:
    All packages built successfully! (All logs)

  • verilator/4.224:
    All packages built successfully! (All logs)

@uilianries uilianries self-assigned this Nov 29, 2023
uilianries
uilianries reviewed Mar 20, 2024
View reviewed changes
recipes/verilator/all/conanfile.py
if self.settings.os == "Windows":
self.requires("winflexbison/2.5.25", visible=False)
else:
self.requires("flex/2.6.4", visible=False)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is flex need now, but not before? Using ldd on linux I don't see linkage. Please, update the PR description with the changes related to this PR, it really hard to track and review without any information.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My memory is very fuzzy, it's been almost half a year, sorry. I think it was due to flex being a run-time requirement and getting Conan v1 and v2 to propagate it correctly in the graph were a major pain. I really don't want to touch this part of the recipe again, if possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uilianries uilianries uilianries left review comments

@RubenRBS RubenRBS Awaiting requested review from RubenRBS

@jcar87 jcar87 Awaiting requested review from jcar87

At least 2 approving reviews are required to merge this pull request.

Assignees

@uilianries uilianries

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@valgur @conan-center-bot @uilianries