Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ofeli: migrate to Conan v2, add v5.1.0 #18952

Merged
merged 10 commits into from
Mar 12, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 28, 2023

No description provided.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@valgur valgur changed the title ofeli: migrate to Conan v2 ofeli: migrate to Conan v2, add v5.1.0 Aug 31, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@stale
Copy link

stale bot commented Oct 15, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@uilianries uilianries self-assigned this Nov 6, 2023
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, check 5.x compatibility. I didn't find those limitations documented. Or they are improved now, or at least, it should be clarified better.

homepage = "http://ofeli.org/index.html"
topics = ("finite-element", "finite-element-library", "finite-element-analysis", "finite-element-solver")

package_type = "static-library"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not find a reference offering only static library: https://github.com/rtouzani/ofeli/blob/master/src/CMakeLists.txt

Please, point where you found it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A shared build fails with:

ofelia3f8f09b1f9b5/p/lib/libofeli.so: undefined reference to `OFELI::LocalVect<unsigned long, 3ul>::~LocalVect()'
ofelia3f8f09b1f9b5/p/lib/libofeli.so: undefined reference to `OFELI::LocalVect<unsigned long, 2ul>::~LocalVect()'
ofelia3f8f09b1f9b5/p/lib/libofeli.so: undefined reference to `OFELI::Muscl::setReconstruction(OFELI::Vect<double> const&, OFELI::Vect<double>&, OFELI::Vect<double>&, unsigned long)'
ofelia3f8f09b1f9b5/p/lib/libofeli.so: undefined reference to `virtual thunk to OFELI::LaplaceDG2DP1::build()'
ofelia3f8f09b1f9b5/p/lib/libofeli.so: undefined reference to `OFELI::LocalVect<double, 2ul>::get()'
ofelia3f8f09b1f9b5/p/lib/libofeli.so: undefined reference to `OFELI::LocalVect<double, 3ul>::LocalVect()'
ofelia3f8f09b1f9b5/p/lib/libofeli.so: undefined reference to `OFELI::LocalVect<unsigned long, 3ul>::LocalVect()'
ofelia3f8f09b1f9b5/p/lib/libofeli.so: undefined reference to `OFELI::LocalVect<unsigned long, 2ul>::LocalVect()'
ofelia3f8f09b1f9b5/p/lib/libofeli.so: undefined reference to `OFELI::LocalVect<double, 3ul>::operator()(unsigned long)'
ofelia3f8f09b1f9b5/p/lib/libofeli.so: undefined reference to `OFELI::LocalVect<double, 2ul>::operator=(double const&)'
ofelia3f8f09b1f9b5/p/lib/libofeli.so: undefined reference to `OFELI::LocalVect<double, 3ul>::get()'
ofelia3f8f09b1f9b5/p/lib/libofeli.so: undefined reference to `OFELI::LocalVect<double, 3ul>::~LocalVect()'
ofelia3f8f09b1f9b5/p/lib/libofeli.so: undefined reference to `OFELI::LaplaceDG2DP1::build()'
ofelia3f8f09b1f9b5/p/lib/libofeli.so: undefined reference to `OFELI::LocalVect<double, 1ul>::get()'
ofelia3f8f09b1f9b5/p/lib/libofeli.so: undefined reference to `OFELI::LocalVect<double, 2ul>::operator()(unsigned long)'
ofelia3f8f09b1f9b5/p/lib/libofeli.so: undefined reference to `OFELI::LocalVect<double, 3ul>::operator=(double const&)'

on GCC.

cmake_layout(self, src_folder="src")

def validate(self):
if self.settings.os not in ["Linux", "FreeBSD"]:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README indicates Windows support too: https://github.com/rtouzani/ofeli/blob/master/README.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember the details why I disabled it anymore. Will give it another shot.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#18952 (comment)
Too many compilation errors on MSVC to count.

recipes/ofeli/5.x/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 14 (4344a2d4bb4e28ee7f4b37e39c66dbd2832ecb4d):

  • ofeli/4.1.2:
    All packages built successfully! (All logs)

  • ofeli/5.1.0:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 14 (4344a2d4bb4e28ee7f4b37e39c66dbd2832ecb4d):

  • ofeli/4.1.2:
    All packages built successfully! (All logs)

  • ofeli/5.1.0:
    All packages built successfully! (All logs)

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit e1e3d15 into conan-io:master Mar 12, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants