-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pciutils: migrate to Conan v2 #18959
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This comment has been minimized.
This comment has been minimized.
329e4f4
to
62c5112
Compare
This comment has been minimized.
This comment has been minimized.
Same here @valgur, any way we can help? (Also, update the zlib requires if you modify the recipe too, thanks!) |
f6f28ce
to
d036731
Compare
This comment has been minimized.
This comment has been minimized.
Generated and committed by [Conan Center Bot](https://github.com/qchateau/conan-center-bot) Find more updatable recipes in the [GitHub Pages](https://qchateau.github.io/conan-center-bot/)
a76c784
to
ca60ea4
Compare
This comment has been minimized.
This comment has been minimized.
@uilianries Maybe you can look into what is going on in the CI for this recipe? The build step logs are missing despite the test step being run. FROM conanio/gcc11-ubuntu16.04
USER root
COPY <<EOF /root/.conan2/profiles/default
[settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.cppstd=17
compiler.libcxx=libstdc++11
compiler.version=11
os=Linux
[options]
*/*:shared=True
EOF
ADD . .
ARG version=3.10.0
RUN conan create . -c tools.system.package_manager:mode=install -c tools.system.package_manager:sudo=true --version $version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just few adjusts needed.
Based on the boost recipe.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks a lot, I have some initial comments
dst=os.path.join(self.package_folder, "lib", "libpci.so")) | ||
# libpci.so.3 -> libpci.so | ||
with chdir(self, os.path.join(self.package_folder, "lib")): | ||
os.symlink("libpci.so.3", "libpci.so") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any specific reason for this to be a symlink?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The project does not create one and test_package fails without it.
Conan v1 pipeline ✔️All green in build 11 (
Conan v2 pipeline ✔️
All green in build 11 ( |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@RubenRBS, @uilianries Pinging for another round of review. |
Set
with_udev
to True since the feature is now available.