Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pciutils: migrate to Conan v2 #18959

Merged
merged 9 commits into from
Mar 12, 2024
Merged

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 28, 2023

Set with_udev to True since the feature is now available.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@stale
Copy link

stale bot commented Sep 17, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 17, 2023
@valgur valgur closed this Sep 17, 2023
@valgur valgur reopened this Sep 17, 2023
@stale stale bot removed the stale label Sep 17, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@RubenRBS
Copy link
Member

Same here @valgur, any way we can help? (Also, update the zlib requires if you modify the recipe too, thanks!)

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@valgur
Copy link
Contributor Author

valgur commented Nov 5, 2023

@uilianries Maybe you can look into what is going on in the CI for this recipe? The build step logs are missing despite the test step being run.
Can't reproduce it locally either:

FROM conanio/gcc11-ubuntu16.04

USER root

COPY <<EOF /root/.conan2/profiles/default
[settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.cppstd=17
compiler.libcxx=libstdc++11
compiler.version=11
os=Linux
[options]
*/*:shared=True
EOF

ADD . .

ARG version=3.10.0
RUN conan create . -c tools.system.package_manager:mode=install -c tools.system.package_manager:sudo=true --version $version

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just few adjusts needed.

recipes/pciutils/all/conanfile.py Outdated Show resolved Hide resolved
recipes/pciutils/all/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

Copy link
Member

@RubenRBS RubenRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks a lot, I have some initial comments

recipes/pciutils/all/conanfile.py Outdated Show resolved Hide resolved
dst=os.path.join(self.package_folder, "lib", "libpci.so"))
# libpci.so.3 -> libpci.so
with chdir(self, os.path.join(self.package_folder, "lib")):
os.symlink("libpci.so.3", "libpci.so")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any specific reason for this to be a symlink?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project does not create one and test_package fails without it.

recipes/pciutils/all/conanfile.py Outdated Show resolved Hide resolved
@valgur valgur requested a review from RubenRBS November 14, 2023 17:12
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 11 (c99a7e3ffdf639e9fa3007777520131e7a6ecaf8):

  • pciutils/3.7.0:
    All packages built successfully! (All logs)

  • pciutils/3.10.0:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 11 (c99a7e3ffdf639e9fa3007777520131e7a6ecaf8):

  • pciutils/3.10.0:
    All packages built successfully! (All logs)

  • pciutils/3.7.0:
    All packages built successfully! (All logs)

Copy link

stale bot commented Dec 15, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@valgur
Copy link
Contributor Author

valgur commented Dec 15, 2023

@RubenRBS, @uilianries Pinging for another round of review.

@conan-center-bot conan-center-bot merged commit 7e0ff2a into conan-io:master Mar 12, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants