libid3tag: migrate to Conan v2 #18987

valgur · 2023-07-31T14:21:52Z

TODO:

Merge [conan-center] Forbid linking against removed glibc finite math functions hooks#508 hook first as this package is affected by the glibc issue.
Add -fno-finite-math-only.

github-actions · 2023-08-07T16:46:43Z

Hooks produced the following warnings for commit 111b2fe

libid3tag/0.15.1b

post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libid3tag.0.3.0.dylib, libid3tag.0.dylib, libid3tag.dylib

ghost · 2023-10-24T19:21:47Z

I detected other pull requests that are modifying libid3tag/all recipe:

Bump libid3tag's zlib requirement to [>=1.2.11 <2] range (v1 only) #20661

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

RubenRBS · 2023-10-27T11:20:23Z

Restarted, this PR was also affected by the grpc outtage

recipes/libid3tag/all/conanfile.py

github-actions · 2023-12-03T23:37:14Z

Hooks produced the following warnings for commit 2fd4dd0

libid3tag/0.15.1b@#2d7856afb421fb59157a49585b9c658f

post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libid3tag.0.3.0.dylib, libid3tag.0.dylib, libid3tag.dylib

uilianries · 2023-12-05T08:32:44Z

recipes/libid3tag/all/CMakeLists.txt

Reading the previous recipe, I see it used the MSBuild in Windows. Did you try the new https://docs.conan.io/2/reference/tools/microsoft/msbuild.html ?

I did, but the real issue here was

self.run("devenv /Upgrade libid3tag.dsp")

The project ships only with an archaic .dsp file instead of .vcproj or .vcxproj and VS 2023 no longer supports the automatic upgrade from .dsp to .vcxproj like the previous versions do.

uilianries · 2023-12-07T12:56:48Z

recipes/libid3tag/all/conanfile.py

+        if self.settings.arch == "armv8" and self.options.shared:
+            raise ConanInvalidConfiguration("shared library build is not supported for armv8")


Suggested change

if self.settings.arch == "armv8" and self.options.shared:

raise ConanInvalidConfiguration("shared library build is not supported for armv8")

I suggest trying it again. I can build it in Mac M1 locally, but probably you had problems when cross-building from Mac Intel to Mac M1. However, we added Mac M1 to the build matrix, so it should work now.

github-actions · 2023-12-12T15:39:39Z

Hooks produced the following warnings for commit 91310bc

libid3tag/0.15.1b@#fab44d430950a5d00f32d9eb8fcdeb26

post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libid3tag.0.3.0.dylib, libid3tag.0.dylib, libid3tag.dylib

recipes/libid3tag/all/conanfile.py

Co-authored-by: Uilian Ries <uilianries@gmail.com>

conan-center-bot · 2023-12-12T20:22:33Z

Conan v1 pipeline ✔️

All green in build 15 (bd9af616795205ffe770f5987f914885e8f88c72):

libid3tag/0.15.1b:
All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 14 (bd9af616795205ffe770f5987f914885e8f88c72):

libid3tag/0.15.1b:
All packages built successfully! (All logs)

github-actions · 2023-12-12T20:22:54Z

Hooks produced the following warnings for commit bd9af61

libid3tag/0.15.1b@#2363073a63c51d84dd31aa8dd8395f2d

post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libid3tag.0.3.0.dylib, libid3tag.0.dylib, libid3tag.dylib

* libid3tag: migrate to Conan v2 * libid3tag: use AutotoolsDeps * libid3tag: disable shared build on armv8 * libid3tag: zlib/[>=1.2.11 <2] * libid3tag: replace legacy VS project with CMakeLists.txt * libid3tag: fix autotools package() * libid3tag: make the armv8 check specific to cross-building * Update recipes/libid3tag/all/conanfile.py Co-authored-by: Uilian Ries <uilianries@gmail.com> * libid3tag: add missing import --------- Co-authored-by: Uilian Ries <uilianries@gmail.com>

SpaceIm · 2024-01-21T17:59:36Z

recipes/libid3tag/all/conanfile.py

-            if self._settings_build.os == "Windows" and not tools.get_env("CONAN_BASH_PATH"):
-                self.build_requires("msys2/cci.latest")


This logic must not be removed because autotools require a shell, and msvc is not the only compiler on Windows, so you can go into autotools branch.

conan-center-bot added the Service Under Maintenance label Jul 31, 2023

This comment has been minimized.

Sign in to view

prince-chrismc mentioned this pull request Jul 31, 2023

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

conan-center-bot added Failed and removed Service Under Maintenance labels Aug 5, 2023

This comment has been minimized.

Sign in to view

Nekto89 mentioned this pull request Sep 9, 2023

audiowaveform: add initial recipe for 1.8.1 #19695

Draft

3 tasks

This was referenced Oct 18, 2023

[service] Potentially conflicting recipes #3571

Closed

Bump libid3tag's zlib requirement to [>=1.2.11 <2] range (v1 only) #20661

Closed

valgur force-pushed the migrate/libid3tag branch from 57dcc68 to ca89866 Compare October 24, 2023 19:17

RubenRBS reviewed Oct 27, 2023

View reviewed changes

recipes/libid3tag/all/conanfile.py Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

valgur added 4 commits November 1, 2023 15:24

libid3tag: migrate to Conan v2

a89b52b

libid3tag: use AutotoolsDeps

bbbc2a9

libid3tag: disable shared build on armv8

69c2cca

libid3tag: zlib/[>=1.2.11 <2]

3945df2

valgur force-pushed the migrate/libid3tag branch from f8c2c7c to 3945df2 Compare November 1, 2023 13:36

This comment has been minimized.

Sign in to view

valgur mentioned this pull request Nov 8, 2023

Conan 2.0 migration: the final 100 #20992

Closed

valgur added 2 commits November 16, 2023 22:53

libid3tag: replace legacy VS project with CMakeLists.txt

d5288b6

Merge branch 'master' into migrate/libid3tag

4479738

This comment has been minimized.

Sign in to view

libid3tag: fix autotools package()

2fd4dd0

conan-center-bot removed the Failed label Dec 3, 2023

This comment has been minimized.

Sign in to view

uilianries reviewed Dec 5, 2023

View reviewed changes

uilianries reviewed Dec 7, 2023

View reviewed changes

libid3tag: make the armv8 check specific to cross-building

bfc64f4

uilianries added the Unexpected Error label Dec 11, 2023

Merge branch 'master' into migrate/libid3tag

91310bc

conan-center-bot removed the Unexpected Error label Dec 12, 2023

This comment has been minimized.

Sign in to view

uilianries reviewed Dec 12, 2023

View reviewed changes

recipes/libid3tag/all/conanfile.py Outdated Show resolved Hide resolved

Update recipes/libid3tag/all/conanfile.py

0899339

Co-authored-by: Uilian Ries <uilianries@gmail.com>

conan-center-bot added the Failed label Dec 12, 2023

This comment has been minimized.

Sign in to view

libid3tag: add missing import

bd9af61

conan-center-bot removed the Failed label Dec 12, 2023

uilianries approved these changes Dec 18, 2023

View reviewed changes

uilianries self-assigned this Dec 18, 2023

toge approved these changes Dec 26, 2023

View reviewed changes

conan-center-bot merged commit 323292d into conan-io:master Dec 26, 2023
13 checks passed

SpaceIm reviewed Jan 21, 2024

View reviewed changes

SpaceIm mentioned this pull request Jan 21, 2024

libid3tag: restore mingw support + relocatable shared lib on macOS #22478

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

libid3tag: migrate to Conan v2 #18987

libid3tag: migrate to Conan v2 #18987

valgur commented Jul 31, 2023 •

edited

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Aug 7, 2023

ghost commented Oct 24, 2023

RubenRBS commented Oct 27, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Dec 3, 2023

uilianries Dec 5, 2023

valgur Dec 5, 2023

uilianries Dec 7, 2023

This comment has been minimized.

github-actions bot commented Dec 12, 2023

This comment has been minimized.

conan-center-bot commented Dec 12, 2023

github-actions bot commented Dec 12, 2023

SpaceIm Jan 21, 2024 •

edited

		if self.settings.arch == "armv8" and self.options.shared:
		raise ConanInvalidConfiguration("shared library build is not supported for armv8")

		if self._settings_build.os == "Windows" and not tools.get_env("CONAN_BASH_PATH"):
		self.build_requires("msys2/cci.latest")

libid3tag: migrate to Conan v2 #18987

libid3tag: migrate to Conan v2 #18987

Conversation

valgur commented Jul 31, 2023 • edited

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Aug 7, 2023

ghost commented Oct 24, 2023

RubenRBS commented Oct 27, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Dec 3, 2023

uilianries Dec 5, 2023

Choose a reason for hiding this comment

valgur Dec 5, 2023

Choose a reason for hiding this comment

uilianries Dec 7, 2023

Choose a reason for hiding this comment

This comment has been minimized.

github-actions bot commented Dec 12, 2023

This comment has been minimized.

conan-center-bot commented Dec 12, 2023

Conan v1 pipeline ✔️

Conan v2 pipeline ✔️

github-actions bot commented Dec 12, 2023

SpaceIm Jan 21, 2024 • edited

Choose a reason for hiding this comment

valgur commented Jul 31, 2023 •

edited

SpaceIm Jan 21, 2024 •

edited