Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignition-tools: migrate to Conan v2 #19074

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Aug 6, 2023

Also unvendors backward-cpp and removes includedirs, which the package does not actually export since the built shared library is only meant to be used from a Ruby script.

@conan-center-bot

This comment has been minimized.

@stale
Copy link

stale bot commented Oct 15, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 15, 2023
@stale stale bot removed the stale label Nov 27, 2023
@conan-center-bot conan-center-bot added Unexpected Error Failed Missing dependencies Build failed due missing dependencies in Conan Center labels Nov 27, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@valgur valgur mentioned this pull request Dec 6, 2023
@conan-center-bot conan-center-bot removed Failed Missing dependencies Build failed due missing dependencies in Conan Center labels Dec 12, 2023
@conan-center-bot

This comment has been minimized.

Copy link
Member

@RubenRBS RubenRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have a concern about the super simplicity of the test package code, it should do at least something!


int main(int argc, char **argv)
{
int main() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this test package be at least a bit more complicated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh... I looked into what this package actually should provide and this recipe is quite incorrect.

The built library is meant to be a pure runtime library for the ign Ruby script packaged by this recipe. CMake and pkg-config targets should not be exported by the recipe, since they are effectively empty. Here's the .pc file installed by the project:

# This packages provides no headers or libraries, so those fields are omitted
Name: Ignition tools
Description: A set of tools classes for robot applications
Version: 1.4.0

I updated the recipe accordingly.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Failure in build 7 (4a4b0fa8ad2d44c37f6d735a7592f7431dba8a14):

  • ignition-tools/1.4.0:
    CI failed to create some packages (All logs)

    Logs for packageID 87e1b067d3dc713f294fa75d4e740f468ead9f83:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=Visual Studio
    compiler.runtime=MD
    compiler.version=16
    os=Windows
    
    [...]
    Requirements
        backward-cpp/1.6 from 'conan-center' - Cache
        ignition-tools/1.4.0 from local cache - Cache
    Packages
        backward-cpp/1.6:a67bf4ded5fa4d70ea0ad42cedfe0077632eb08a - Cache
        ignition-tools/1.4.0:87e1b067d3dc713f294fa75d4e740f468ead9f83 - Cache
    
    Installing (downloading, building) binaries...
    backward-cpp/1.6: Already installed!
    ignition-tools/1.4.0: Already installed!
    ignition-tools/1.4.0 (test package): Generator cmake created conanbuildinfo.cmake
    ignition-tools/1.4.0 (test package): Generator cmake_find_package_multi created ignition-tools-config-version.cmake
    ignition-tools/1.4.0 (test package): Generator cmake_find_package_multi created ignition-tools-config.cmake
    ignition-tools/1.4.0 (test package): Generator cmake_find_package_multi created ignition-toolsTargets.cmake
    ignition-tools/1.4.0 (test package): Generator cmake_find_package_multi created ignition-toolsTarget-release.cmake
    ignition-tools/1.4.0 (test package): Generator cmake_find_package_multi created BackwardConfigVersion.cmake
    ignition-tools/1.4.0 (test package): Generator cmake_find_package_multi created BackwardConfig.cmake
    ignition-tools/1.4.0 (test package): Generator cmake_find_package_multi created BackwardTargets.cmake
    ignition-tools/1.4.0 (test package): Generator cmake_find_package_multi created BackwardTarget-release.cmake
    ignition-tools/1.4.0 (test package): Generator txt created conanbuildinfo.txt
    ignition-tools/1.4.0 (test package): Aggregating env generators
    ignition-tools/1.4.0 (test package): Generated conaninfo.txt
    ignition-tools/1.4.0 (test package): Generated graphinfo
    Using lockfile: 'C:\J2\w\prod-v1\bsr\cci-cf9d5468\recipes\ignition-tools\all\test_v1_package\build\57c65d34ea3bf29e3312329e199a16791ec0fc2c/conan.lock'
    Using cached profile from lockfile
    [HOOK - conan-center.py] pre_build(): [FPIC MANAGEMENT (KB-H007)] 'fPIC' option not found
    [HOOK - conan-center.py] pre_build(): [FPIC MANAGEMENT (KB-H007)] OK
    ignition-tools/1.4.0 (test package): Calling build()
    ignition-tools/1.4.0 (test package): Running test()
    
    ----Running------
    > where ign
    -----------------
    INFO: Could not find files for the given pattern(s).
    ignition-tools/1.4.0 (test package): WARN: 
         ************************************************
         The 'cmake' generator is deprecated.
         Please update your code and remove it.
         *************************************************
    
    ignition-tools/1.4.0 (test package): WARN: 
         ************************************************
         The 'cmake_find_package_multi' generator is deprecated.
         Please update your code and remove it.
         *************************************************
    
    ignition-tools/1.4.0 (test package): WARN: This conanfile has no build step
    ERROR: ignition-tools/1.4.0 (test package): Error in test() method, line 10
    	self.run("where ign", run_environment=True)
    	ConanException: Error 1 while executing where ign
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

See details:

Failure in build 9 (4a4b0fa8ad2d44c37f6d735a7592f7431dba8a14):

  • ignition-tools/1.4.0:
    CI failed to create some packages (All logs)

    Logs for packageID 238428491544ecab910b7ce4365a7c578e130959:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=msvc
    compiler.cppstd=17
    compiler.runtime=dynamic
    compiler.runtime_type=Release
    compiler.version=193
    os=Windows
    
    [...]
    compiler.runtime=dynamic
    compiler.runtime_type=Release
    compiler.version=193
    os=Windows
    [conf]
    tools.system.package_manager:mode=install
    tools.system.package_manager:sudo=True
    
    
    ======== Launching test_package ========
    
    ======== Computing dependency graph ========
    Graph root
        ignition-tools/1.4.0 (test package): C:\J2\w\prod-v2\bsr@4\cci-920b2edb\recipes\ignition-tools\all\test_package\conanfile.py
    Requirements
        backward-cpp/1.6#b1d9a141d04b54521b46c176541f4848 - Cache
        ignition-tools/1.4.0#8422508c1c408b5d281b591dbec9fd68 - Cache
    
    ======== Computing necessary packages ========
    backward-cpp/1.6: Checking 3 compatible configurations
    backward-cpp/1.6: Main binary package 'a868c3bd89ea1e7bab9522a0f3cd1a9c1a739636' missing. Using compatible package 'ffa4b22b0b87e948bb71e1bffa7a8de1b42db7d0': compiler.cppstd=14
    Requirements
        ignition-tools/1.4.0#8422508c1c408b5d281b591dbec9fd68:238428491544ecab910b7ce4365a7c578e130959#e3893f584bd03a036293b8fc8e43f20e - Cache
    Skipped binaries
        backward-cpp/1.6
    
    ======== Installing packages ========
    ignition-tools/1.4.0: Already installed! (1 of 1)
    WARN: deprecated: Usage of deprecated Conan 1.X features that will be removed in Conan 2.X:
    WARN: deprecated:     'env_info' used in: ignition-tools/1.4.0
    
    ======== Testing the package ========
    Removing previously existing 'test_package' build folder: C:\J2\w\prod-v2\bsr@4\cci-920b2edb\recipes\ignition-tools\all\test_package\build-release
    ignition-tools/1.4.0 (test package): Test package build: build-release
    ignition-tools/1.4.0 (test package): Test package build folder: C:\J2\w\prod-v2\bsr@4\cci-920b2edb\recipes\ignition-tools\all\test_package\build-release
    ignition-tools/1.4.0 (test package): Writing generators to C:\J2\w\prod-v2\bsr@4\cci-920b2edb\recipes\ignition-tools\all\test_package\build-release\conan
    ignition-tools/1.4.0 (test package): Generator 'VirtualRunEnv' calling 'generate()'
    ignition-tools/1.4.0 (test package): Generating aggregated env files
    ignition-tools/1.4.0 (test package): Generated aggregated env files: ['conanrun.bat', 'conanbuild.bat']
    
    ======== Testing the package: Building ========
    
    ======== Testing the package: Executing test ========
    ignition-tools/1.4.0 (test package): Running test()
    ignition-tools/1.4.0 (test package): RUN: where ign
    INFO: Could not find files for the given pattern(s).
    
    ERROR: ignition-tools/1.4.0 (test package): Error in test() method, line 19
    	self.run("where ign", scope="conanrun")
    	ConanException: Error 1 while executing
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants