Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ftjam: migrate to Conan v2 #19238

Merged
merged 5 commits into from
Nov 14, 2023
Merged

ftjam: migrate to Conan v2 #19238

merged 5 commits into from
Nov 14, 2023

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Aug 17, 2023

No description provided.

@valgur valgur mentioned this pull request Aug 17, 2023
Closed
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@prince-chrismc prince-chrismc mentioned this pull request Aug 17, 2023
Open
@stale
Copy link

stale bot commented Sep 17, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 17, 2023
@valgur valgur closed this Sep 17, 2023
@valgur valgur reopened this Sep 17, 2023
@stale stale bot removed the stale label Sep 17, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@RubenRBS RubenRBS self-assigned this Oct 17, 2023
RubenRBS
RubenRBS previously approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@RubenRBS RubenRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks

jwillikers
jwillikers suggested changes Oct 18, 2023
View reviewed changes
recipes/ftjam/all/conanfile.py Outdated Show resolved Hide resolved
recipes/ftjam/all/conanfile.py Show resolved Hide resolved
recipes/ftjam/all/conanfile.py Outdated Show resolved Hide resolved
recipes/ftjam/all/test_package/conanfile.py Outdated Show resolved Hide resolved
recipes/ftjam/all/test_package/conanfile.py Outdated Show resolved Hide resolved
recipes/ftjam/all/test_package/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
RubenRBS
RubenRBS requested changes Oct 26, 2023
View reviewed changes
Copy link
Member

@RubenRBS RubenRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Minor request about the validate() contents

recipes/ftjam/all/conanfile.py Outdated Show resolved Hide resolved
@valgur @RubenRBS
ftjam: move cross-building check to validate_build()
e7e646d 
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 9 (e7e646d05fb50459a6df72acb6d41d790286beec):

  • ftjam/2.5.2:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 6 (e7e646d05fb50459a6df72acb6d41d790286beec):

  • ftjam/2.5.2:
    All packages built successfully! (All logs)

@SSE4
Copy link
Contributor

SSE4 commented Nov 3, 2023

Thanks! Minor request about the validate() contents

@RubenRBS minor request has been corrected already, can you approve?

@valgur valgur mentioned this pull request Nov 8, 2023
Closed
@valgur
Copy link
Contributor Author

valgur commented Nov 14, 2023

@RubenRBS ping

RubenRBS
RubenRBS approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@RubenRBS RubenRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@conan-center-bot conan-center-bot merged commit 6a37da3 into conan-io:master Nov 14, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RubenRBS RubenRBS RubenRBS approved these changes

@jwillikers jwillikers jwillikers approved these changes

Assignees

@RubenRBS RubenRBS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@valgur @conan-center-bot @SSE4 @RubenRBS @jwillikers