Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libvault: fix import of Version + decrease min Visual Studio Version + many small fixes #19488

Merged
merged 19 commits into from
Dec 27, 2023

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Aug 29, 2023

  • fix import of Version (from conan import Version was illegal and breaks in conan 2.0.10)
  • use export_conandata_patches()
  • remove useless VirtualBuildEnv generator (there is no build requirements in this recipe
  • bump libcurl
  • remove useless catch2 in requirements (it's used for tests, but tests are disabled...)
  • add package_type
  • fix min Visual Studio (it was ... 19, which doesn't make sense) and add min version for msvc
  • use self.settings instead of self.info.settings in validate()
  • remove useless CMakeLists wrapper (it had old conan v1 stuff with conan_basic_setup() and was not used at all...)
  • add a layout
  • add libm to system libs on Linux & FreeBSD only

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Aug 29, 2023

Last PR of libvault is #14498, far before v2 pipeline. There might be more fixes needed to pass this pipeline.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Sep 2, 2023

libvault shared, msvc:

ERROR: libvault/0.52.0 (test package): Error in test() method, line 19
	self.run(bin_path, run_environment=True)
	ConanException: Error 3221225785 while executing bin\test_package

Ok so the problem on Windows is that there is a Vault.dll system library in System32 (found first by runtime loader), and libvault creates vault.dll file, it's an unfortunate name.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Sep 6, 2023

libvault shared, msvc:

ERROR: libvault/0.52.0 (test package): Error in test() method, line 19
	self.run(bin_path, run_environment=True)
	ConanException: Error 3221225785 while executing bin\test_package

Ok so the problem on Windows is that there is a Vault.dll system library in System32 (found first by runtime loader), and libvault creates vault.dll file, it's an unfortunate name.

abedra/libvault#116

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 8 (316651ca1f788e24dafaf71a18ed62b653bf93c3):

  • libvault/0.51.0:
    All packages built successfully! (All logs)

  • libvault/0.48.0:
    All packages built successfully! (All logs)

  • libvault/0.52.0:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 8 (316651ca1f788e24dafaf71a18ed62b653bf93c3):

  • libvault/0.48.0:
    All packages built successfully! (All logs)

  • libvault/0.52.0:
    All packages built successfully! (All logs)

  • libvault/0.51.0:
    All packages built successfully! (All logs)

@RubenRBS RubenRBS self-assigned this Oct 9, 2023
Copy link
Member

@RubenRBS RubenRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One question about one of the lines of the CMake patch, otherwise looks nice

Thanks a lot as well for the detailed PR message, helps a lot :)

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Oct 20, 2023

Is there still anything preventing this PR to be accepted and merged?

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Nov 3, 2023

@RubenRBS @uilianries could you review this one please?

@ghost
Copy link

ghost commented Nov 24, 2023

I detected other pull requests that are modifying libvault/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@mayeut mayeut mentioned this pull request Dec 3, 2023
3 tasks
@SpaceIm
Copy link
Contributor Author

SpaceIm commented Dec 20, 2023

@RubenRBS @uilianries could you accept this PR please? It's been 3 months :(

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 050d13b into conan-io:master Dec 27, 2023
23 checks passed
@SpaceIm SpaceIm deleted the fix/libvault-conan-v2 branch December 27, 2023 16:35
valgur pushed a commit to valgur/conan-center-index that referenced this pull request Jan 1, 2024
…l Studio Version + many small fixes

* fix import of Version

* use export_conandata_patches for patches

* remove useless VirtualBuildEnv

* bump libcurl

* remove useless catch2 in requirements

* add package_type

* fix min Visual Studio/msvc version

* no self.info in validate()

* remove useless CMakeLists

* add a layout

* add libm to system libs on Linux & FreeBSD only

* final cleanup

* fix traits of requirements

* cleanup

* do not manually set CMAKE_OSX_DEPLOYMENT_TARGET

it's already handled by CMakeToolchain

* bump libcurl

* use version range for libcurl

* fix dll name to avoid conflict with Vault.dll system lib on Windows

* fix patch for 0.52.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants