liburing: Update recipe for version 2.3 #19739

thejohnfreeman · 2023-09-11T16:59:42Z

Recent versions of Facebook's folly depend on liburing >= 2.3.

Linux is on kernel major version 6, for which there are no header packages in Conan Center. I was able to build by just removing the requirement.

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

CLAassistant · 2023-09-11T16:59:47Z

All committers have signed the CLA.

conan-center-bot · 2023-09-11T19:31:04Z

Conan v1 pipeline ❌

Failure in build 2 (44d0ab7d7a50fccd4b516559a66897c92d7225ef):

liburing/2.2:
All packages built successfully! (All logs)
liburing/0.7:
All packages built successfully! (All logs)
liburing/2.0:
All packages built successfully! (All logs)

liburing/2.3:
CI failed to create some packages (All logs)

Logs for packageID 52233aafaecff194f5f027228cc17af7aadda402:

[settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.libcxx=libstdc++11
compiler.version=11
os=Linux
[options]
liburing:shared=False

[...]
     CC socket.t
     CC socket-rw.t
     CC socket-rw-eagain.t
     CC socket-rw-offset.t
     CC splice.t
     CC sq-full.t
     CXX sq-full-cpp.t
     CC sqpoll-cancel-hang.t
     CC sqpoll-disable-exit.t
     CC sq-poll-dup.t
     CC sqpoll-exit-hang.t
     CC sq-poll-kthread.t
     CC sq-poll-share.t
     CC sqpoll-sleep.t
     CC sq-space_left.t
     CC stdout.t
     CC submit-and-wait.t
     CC submit-link-fail.t
     CC submit-reuse.t
     CC sync-cancel.t
     CC symlink.t
     CC teardowns.t
     CC thread-exit.t
     CC timeout.t
     CC timeout-new.t
     CC timeout-overflow.t
     CC tty-write-dpoll.t
     CC unlink.t
     CC wakeup-hang.t
     CC xattr.t
     CC single-issuer.t
     CC send-zerocopy.t
Makefile:214: recipe for target 'send-zerocopy.t' failed
make[1]: Leaving directory '/home/conan/w/prod-v1/bsr/6571/ffcad/.conan/data/liburing/2.3/_/_/build/52233aafaecff194f5f027228cc17af7aadda402/source_subfolder/test'
Makefile:10: recipe for target 'all' failed
liburing/2.3: 
ar: creating liburing.a
cc1plus: warning: command-line option '-std=gnu99' is valid for C/ObjC but not for C++
send-zerocopy.c: In function 'create_socketpair_ip':
send-zerocopy.c:241:58: error: 'SO_ZEROCOPY' undeclared (first use in this function)
  241 |                 if (setsockopt(*sock_client, SOL_SOCKET, SO_ZEROCOPY, &val, sizeof(val))) {
      |                                                          ^~~~~~~~~~~
send-zerocopy.c:241:58: note: each undeclared identifier is reported only once for each function it appears in
make[1]: *** [send-zerocopy.t] Error 1
make: *** [all] Error 2
liburing/2.3: ERROR: Package '52233aafaecff194f5f027228cc17af7aadda402' build failed
liburing/2.3: WARN: Build folder /home/conan/w/prod-v1/bsr/6571/ffcad/.conan/data/liburing/2.3/_/_/build/52233aafaecff194f5f027228cc17af7aadda402
ERROR: liburing/2.3: Error in build() method, line 88
	autotools.make()
	ConanException: Error 2 while executing make -j3

liburing/2.1:
Didn't run or was cancelled before finishing

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

See details:

Failure in build 2 (44d0ab7d7a50fccd4b516559a66897c92d7225ef):

liburing/2.3:
Error running command conan export --name liburing --version 2.3 recipes/liburing/all/conanfile.py:

======== Exporting recipe to the cache ========
ERROR: Error loading conanfile at '/home/conan/w/prod-v2_cci_PR-19739/recipes/liburing/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod-v2_cci_PR-19739/recipes/liburing/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod-v2_cci_PR-19739/recipes/liburing/all/conanfile.py", line 1, in <module>
    from conans import AutoToolsBuildEnvironment
ImportError: cannot import name 'AutoToolsBuildEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

liburing/2.2:
Error running command conan export --name liburing --version 2.2 recipes/liburing/all/conanfile.py:

======== Exporting recipe to the cache ========
ERROR: Error loading conanfile at '/home/conan/w/prod-v2_cci_PR-19739/recipes/liburing/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod-v2_cci_PR-19739/recipes/liburing/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod-v2_cci_PR-19739/recipes/liburing/all/conanfile.py", line 1, in <module>
    from conans import AutoToolsBuildEnvironment
ImportError: cannot import name 'AutoToolsBuildEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

liburing/2.1:
Error running command conan export --name liburing --version 2.1 recipes/liburing/all/conanfile.py:

======== Exporting recipe to the cache ========
ERROR: Error loading conanfile at '/home/conan/w/prod-v2_cci_PR-19739/recipes/liburing/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod-v2_cci_PR-19739/recipes/liburing/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod-v2_cci_PR-19739/recipes/liburing/all/conanfile.py", line 1, in <module>
    from conans import AutoToolsBuildEnvironment
ImportError: cannot import name 'AutoToolsBuildEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

liburing/0.7:
Error running command conan export --name liburing --version 0.7 recipes/liburing/all/conanfile.py:

======== Exporting recipe to the cache ========
ERROR: Error loading conanfile at '/home/conan/w/prod-v2_cci_PR-19739/recipes/liburing/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod-v2_cci_PR-19739/recipes/liburing/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod-v2_cci_PR-19739/recipes/liburing/all/conanfile.py", line 1, in <module>
    from conans import AutoToolsBuildEnvironment
ImportError: cannot import name 'AutoToolsBuildEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

liburing/2.0:
Error running command conan export --name liburing --version 2.0 recipes/liburing/all/conanfile.py:

======== Exporting recipe to the cache ========
ERROR: Error loading conanfile at '/home/conan/w/prod-v2_cci_PR-19739/recipes/liburing/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod-v2_cci_PR-19739/recipes/liburing/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod-v2_cci_PR-19739/recipes/liburing/all/conanfile.py", line 1, in <module>
    from conans import AutoToolsBuildEnvironment
ImportError: cannot import name 'AutoToolsBuildEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

Ahajha · 2023-11-10T15:42:22Z

The source file it's failing on is an example file, it doesn't need to be built. You can specify target="src" in the at.make() line to only build the required files (it speeds up package creation quite a bit, actually). I have the rest of the recipe working locally, I can fork your branch and do a PR if you'd like (I'll make one in ~a day if I don't hear back).

thejohnfreeman · 2023-11-10T16:29:13Z

@Ahajha that'd be great! PR in my fork to update this branch, or a separate PR in this fork?

Ahajha · 2023-11-10T17:15:23Z

@Ahajha that'd be great! PR in my fork to update this branch, or a separate PR in this fork?

I can PR into your fork, I'll do that here shortly! (As soon as I figure out how to fork your fork 😆 )

Edit: Might be later, I'll figure something out 😅, open to suggestions.

Ahajha · 2023-11-10T22:05:17Z

@thejohnfreeman My git-fu is failing me, but I think I can make a separate PR with both of our commits, if that's alright with you?

thejohnfreeman · 2023-11-10T22:10:50Z

@Ahajha sure, just tag this PR so I get the notification and I'll close it.

ghost · 2023-11-10T22:27:15Z

I detected other pull requests that are modifying liburing/all recipe:

liburing: Add 2.3+2.4 and update to Conan 2 #21061

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

Update recipe for liburing 2.3

7c0ce7e

thejohnfreeman changed the title ~~Update recipe for liburing 2.3~~ liburing: Update recipe for version 2.3 Sep 11, 2023

prince-chrismc mentioned this pull request Sep 11, 2023

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

conan-center-bot added the Failed label Sep 11, 2023

This comment has been minimized.

Sign in to view

Add new version to config.yml

44d0ab7

thejohnfreeman added 2 commits September 21, 2023 16:19

Try to migrate to Conan 2

2cdc716

Lint recipe

e91f729

valgur mentioned this pull request Nov 8, 2023

Conan 2.0 migration: the final 100 #20992

Closed

Ahajha mentioned this pull request Nov 10, 2023

liburing: Add 2.3+2.4 and update to Conan 2 #21061

Merged

3 tasks

ghost mentioned this pull request Nov 10, 2023

[service] Potentially conflicting recipes #3571

Closed

thejohnfreeman closed this Nov 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

liburing: Update recipe for version 2.3 #19739

liburing: Update recipe for version 2.3 #19739

thejohnfreeman commented Sep 11, 2023

CLAassistant commented Sep 11, 2023 •

edited

This comment has been minimized.

conan-center-bot commented Sep 11, 2023

Ahajha commented Nov 10, 2023 •

edited

thejohnfreeman commented Nov 10, 2023

Ahajha commented Nov 10, 2023 •

edited

Ahajha commented Nov 10, 2023

thejohnfreeman commented Nov 10, 2023

ghost commented Nov 10, 2023

liburing: Update recipe for version 2.3 #19739

liburing: Update recipe for version 2.3 #19739

Conversation

thejohnfreeman commented Sep 11, 2023

CLAassistant commented Sep 11, 2023 • edited

This comment has been minimized.

conan-center-bot commented Sep 11, 2023

Conan v1 pipeline ❌

Conan v2 pipeline ❌

Ahajha commented Nov 10, 2023 • edited

thejohnfreeman commented Nov 10, 2023

Ahajha commented Nov 10, 2023 • edited

Ahajha commented Nov 10, 2023

thejohnfreeman commented Nov 10, 2023

ghost commented Nov 10, 2023

CLAassistant commented Sep 11, 2023 •

edited

Ahajha commented Nov 10, 2023 •

edited

Ahajha commented Nov 10, 2023 •

edited