-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add license change explanation #20763
[docs] Add license change explanation #20763
Conversation
Signed-off-by: Uilian Ries <uilianries@gmail.com>
🤖 Beep Boop! This pull request is making changes to 'docs//'. 👋 @prince-chrismc @MartinDelille @Croydon you might be interested. 😉 |
|
||
```python | ||
class LibfooConan(ConanFile): | ||
license = "MIT" # old license |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe when I was talking to @prince-chrismc about this in the past, he recommended placing both in the license
field here so that they would show up in conan inspect
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's true, conan inspect
does not run configure
so it lies about the license. I gonna talk to Conan team in case we can do something, otherwise, let's keep both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jwillikers I talked to the team and a new idea came up, please, check the new commit to see if it's clear enough, otherwise, we can improve the description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks great, thank you!
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Any project is free to change its license, so to follow-up in the recipe, we can change it through
configure()
andself.license
Related to #19152
/cc @fschoenm