Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pango: migrate to Conan v2 #20795

Merged
merged 27 commits into from
Jan 31, 2024
Merged

pango: migrate to Conan v2 #20795

merged 27 commits into from
Jan 31, 2024

Conversation

mayeut
Copy link
Contributor

@mayeut mayeut commented Oct 28, 2023

Specify library name and version: pango/all

based on #17655

jwillikers and others added 17 commits May 22, 2023 11:34
@jwillikers
pango: Support Conan V2
7128e4e 
Fix the SPDX license identifier.
Order versions.
Add glib tool requirement for glib-mkenums.
@jwillikers
Fix configure
8c18230
@jwillikers
Fix incorrect attempt to modify option with_xft from auto to True
0f8289f 
This fix is necessary for Conan V2 only.
@jwillikers
Revert "Fix incorrect attempt to modify option with_xft from auto to …
ae4d715 
…True"

This reverts commit 0f8289f.
@jwillikers
Remove the auto value as an option
de433e6 
The use of "auto" for this option is inappropriate.
It should only be True or False because that is how it is used.
@jwillikers
Merge branch 'master' into pango-conan-v2
b941ce3
@jwillikers
Fix options configuration in configure method for Conan V2
f8d08f8
@jwillikers
Fix option checking
d966522
@jwillikers
Bump glib
697f6bf
@jwillikers
Revert "Fix option checking"
bd00a8e 
This reverts commit d966522.
@jwillikers
Configure default options in the config_options method
ce69549
@jwillikers
Use self.info.options
3bbe03d
@jwillikers
Bump glib
50f1583
@jwillikers
Merge branch 'master' into pango-conan-v2
e6d0ebf
@mayeut
bump deps
5829403
@mayeut
Merge branch 'master' into pango-v2
608c452
@mayeut
fix transitive_headers
84d664c
@ghost
Copy link

ghost commented Oct 28, 2023

I detected other pull requests that are modifying pango/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

This was referenced Oct 28, 2023
Closed
Closed
@conan-center-bot conan-center-bot added Failed Missing dependencies Build failed due missing dependencies in Conan Center labels Oct 28, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@ghost ghost mentioned this pull request Oct 31, 2023
Closed
@conan-center-bot conan-center-bot added Service Under Maintenance and removed Failed Missing dependencies Build failed due missing dependencies in Conan Center labels Dec 1, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@prince-chrismc prince-chrismc mentioned this pull request Dec 1, 2023
Open
@conan-center-bot conan-center-bot added Failed Missing dependencies Build failed due missing dependencies in Conan Center and removed Service Under Maintenance labels Dec 2, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot conan-center-bot removed Failed Missing dependencies Build failed due missing dependencies in Conan Center labels Dec 3, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur
Copy link
Contributor

valgur commented Dec 9, 2023

Can you please add these two latest versions to this PR as well? https://github.com/conan-io/conan-center-index/pull/18874/files#diff-7c0a92584e04c88fabfad61f88ac88d09675c52bd4ec3b1f48d2d8bd6b8fc3d0

They should build without any issues.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 9 (39c0ba2525ba4ba016c6d2ba7b49af15fb8b74fe):

  • pango/1.50.14:
    All packages built successfully! (All logs)

  • pango/1.51.0:
    All packages built successfully! (All logs)

  • pango/1.50.10:
    All packages built successfully! (All logs)

  • pango/1.50.8:
    All packages built successfully! (All logs)

  • pango/1.50.7:
    All packages built successfully! (All logs)

  • pango/1.49.3:
    All packages built successfully! (All logs)

  • pango/1.48.9:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 9 (39c0ba2525ba4ba016c6d2ba7b49af15fb8b74fe):

  • pango/1.50.14:
    All packages built successfully! (All logs)

  • pango/1.50.8:
    All packages built successfully! (All logs)

  • pango/1.51.0:
    All packages built successfully! (All logs)

  • pango/1.50.10:
    All packages built successfully! (All logs)

  • pango/1.50.7:
    All packages built successfully! (All logs)

  • pango/1.49.3:
    All packages built successfully! (All logs)

  • pango/1.48.9:
    All packages built successfully! (All logs)

@valgur
Copy link
Contributor

valgur commented Dec 19, 2023

@uilianries pinging for a review, if possible. This package is a blocker for a ton of other PRs.

@mayeut
Copy link
Contributor Author

mayeut commented Jan 4, 2024

@RubenRBS, @uilianries, pinging for a review, if possible. This package is a blocker for a ton of other PRs.

@db4 db4 mentioned this pull request Jan 9, 2024
Open
This was referenced Jan 16, 2024
Open
Closed
@conan-center-bot conan-center-bot merged commit 6e34fd4 into conan-io:master Jan 31, 2024
43 checks passed
@mayeut mayeut deleted the pango-v2 branch January 31, 2024 21:35
Ahajha pushed a commit to Ahajha/conan-center-index that referenced this pull request Feb 10, 2024
@mayeut @jwillikers @Ahajha
(conan-io#20795) pango: migrate to Conan v2
c060e06 
* pango: Support Conan V2

Fix the SPDX license identifier.
Order versions.
Add glib tool requirement for glib-mkenums.

* Fix configure

* Fix incorrect attempt to modify option with_xft from auto to True

This fix is necessary for Conan V2 only.

* Revert "Fix incorrect attempt to modify option with_xft from auto to True"

This reverts commit 0f8289f.

* Remove the auto value as an option

The use of "auto" for this option is inappropriate.
It should only be True or False because that is how it is used.

* Fix options configuration in configure method for Conan V2

* Fix option checking

* Bump glib

* Revert "Fix option checking"

This reverts commit d966522.

* Configure default options in the config_options method

* Use self.info.options

* Bump glib

* bump deps

* fix transitive_headers

* bump libxft

* bump cairo

* bump deps

* remove package_id & configure shared

same as conan-io#17844

* add versions 1.50.14 & 1.51.0

---------

Co-authored-by: Jordan Williams <jordan@jwillikers.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danimtb danimtb danimtb approved these changes

@jwillikers jwillikers jwillikers approved these changes

@jcar87 jcar87 Awaiting requested review from jcar87

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mayeut @conan-center-bot @valgur @danimtb @jwillikers