Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crashpad: migrate to Conan v2 #21052

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Nov 10, 2023

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@mayeut mayeut mentioned this pull request Dec 3, 2023
3 tasks
Copy link

stale bot commented Dec 15, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@valgur valgur marked this pull request as ready for review May 6, 2024 16:30
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Failure in build 9 (4964ef9ef4f479008b5bd8484b230a5d1edb6f0a):

  • crashpad/cci.20231107:
    CI failed to create some packages (All logs)

    Logs for packageID e41d5445649c2aa1126fade59a77aca3bdd06fd7:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=5
    os=Linux
    [options]
    crashpad:shared=False
    
    [...]
    ninja/1.12.0: Not found in local cache, looking in remotes...
    ninja/1.12.0: Trying with 'conan-center'...
    Downloading conanmanifest.txt
    Downloading conanfile.py
    Downloading conan_export.tgz
    ninja/1.12.0: Downloaded recipe revision df23b5531c497e95986c1cbeb7f164a3
    gn/cci.20210429: Not found in local cache, looking in remotes...
    gn/cci.20210429: Trying with 'conan-center'...
    Downloading conanmanifest.txt
    Downloading conanfile.py
    Downloading conan_export.tgz
    gn/cci.20210429: Downloaded recipe revision 25c911bca2d7bbc25e70cb0a3cb7ab0d
    Version ranges solved
        zlib/* versions found in 'conan-center' remote
        Version range '>=1.2.11 <2' required by 'crashpad/cci.20231107' resolved to 'zlib/1.3.1' in remote 'conan-center'
        libcurl/* versions found in 'conan-center' remote
        Version range '>=7.78 <9' required by 'crashpad/cci.20231107' resolved to 'libcurl/8.8.0' in remote 'conan-center'
        openssl/* versions found in 'conan-center' remote
        Version range '>=1.1 <4' required by 'libcurl/8.8.0' resolved to 'openssl/3.2.2' in remote 'conan-center'
        Version range '>=1.2.11 <2' required by 'libcurl/8.8.0' valid for downstream requirement 'zlib/1.3.1'
        Version range '>=1.2.11 <2' required by 'openssl/3.2.2' valid for downstream requirement 'zlib/1.3.1'
    
    Installing package: crashpad/cci.20231107
    Requirements
        crashpad/cci.20231107 from local cache - Cache
        libcurl/8.8.0 from 'conan-center' - Downloaded
        linux-syscall-support/2022.10.12 from 'conan-center' - Downloaded
        openssl/3.2.2 from 'conan-center' - Downloaded
        zlib/1.3.1 from 'conan-center' - Downloaded
    Packages
        crashpad/cci.20231107:e41d5445649c2aa1126fade59a77aca3bdd06fd7 - Build
        libcurl/8.8.0:2ca11c377d191f7f426e3f7654bf2bb91abc44b4 - Download
        linux-syscall-support/2022.10.12:5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9 - Download
        openssl/3.2.2:288ceea1eccdb5f24f7075ead24b83b854b1d943 - Download
        zlib/1.3.1:76f87539fc90ff313e0b3182641a9bb558a717d2 - Download
    Build requirements
        gn/cci.20210429 from 'conan-center' - Downloaded
        ninja/1.12.0 from 'conan-center' - Downloaded
    Build requirements packages
        gn/cci.20210429:INVALID - Invalid
        ninja/1.12.0:24647d9fe8ec489125dfbae4b3ebefaf7581674c - Download
    
    Installing (downloading, building) binaries...
    WARN: *** Conan 1 is legacy and on a deprecation path ***
    WARN: *** Please upgrade to Conan 2 ***
    WARN: libcurl/8.8.0: requirement zlib/[>=1.2.11 <2] overridden by crashpad/cci.20231107 to zlib/1.3.1 
    WARN: openssl/3.2.2: requirement zlib/[>=1.2.11 <2] overridden by libcurl/8.8.0 to zlib/1.3.1 
    crashpad/cci.20231107: WARN: crashpad needs a shared libcurl library
    ERROR: There are invalid packages (packages that cannot exist for this configuration):
    gn/cci.20210429: Invalid ID: gn requires a compiler supporting c++17
    
  • crashpad/cci.20220219:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

See details:

Failure in build 9 (4964ef9ef4f479008b5bd8484b230a5d1edb6f0a):

  • crashpad/cci.20231107:
    Didn't run or was cancelled before finishing

  • crashpad/cci.20220219:
    CI failed to create some packages (All logs)

    Logs for packageID 5a01124c532f43094b45bea60879311e1de4dad5:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.cppstd=17
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    [options]
    */*:shared=False
    
    [...]
    
    -------- Downloading 6 packages --------
    linux-syscall-support/2022.10.12: Retrieving package da39a3ee5e6b4b0d3255bfef95601890afd80709 from remote 'conan-center' 
    linux-syscall-support/2022.10.12: Package installed da39a3ee5e6b4b0d3255bfef95601890afd80709
    linux-syscall-support/2022.10.12: Downloaded package revision dfe566be650c5a3fe4ad05e08fa7042e
    ninja/1.12.0: Retrieving package 3593751651824fb813502c69c971267624ced41a from remote 'conan-center' 
    ninja/1.12.0: Package installed 3593751651824fb813502c69c971267624ced41a
    ninja/1.12.0: Downloaded package revision c046717f0761795a7c02856b560b0245
    zlib/1.3.1: Retrieving package b647c43bfefae3f830561ca202b6cfd935b56205 from remote 'conan-center' 
    zlib/1.3.1: Package installed b647c43bfefae3f830561ca202b6cfd935b56205
    zlib/1.3.1: Downloaded package revision 6b307bbcbae23635c4006543ffdbf3ef
    gn/cci.20210429: Retrieving package 3593751651824fb813502c69c971267624ced41a from remote 'conan-center' 
    gn/cci.20210429: Package installed 3593751651824fb813502c69c971267624ced41a
    gn/cci.20210429: Downloaded package revision e1e17b8e78fcfedaabf8bc9ea5650b54
    openssl/3.2.2: Retrieving package ba0c965640dfc9185194d683d05bfbe6419b47a3 from remote 'conan-center' 
    openssl/3.2.2: Package installed ba0c965640dfc9185194d683d05bfbe6419b47a3
    openssl/3.2.2: Downloaded package revision 314f203a85c840d3412510eb1c1f4ac5
    libcurl/8.8.0: Retrieving package 70e7cf9ffe77f4d236b7b50402b06edab8da6db5 from remote 'conan-center' 
    libcurl/8.8.0: Package installed 70e7cf9ffe77f4d236b7b50402b06edab8da6db5
    libcurl/8.8.0: Downloaded package revision 4ceade1b7ccb0b84e170af44fe10fa73
    gn/cci.20210429: Appending PATH environment variable: /home/conan/workspace/prod-v2/bsr/51010/ecdfb/p/gnd3cd1775f0ef0/p/bin
    crashpad/cci.20220219: Calling source() in /home/conan/workspace/prod-v2/bsr/51010/ecdfb/p/crasha65524beccf8b/s/src
    crashpad/cci.20220219: WARN: File https://github.com/chromium/crashpad/archive/e9937cb36cd12f24d73a07c4b91168cf1885b5db.tar.gz not found in https://c3i.jfrog.io/artifactory/conan-center-backup-sources/
    crashpad/cci.20220219: WARN: File https://github.com/chromium/mini_chromium/archive/822fada4a9972e3e2f36a981da770539025beb0a.tar.gz not found in https://c3i.jfrog.io/artifactory/conan-center-backup-sources/
    
    -------- Installing package crashpad/cci.20220219 (7 of 7) --------
    crashpad/cci.20220219: Building from source
    crashpad/cci.20220219: Package crashpad/cci.20220219:5a01124c532f43094b45bea60879311e1de4dad5
    crashpad/cci.20220219: Copying sources to build folder
    crashpad/cci.20220219: Building your package in /home/conan/workspace/prod-v2/bsr/51010/ecdfb/p/b/crash38907a3ffc382/b
    crashpad/cci.20220219: Calling generate()
    crashpad/cci.20220219: Generators folder: /home/conan/workspace/prod-v2/bsr/51010/ecdfb/p/b/crash38907a3ffc382/b/build-release/conan
    crashpad/cci.20220219: Generating aggregated env files
    crashpad/cci.20220219: Generated aggregated env files: ['conanbuild.sh']
    crashpad/cci.20220219: Calling build()
    crashpad/cci.20220219: Apply patch (file): patches/cci.20220219-0001-fix-openssl-link-order.patch
    crashpad/cci.20220219: Apply patch (file): patches/cci.20220219-0002-remove-fPIC-Werror-LTO.patch
    crashpad/cci.20220219: Apply patch (file): patches/cci.20220219-0003-compilers-from-env.patch
    crashpad/cci.20220219: Apply patch (file): patches/cci.20220219-0005-allow-all-archs.patch
    crashpad/cci.20220219: Apply patch (file): patches/cci.20220219-0006-mini_chromium-win_helper-py3.patch
    crashpad/cci.20220219: Apply patch (file): patches/cci.20210507-0007-use-system-zlib.patch
    crashpad/cci.20220219: Apply patch (file): patches/cci.20220219-0007-static-lib-tool_support.patch
    crashpad/cci.20220219: ERROR: 
    Package '5a01124c532f43094b45bea60879311e1de4dad5' build failed
    crashpad/cci.20220219: WARN: Build folder /home/conan/workspace/prod-v2/bsr/51010/ecdfb/p/b/crash38907a3ffc382/b/build-release
    ERROR: crashpad/cci.20220219: Error in build() method, line 232
    	self._patch_sources()
    while calling '_patch_sources', line 216
    	replace_in_file(self, toolchain_path, 'cc = "clang"','cc = "gcc"')
    	ConanException: replace_in_file didn't find pattern 'cc = "clang"' in '/home/conan/workspace/prod-v2/bsr/51010/ecdfb/p/b/crash38907a3ffc382/b/src/third_party/mini_chromium/mini_chromium/build/config/BUILD.gn' file.
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants