pdfium: migrate to Conan v2 #21130
Merged
pdfium: migrate to Conan v2 #21130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valgur
force-pushed
the
migrate/pdfium
branch
from
b41c5aa
to
2539f2c
Compare
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 2539f2cpdfium/95.0.4629@#e4cfa125138f4f91dffc93d0d44a9d23 |
Conan v1 pipeline ✔️All green in build 3 (
Conan v2 pipeline ✔️
All green in build 3 (
|
jwillikers
approved these changes
Nov 15, 2023
RubenRBS
approved these changes
Nov 15, 2023
| "Visual Studio": 15, | ||
| "gcc": "8", | ||
| "msvc": "191", | ||
| "Visual Studio": "15", |
There was a problem hiding this comment.
Is there no restriction on clang, is the package not compatible with it (Seems like it is based on build logs) or just missing info?
There was a problem hiding this comment.
It built fine with Clang 5.0 in Docker. Conan 2 itself failed to install in the old Clang 4.0 container. I guess leaving it unspecified is ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumped the version to the newest one supported by
pdfium-cmake.The existing version had compilation issues in its C++17 compatibility library.