Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poppler: migrate to Conan v2 #21135

Open
wants to merge 29 commits into
base: master
Choose a base branch
from
Open

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Nov 14, 2023

Worked locally with all options enabled.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@RubenRBS
Copy link
Member

Feel free to remove 21.07.0, after looking at it with @uilianries it's going to be faster than the alternative of trying to properly support it :)
Just remember to remove the toolchain variables that would no longer be needed after that!

@valgur valgur force-pushed the migrate/poppler branch 2 times, most recently from 87039e6 to 7ac49ae Compare November 16, 2023 14:16
@conan-center-bot

This comment has been minimized.

@h-2
Copy link

h-2 commented Nov 20, 2023

Having this package in Conan2 is one of our main blockers, so work on this is very much appreciated!

Btw, does the package also offer the details headers found in operating system packages like libpoppler-private-dev on Ubuntu?
Thanks!

@uilianries
Copy link
Member

@h-2 I didn't check but I would say yes. Most of Conan packages are equivalent of -dev on Ubuntu.

@h-2
Copy link

h-2 commented Nov 22, 2023

@h-2 I didn't check but I would say yes. Most of Conan packages are equivalent of -dev on Ubuntu.

Yeah, but the normal ubuntu dev package is libpoppler-dev. The one I asked for is libpoppler-private-dev which includes things not normally included. Maybe that would be an extra component?

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Failure in build 4 (c3938ba27c21b5cf7f29f5409d505eb1a3e2cf36):

  • poppler/24.05.0:
    CI failed to create some packages (All logs)

    Logs for packageID 297d5229e60bb925d6987819d6791c86c9e55071:
    [settings]
    arch=x86_64
    build_type=Debug
    compiler=Visual Studio
    compiler.runtime=MDd
    compiler.version=16
    os=Windows
    [options]
    poppler:shared=False
    
    [...]
       poppler source folder or specify the location of your
       checkout with -DTESTDATADIR=/path/to/checkoutdir/test.
        
    
    
    Building Poppler with support for:
      font configuration:   generic
      use boost (Splash):   yes
      cairo output:         no
      qt5 wrapper:          no
      qt6 wrapper:          no
      glib wrapper:         no
        introspection:      no
        gtk-doc:            no
      cpp wrapper:          yes
      use libjpeg:          yes
      use libpng:           yes
      use libtiff:          yes
      use zlib uncompress:  yes
      use nss3:             no
      use gpg:              no
        default signature backend:          None
      use curl:             no
      use libopenjpeg2:     yes
      use lcms2:            yes
      command line utils:   no
      fuzz target:          no
      test data dir:        C:/J/workspace/prod-v1/bsr/49833/baadc/.conan/data/poppler/24.05.0/_/_/build/297d5229e60bb925d6987819d6791c86c9e55071/src/../test
    Warning: Using zlib is not totally safe
    CMake Warning:
      Manually-specified variables were not used by the project:
    
        CMAKE_POLICY_DEFAULT_CMP0091
    
    
    WARN: *** Conan 1 is legacy and on a deprecation path ***
    WARN: *** Please upgrade to Conan 2 ***
    WARN: freetype/2.13.2: requirement libpng/[>=1.6 <2] overridden by poppler/24.05.0 to libpng/1.6.43 
    WARN: freetype/2.13.2: requirement zlib/[>=1.2.10 <2] overridden by poppler/24.05.0 to zlib/1.3.1 
    WARN: libpng/1.6.43: requirement zlib/[>=1.2.11 <2] overridden by freetype/2.13.2 to zlib/1.3.1 
    WARN: libtiff/4.6.0: requirement zlib/[>=1.2.11 <2] overridden by poppler/24.05.0 to zlib/1.3.1 
    WARN: boost/1.85.0: requirement zlib/[>=1.2.11 <2] overridden by poppler/24.05.0 to zlib/1.3.1 
    boost/1.85.0: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    poppler/24.05.0: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    poppler/24.05.0: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    poppler/24.05.0: ERROR: Package '297d5229e60bb925d6987819d6791c86c9e55071' build failed
    poppler/24.05.0: WARN: Build folder C:\J\workspace\prod-v1\bsr\49833\baadc\.conan\data\poppler\24.05.0\_\_\build\297d5229e60bb925d6987819d6791c86c9e55071\build
    ERROR: poppler/24.05.0: Error in build() method, line 270
    	cmake.build()
    	ConanException: Error 1 while executing cmake --build "C:\J\workspace\prod-v1\bsr\49833\baadc\.conan\data\poppler\24.05.0\_\_\build\297d5229e60bb925d6987819d6791c86c9e55071\build" --config Debug
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

See details:

Failure in build 4 (c3938ba27c21b5cf7f29f5409d505eb1a3e2cf36):

  • poppler/24.05.0:
    CI failed to create some packages (All logs)

    Logs for packageID 494b25861c77e68dee151d44a3e9acd218a9b4e7:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=msvc
    compiler.cppstd=17
    compiler.runtime=dynamic
    compiler.runtime_type=Release
    compiler.version=193
    os=Windows
    [options]
    */*:shared=False
    
    [...]
      ProfileData.cc
      PreScanOutputDev.cc
      PSTokenizer.cc
      SignatureInfo.cc
      Stream.cc
      StructTreeRoot.cc
      StructElement.cc
      UnicodeMap.cc
      UnicodeMapFuncs.cc
      UnicodeTypeTable.cc
      UTF.cc
      XRef.cc
      PSOutputDev.cc
      TextOutputDev.cc
      PageLabelInfo.cc
      SecurityHandler.cc
      Sound.cc
      ViewerPreferences.cc
      Movie.cc
      Rendition.cc
      CertificateInfo.cc
      BBoxOutputDev.cc
      SplashOutputDev.cc
      Splash.cc
      SplashBitmap.cc
      SplashClip.cc
      SplashFTFont.cc
      SplashFTFontEngine.cc
      SplashFTFontFile.cc
      SplashFont.cc
      SplashFontEngine.cc
      SplashFontFile.cc
    C:\J\workspace\prod-v2\bsr@2\44180\cdfcf\p\b\popplb668286d6b807\b\src\poppler\SplashOutputDev.cc(2624,34): warning C4805: '^': unsafe mix of type 'unsigned char' and type 'bool' in operation [C:\J\workspace\prod-v2\bsr@2\44180\cdfcf\p\b\popplb668286d6b807\b\build\poppler.vcxproj]
      SplashFontFileID.cc
      SplashPath.cc
      SplashPattern.cc
      SplashScreen.cc
      SplashState.cc
      SplashXPath.cc
      SplashXPathScanner.cc
      DCTStream.cc
      FlateStream.cc
      JPEG2000Stream.cc
    
    poppler/24.05.0: ERROR: 
    Package '494b25861c77e68dee151d44a3e9acd218a9b4e7' build failed
    poppler/24.05.0: WARN: Build folder C:\J\workspace\prod-v2\bsr@2\44180\cdfcf\p\b\popplb668286d6b807\b\build
    ERROR: poppler/24.05.0: Error in build() method, line 270
    	cmake.build()
    	ConanException: Error 1 while executing
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

ViliusSutkus89 added a commit to ViliusSutkus89/conanports that referenced this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants