Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-cdi-sdk: migrate to Conan v2 #21164

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Nov 16, 2023

Replaced the Makefile in the project with an equivalent CMakeLists.txt: https://github.com/aws/aws-cdi-sdk/blob/v2.4.1/Makefile
That turned out to take less effort than patching around and configuring the Makefile. This should also enable Windows and macOS support for the recipe.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Failure in build 1 (50bc62fe2993d7df783fe71be40c3c0d3ed9330f):

  • aws-cdi-sdk/2.2.0:
    Didn't run or was cancelled before finishing

  • aws-cdi-sdk/2.4.1:
    CI failed to create some packages (All logs)

    Logs for packageID 2276e2e93214c44a88221f67a648303fced70951:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    [options]
    aws-cdi-sdk:shared=True
    
    [...]
    -- Configuring done
    -- Generating done
    -- Build files have been written to: /home/conan/workspace/prod-v1/bsr/cci-7d83d6a2/recipes/aws-cdi-sdk/all/test_v1_package/build/e4c255d3141ec5b2877541e31a0b664dbc4cc691
    
    ----Running------
    > cmake --build '/home/conan/workspace/prod-v1/bsr/cci-7d83d6a2/recipes/aws-cdi-sdk/all/test_v1_package/build/e4c255d3141ec5b2877541e31a0b664dbc4cc691' '--' '-j3'
    -----------------
    Scanning dependencies of target test_package
    [ 50%] Building C object test_package/CMakeFiles/test_package.dir/test_package.c.o
    [100%] Linking C executable ../bin/test_package
    [100%] Built target test_package
    aws-cdi-sdk/2.4.1 (test package): Running test()
    
    ----Running------
    > bin/test_package
    -----------------
    CMake Warning:
      Manually-specified variables were not used by the project:
    
        CMAKE_EXPORT_NO_PACKAGE_REGISTRY
        CMAKE_INSTALL_DATAROOTDIR
        CMAKE_INSTALL_LIBEXECDIR
        CMAKE_INSTALL_OLDINCLUDEDIR
        CMAKE_INSTALL_SBINDIR
    
    
    /opt/conan/binutils/bin/ld: warning: libXvMC.so.1, needed by /home/conan/workspace/prod-v1/bsr/44924/ccbec/.conan/data/aws-cdi-sdk/2.4.1/_/_/package/2276e2e93214c44a88221f67a648303fced70951/lib/libaws-cpp-sdk-cdi.so, not found (try using -rpath or -rpath-link)
    bin/test_package: error while loading shared libraries: libXvMC.so.1: cannot open shared object file: No such file or directory
    WARN: *** Conan 1 is legacy and on a deprecation path ***
    WARN: *** Please upgrade to Conan 2 ***
    WARN: aws-c-cal/0.5.13: requirement openssl/[>=1.1 <4] overridden by aws-c-io/0.10.20 to openssl/3.2.1 
    WARN: s2n/1.3.55: requirement openssl/[>=1.1 <4] overridden by aws-c-io/0.10.20 to openssl/3.2.1 
    WARN: libcurl/8.6.0: requirement openssl/[>=1.1 <4] overridden by aws-sdk-cpp/1.9.234 to openssl/3.2.1 
    WARN: pulseaudio/14.2: requirement openssl/[>=1.1 <4] overridden by aws-sdk-cpp/1.9.234 to openssl/3.2.1 
    aws-cdi-sdk/2.4.1 (test package): WARN: 
         ************************************************
         The 'cmake' generator is deprecated.
         Please update your code and remove it.
         *************************************************
    
    aws-cdi-sdk/2.4.1 (test package): WARN: 
         ************************************************
         The 'cmake_find_package_multi' generator is deprecated.
         Please update your code and remove it.
         *************************************************
    
    aws-cdi-sdk/2.4.1 (test package): WARN: **** The 'from conans import CMake' helper is deprecated. Please update your code and remove it. ****
    ERROR: aws-cdi-sdk/2.4.1 (test package): Error in test() method, line 17
    	self.run(bin_path, run_environment=True)
    	ConanException: Error 127 while executing bin/test_package
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

See details:

Failure in build 1 (50bc62fe2993d7df783fe71be40c3c0d3ed9330f):

  • aws-cdi-sdk/2.2.0:
    CI failed to create some packages (All logs)

    Logs for packageID 79e2eccd0cbf594ed92ef900737e373b72b9aec2:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.cppstd=17
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    [options]
    */*:shared=True
    
    [...]
    -- Conan: Component target declared 'xorg::xcb-shape'
    -- Conan: Component target declared 'xorg::xcb-shm'
    -- Conan: Component target declared 'xorg::xcb-sync'
    -- Conan: Component target declared 'xorg::xcb-xfixes'
    -- Conan: Component target declared 'xorg::xcb-xinerama'
    -- Conan: Component target declared 'xorg::xcb'
    -- Conan: Component target declared 'xorg::xcb-atom'
    -- Conan: Component target declared 'xorg::xcb-aux'
    -- Conan: Component target declared 'xorg::xcb-event'
    -- Conan: Component target declared 'xorg::xcb-util'
    -- Conan: Component target declared 'xorg::xcb-dri3'
    -- Conan: Component target declared 'xorg::xcb-cursor'
    -- Conan: Component target declared 'xorg::xcb-dri2'
    -- Conan: Component target declared 'xorg::xcb-glx'
    -- Conan: Component target declared 'xorg::xcb-present'
    -- Conan: Component target declared 'xorg::xcb-composite'
    -- Conan: Component target declared 'xorg::xcb-ewmh'
    -- Conan: Component target declared 'xorg::xcb-res'
    -- Conan: Component target declared 'xorg::uuid'
    -- Conan: Component target declared 'xorg::sm'
    -- Conan: Target declared 'xorg::xorg'
    -- Conan: Including build module from '/home/conan/workspace/prod-v2/bsr/40116/efcbc/p/aws-sb19a5683d133d/p/res/cmake/sdk_plugin_conf.cmake'
    -- Building project version: 1.9.234
    -- Configuring done
    -- Generating done
    -- Build files have been written to: /home/conan/workspace/prod-v2/bsr/cci-e2cc01ac/recipes/aws-cdi-sdk/all/test_package/build/gcc-11-x86_64-17-release
    
    aws-cdi-sdk/2.2.0 (test package): Running CMake.build()
    aws-cdi-sdk/2.2.0 (test package): RUN: cmake --build "/home/conan/workspace/prod-v2/bsr/cci-e2cc01ac/recipes/aws-cdi-sdk/all/test_package/build/gcc-11-x86_64-17-release" -- -j3
    Scanning dependencies of target test_package
    [ 50%] Building C object CMakeFiles/test_package.dir/test_package.c.o
    [100%] Linking C executable test_package
    /opt/conan/binutils/bin/ld: warning: libpulse-simple.so.0, needed by /home/conan/workspace/prod-v2/bsr/40116/efcbc/p/aws-sb19a5683d133d/p/lib/libaws-cpp-sdk-text-to-speech.so, not found (try using -rpath or -rpath-link)
    /opt/conan/binutils/bin/ld: warning: libpulse.so.0, needed by /home/conan/workspace/prod-v2/bsr/40116/efcbc/p/aws-sb19a5683d133d/p/lib/libaws-cpp-sdk-text-to-speech.so, not found (try using -rpath or -rpath-link)
    /opt/conan/binutils/bin/ld: warning: libpulsecommon-14.2.so, needed by /home/conan/workspace/prod-v2/bsr/40116/efcbc/p/aws-sb19a5683d133d/p/lib/libaws-cpp-sdk-text-to-speech.so, not found (try using -rpath or -rpath-link)
    /opt/conan/binutils/bin/ld: /home/conan/workspace/prod-v2/bsr/40116/efcbc/p/aws-sb19a5683d133d/p/lib/libaws-cpp-sdk-text-to-speech.so: undefined reference to `pa_simple_new@PULSE_0'
    /opt/conan/binutils/bin/ld: /home/conan/workspace/prod-v2/bsr/40116/efcbc/p/aws-sb19a5683d133d/p/lib/libaws-cpp-sdk-text-to-speech.so: undefined reference to `pa_simple_free@PULSE_0'
    /opt/conan/binutils/bin/ld: /home/conan/workspace/prod-v2/bsr/40116/efcbc/p/aws-sb19a5683d133d/p/lib/libaws-cpp-sdk-text-to-speech.so: undefined reference to `pa_strerror@PULSE_0'
    /opt/conan/binutils/bin/ld: /home/conan/workspace/prod-v2/bsr/40116/efcbc/p/aws-sb19a5683d133d/p/lib/libaws-cpp-sdk-text-to-speech.so: undefined reference to `pa_simple_write@PULSE_0'
    collect2: error: ld returned 1 exit status
    CMakeFiles/test_package.dir/build.make:85: recipe for target 'test_package' failed
    make[2]: *** [test_package] Error 1
    CMakeFiles/Makefile2:75: recipe for target 'CMakeFiles/test_package.dir/all' failed
    make[1]: *** [CMakeFiles/test_package.dir/all] Error 2
    Makefile:83: recipe for target 'all' failed
    make: *** [all] Error 2
    
    ERROR: aws-cdi-sdk/2.2.0 (test package): Error in build() method, line 21
    	cmake.build()
    	ConanException: Error 2 while executing
    
  • aws-cdi-sdk/2.4.1:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants