Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxWidgets intial recipe #21353

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Conversation

gmeeker
Copy link
Contributor

@gmeeker gmeeker commented Nov 24, 2023

Specify library name and version: wxwidgets/3.2.3

Implements #5190 #19991 #20092
Requested by #621

This is a new recipe to CCI. It's an updated version from bincrafters but ported to Conan v2 with additional fixes.

https://github.com/bincrafters/community/tree/main/recipes/wxwidgets

Also unmerged GTK3 work from here (using GTK from Conan recipe):

bincrafters/community#1434

GTK support is currently a draft but macOS and Windows seem usable. Any feedback appreciated. For example, do we need anything older than 3.2.3 here?


@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot conan-center-bot added the Missing dependencies Build failed due missing dependencies in Conan Center label Nov 25, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot conan-center-bot removed the Missing dependencies Build failed due missing dependencies in Conan Center label Nov 25, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@valgur
Copy link
Contributor

valgur commented Dec 13, 2023

The non-system versions of GTK can be used as soon as #21123 gets merged. It's currently blocked by a similar migration PR for pango.

@vpicaver
Copy link

vpicaver commented Mar 8, 2024

What needs to be done to get this merged?

Comment on lines +130 to +131
if self.options.get_safe("cairo"):
packages.append("libcairo2-dev")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be replaced with the cairo package from Conan, probably.

"expat": ["off", "expat"],
"regex": ["off", "regex"],
"svg": ["off", "nanosvg"],
"gtk": [2, 3, "gtk"], # TODO: compile without system gtk
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should get rid of the gtk/system dependency now.

Comment on lines +191 to +195
if not self.dependencies.direct_host["xkbcommon"].options.with_x11:
raise ConanInvalidConfiguration("The 'with_x11' option for the 'xkbcommon' package must be enabled")
if self.dependencies.direct_host["gtk"].options.version != self.options.gtk:
print(self.dependencies.direct_host["gtk"].options.version, self.options.gtk)
raise ConanInvalidConfiguration("The 'version' option for the 'gtk' package must match the 'gtk' option")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set these using self.option[...].xyz or self.requires(..., options={...}) as well.

Copy link
Contributor

@valgur valgur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That's definitely a very challenging library to package.

Although unlikely to work currently due to version conflicts, the recipe should switch to using cairo and gtk from Conan.

@Codinablack
Copy link

This looks amazing! I just want to subscribe to this so I know when it is done, and so I say thank you for your time in making it happen, I know there are many wanting to see this!

@conan-center-bot conan-center-bot added Failed Version conflict There is a version conflict when solving the dependencies graph labels Jul 29, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot conan-center-bot removed Failed Version conflict There is a version conflict when solving the dependencies graph labels Aug 2, 2024
@conan-center-bot

This comment has been minimized.

@czoido czoido self-assigned this Aug 3, 2024
Co-authored-by: Martin Valgur <martin.valgur@gmail.com>
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 4 (febd1548b51ea0d3f77d98c173b18ca823df1a0b):

  • wxwidgets/3.2.5:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 4 (febd1548b51ea0d3f77d98c173b18ca823df1a0b):

  • wxwidgets/3.2.5:
    All packages built successfully! (All logs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants