-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wxWidgets intial recipe #21353
base: master
Are you sure you want to change the base?
wxWidgets intial recipe #21353
Conversation
…e; ported from bincrafters to v2
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The non-system versions of GTK can be used as soon as #21123 gets merged. It's currently blocked by a similar migration PR for |
What needs to be done to get this merged? |
if self.options.get_safe("cairo"): | ||
packages.append("libcairo2-dev") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be replaced with the cairo
package from Conan, probably.
"expat": ["off", "expat"], | ||
"regex": ["off", "regex"], | ||
"svg": ["off", "nanosvg"], | ||
"gtk": [2, 3, "gtk"], # TODO: compile without system gtk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should get rid of the gtk/system
dependency now.
if not self.dependencies.direct_host["xkbcommon"].options.with_x11: | ||
raise ConanInvalidConfiguration("The 'with_x11' option for the 'xkbcommon' package must be enabled") | ||
if self.dependencies.direct_host["gtk"].options.version != self.options.gtk: | ||
print(self.dependencies.direct_host["gtk"].options.version, self.options.gtk) | ||
raise ConanInvalidConfiguration("The 'version' option for the 'gtk' package must match the 'gtk' option") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Set these using self.option[...].xyz
or self.requires(..., options={...})
as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! That's definitely a very challenging library to package.
Although unlikely to work currently due to version conflicts, the recipe should switch to using cairo
and gtk
from Conan.
This looks amazing! I just want to subscribe to this so I know when it is done, and so I say thank you for your time in making it happen, I know there are many wanting to see this! |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Martin Valgur <martin.valgur@gmail.com>
Conan v1 pipeline ✔️All green in build 4 (
Conan v2 pipeline ✔️
All green in build 4 (
|
Specify library name and version: wxwidgets/3.2.3
Implements #5190 #19991 #20092
Requested by #621
This is a new recipe to CCI. It's an updated version from bincrafters but ported to Conan v2 with additional fixes.
https://github.com/bincrafters/community/tree/main/recipes/wxwidgets
Also unmerged GTK3 work from here (using GTK from Conan recipe):
bincrafters/community#1434
GTK support is currently a draft but macOS and Windows seem usable. Any feedback appreciated. For example, do we need anything older than 3.2.3 here?