gtsam: unvendor metis, correct option defaults, drop deprecated option

[valgur]

The default values of many of the options did not match the project defaults at https://github.com/borglab/gtsam/blob/4.2.0/cmake/HandleGeneralOptions.cmake#L17-L31

That's not good, as these can cause unexpected subtle differences in behavior.

I also think the application of CMakeToolchain variables were probably been broken altogether due to CMake version being set to < 3.13 and CMP0077 not being applied.

[valgur]

@RubenRBS Can you maybe somehow check why the Conan v2 build appears to be failing in C3I?

[danimtb]

@valgur sorry for the late reply.

It seems so be an issue in the test_package at link time:

  test_package.cpp
     Creating library C:/J2/w/prod-v2/bsr/cci-c2efb684/recipes/gtsam/all/test_package/build/msvc-192-x86_64-14-release/Release/test_package.lib and object C:/J2/w/prod-v2/bsr/cci-c2efb684/recipes/gtsam/all/test_package/build/msvc-192-x86_64-14-release/Release/test_package.exp
libgtsam.lib(Ordering.obj) : error LNK2019: unresolved external symbol METIS_NodeND referenced in function "public: static class gtsam::Ordering __cdecl gtsam::Ordering::Metis(class gtsam::MetisIndex const &)" (?Metis@Ordering@gtsam@@SA?AV12@AEBVMetisIndex@2@@Z) [C:\J2\w\prod-v2\bsr\cci-c2efb684\recipes\gtsam\all\test_package\build\msvc-192-x86_64-14-release\test_package.vcxproj]
C:\J2\w\prod-v2\bsr\cci-c2efb684\recipes\gtsam\all\test_package\build\msvc-192-x86_64-14-release\Release\test_package.exe : fatal error LNK1120: 1 unresolved externals [C:\J2\w\prod-v2\bsr\cci-c2efb684\recipes\gtsam\all\test_package\build\msvc-192-x86_64-14-release\test_package.vcxproj]

https://c3i.jfrog.io/c3i/misc-v2/summary.html?json=https://c3i.jfrog.io/c3i/misc-v2/logs/pr/22323/13-windows-msvc/gtsam/4.0.3//summary.json

[conan-center-bot]

Conan v1 pipeline ✔️

All green in build 5 (cdcd70f580d1d06074ba47195e27d4607bfbc614):

• gtsam/4.2:
  All packages built successfully! (All logs)

• gtsam/4.1.1:
  All packages built successfully! (All logs)

• gtsam/4.0.3:
  All packages built successfully! (All logs)

---

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 3 (cdcd70f580d1d06074ba47195e27d4607bfbc614):

• gtsam/4.2:
  All packages built successfully! (All logs)

• gtsam/4.1.1:
  All packages built successfully! (All logs)

• gtsam/4.0.3:
  All packages built successfully! (All logs)