g2o: new recipe #22337

valgur · 2024-01-14T22:04:28Z

Adds g2o: https://github.com/RainerKuemmerle/g2o

g2o: A General Framework for Graph Optimization

It's currently missing important, but optional, SuiteSparse and CSparse solver dependencies, which are not yet available on CCI.

Resolves [request] g2o/20201223 #10931

jwillikers · 2024-03-25T11:52:59Z

recipes/g2o/all/conanfile.py

+        # Used in stuff/opengl_wrapper.h
+        self.requires("opengl/system", transitive_headers=True, transitive_libs=True)
+        self.requires("glu/system", transitive_headers=True, transitive_libs=True)


Can you use the mesa-glu and libglvnd packages where possible here?

Suggested change

# Used in stuff/opengl_wrapper.h

self.requires("opengl/system", transitive_headers=True, transitive_libs=True)

self.requires("glu/system", transitive_headers=True, transitive_libs=True)

# Used in stuff/opengl_wrapper.h

if self.settings.os in ["FreeBSD", "Linux"]:

self.requires("libglvnd/1.7.0", transitive_headers=True, transitive_libs=True)

else:

self.requires("opengl/system", transitive_headers=True, transitive_libs=True)

if is_apple_os(self) or self.settings.os == "Windows":

self.requires("glu/system", transitive_headers=True, transitive_libs=True)

else:

self.requires("mesa-glu", transitive_headers=True, transitive_libs=True)

FYI, CMake prior to 3.29 doesn't do a very good job of handling the GLU headers via the FindOpenGL module, so that may require workarounds like I had to do in the FreeGLUT recipe.

jwillikers · 2024-03-25T11:58:35Z

recipes/g2o/all/conanfile.py

+        self.cpp_info.components["g2o_ceres_ad"].set_property("cmake_target_name", "g2o::g2o_ceres_ad")
+        _add_component("stuff", requires=["spdlog::spdlog", "eigen::eigen"])
+        _add_component("core", requires=["stuff", "eigen::eigen", "g2o_ceres_ad"])
+        _add_component("opengl_helper", requires=["opengl::opengl", "glu::glu", "eigen::eigen"])


Suggested change

_add_component("opengl_helper", requires=["opengl::opengl", "glu::glu", "eigen::eigen"])

opengl_helper_requires = ["eigen::eigen"]

if self.settings.os in ["FreeBSD", "Linux"]:

opengl_helper_requires.append("libglvnd::gl")

else:

opengl_helper_requires.append("opengl::opengl")

if is_apple_os(self) or self.settings.os == "Windows":

opengl_helper_requires.append("glu::glu")

else:

opengl_helper_requires.append("mesa-glu::mesa-glu")

_add_component("opengl_helper", requires=opengl_helper_requires)

I'm not sure which component of libglvnd you need here. libglvnd::gl is the legacy GL implementation for X11, pretty much GLX.

jwillikers · 2024-03-25T11:59:09Z

recipes/g2o/all/conanfile.py

+
+from conan import ConanFile
+from conan.errors import ConanInvalidConfiguration
+from conan.tools.build import check_min_cppstd


Suggested change

from conan.tools.build import check_min_cppstd

from conan.tools.apple import is_apple_os

from conan.tools.build import check_min_cppstd

conan-center-bot · 2024-05-06T17:29:13Z

Conan v1 pipeline ❌

Failure in build 4 (3e3726ddac11f734f4b593964d2c73c33a6f3181):

g2o/20230806:
CI failed to create some packages (All logs)

Logs for packageID ccbe45191c6419a9be81f1f13b3b0fbf9dfa0538:

[settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.libcxx=libstdc++11
compiler.version=9
os=Linux
[options]
g2o:shared=False

[...]
dpkg-query: no packages found matching libxv-dev
dpkg-query: no packages found matching libxcb-render-util0-dev
dpkg-query: no packages found matching libxcb-xkb-dev
dpkg-query: no packages found matching libxcb-icccm4-dev
dpkg-query: no packages found matching libxcb-image0-dev
dpkg-query: no packages found matching libxcb-keysyms1-dev
dpkg-query: no packages found matching libxcb-xinerama0-dev
dpkg-query: no packages found matching uuid-dev
dpkg-query: no packages found matching libxcb-cursor-dev
dpkg-query: no packages found matching libxcb-composite0-dev
dpkg-query: no packages found matching libxcb-ewmh-dev
dpkg-query: no packages found matching libxcb-res0-dev
debconf: delaying package configuration, since apt-utils is not installed
dpkg-query: no packages found matching libxcb-util-dev
debconf: delaying package configuration, since apt-utils is not installed
CMake Warning at CMakeLists.txt:128 (find_package):
  By not providing "FindCSPARSE.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "CSPARSE", but
  CMake did not find one.

  Could not find a package configuration file provided by "CSPARSE" with any
  of the following names:

    CSPARSEConfig.cmake
    csparse-config.cmake

  Add the installation prefix of "CSPARSE" to CMAKE_PREFIX_PATH or set
  "CSPARSE_DIR" to a directory containing one of the above files.  If
  "CSPARSE" provides a separate development package or SDK, be sure it has
  been installed.


Qt5 not found. Install it and set Qt5_DIR accordingly
/home/conan/workspace/prod-v1/bsr/38700/cbffa/.conan/data/g2o/20230806/_/_/build/ccbe45191c6419a9be81f1f13b3b0fbf9dfa0538/src/g2o/stuff/opengl_primitives.cpp:27:10: fatal error: GL/glu.h: No such file or directory
   27 | #include <GL/glu.h>
      |          ^~~~~~~~~~
compilation terminated.
make[2]: *** [g2o/stuff/CMakeFiles/opengl_helper.dir/build.make:82: g2o/stuff/CMakeFiles/opengl_helper.dir/opengl_primitives.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:553: g2o/stuff/CMakeFiles/opengl_helper.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:171: all] Error 2
WARN: *** Conan 1 is legacy and on a deprecation path ***
WARN: *** Please upgrade to Conan 2 ***
g2o/20230806: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
g2o/20230806: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
g2o/20230806: ERROR: Package 'ccbe45191c6419a9be81f1f13b3b0fbf9dfa0538' build failed
g2o/20230806: WARN: Build folder /home/conan/workspace/prod-v1/bsr/38700/cbffa/.conan/data/g2o/20230806/_/_/build/ccbe45191c6419a9be81f1f13b3b0fbf9dfa0538/build/Release
ERROR: g2o/20230806: Error in build() method, line 208
	cmake.build()
	ConanException: Error 2 while executing cmake --build "/home/conan/workspace/prod-v1/bsr/38700/cbffa/.conan/data/g2o/20230806/_/_/build/ccbe45191c6419a9be81f1f13b3b0fbf9dfa0538/build/Release" '--' '-j3'

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

See details:

Failure in build 4 (3e3726ddac11f734f4b593964d2c73c33a6f3181):

g2o/20230806:
CI failed to create some packages (All logs)

Logs for packageID c51da1e336d5798ccc41ecf650ab4105c8ca2c4c:

[settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.cppstd=17
compiler.libcxx=libstdc++11
compiler.version=11
os=Linux
[options]
*/*:shared=False

[...]
-- Conan: Component target declared 'wayland::wayland-client'
-- Conan: Component target declared 'wayland::wayland-cursor'
-- Conan: Component target declared 'wayland::wayland-egl'
-- Conan: Component target declared 'wayland::wayland-egl-backend'
-- Conan: Target declared 'wayland::wayland'
-- Conan: Target declared 'libffi::libffi'
-- Conan: Target declared 'LibXml2::LibXml2'
-- Conan: Target declared 'ZLIB::ZLIB'
-- Conan: Target declared 'Iconv::Iconv'
-- Conan: Including build module from '/home/conan/workspace/prod-v2/bsr/34618/faaac/p/libxm6ac9ae515615e/p/lib/cmake/conan-official-libxml2-variables.cmake'
-- Conan: Target declared 'expat::expat'
-- Configuring done
-- Generating done
-- Build files have been written to: /home/conan/workspace/prod-v2/bsr/34618/faaac/p/b/g2odc495fb002a53/b/build/Release

g2o/20230806: Running CMake.build()
g2o/20230806: RUN: cmake --build "/home/conan/workspace/prod-v2/bsr/34618/faaac/p/b/g2odc495fb002a53/b/build/Release" -- -j3
Scanning dependencies of target opengl_helper
[  1%] Building CXX object g2o/stuff/CMakeFiles/opengl_helper.dir/opengl_primitives.cpp.o
Scanning dependencies of target stuff
[  2%] Building CXX object g2o/stuff/CMakeFiles/stuff.dir/timeutil.cpp.o
[  2%] Building CXX object g2o/stuff/CMakeFiles/stuff.dir/command_args.cpp.o
/home/conan/workspace/prod-v2/bsr/34618/faaac/p/b/g2odc495fb002a53/b/src/g2o/stuff/opengl_primitives.cpp:27:10: fatal error: GL/glu.h: No such file or directory
   27 | #include <GL/glu.h>
      |          ^~~~~~~~~~
compilation terminated.
g2o/stuff/CMakeFiles/opengl_helper.dir/build.make:62: recipe for target 'g2o/stuff/CMakeFiles/opengl_helper.dir/opengl_primitives.cpp.o' failed
make[2]: *** [g2o/stuff/CMakeFiles/opengl_helper.dir/opengl_primitives.cpp.o] Error 1
CMakeFiles/Makefile2:164: recipe for target 'g2o/stuff/CMakeFiles/opengl_helper.dir/all' failed
make[1]: *** [g2o/stuff/CMakeFiles/opengl_helper.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[  3%] Building CXX object g2o/stuff/CMakeFiles/stuff.dir/sparse_helper.cpp.o
[  4%] Building C object g2o/stuff/CMakeFiles/stuff.dir/os_specific.c.o
[  4%] Building CXX object g2o/stuff/CMakeFiles/stuff.dir/filesys_tools.cpp.o
[  5%] Building CXX object g2o/stuff/CMakeFiles/stuff.dir/string_tools.cpp.o
[  6%] Building CXX object g2o/stuff/CMakeFiles/stuff.dir/property.cpp.o
[  6%] Building CXX object g2o/stuff/CMakeFiles/stuff.dir/sampler.cpp.o
[  7%] Building CXX object g2o/stuff/CMakeFiles/stuff.dir/tictoc.cpp.o
[  8%] Building CXX object g2o/stuff/CMakeFiles/stuff.dir/logger.cpp.o
[  9%] Linking CXX static library ../../lib/libg2o_stuff.a
[  9%] Built target stuff
Makefile:151: recipe for target 'all' failed
make: *** [all] Error 2

g2o/20230806: ERROR: 
Package 'c51da1e336d5798ccc41ecf650ab4105c8ca2c4c' build failed
g2o/20230806: WARN: Build folder /home/conan/workspace/prod-v2/bsr/34618/faaac/p/b/g2odc495fb002a53/b/build/Release
ERROR: g2o/20230806: Error in build() method, line 208
	cmake.build()
	ConanException: Error 2 while executing

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

prince-chrismc mentioned this pull request Jan 14, 2024

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

conan-center-bot added the Failed label Jan 15, 2024

This comment has been minimized.

Sign in to view

conan-center-bot removed the Failed label Jan 15, 2024

This comment has been minimized.

Sign in to view

RubenRBS self-assigned this Jan 16, 2024

jwillikers suggested changes Mar 25, 2024

View reviewed changes

conan-center-bot requested review from danimtb and uilianries April 2, 2024 11:40

valgur added 3 commits April 29, 2024 17:53

g2o: new recipe

d9d4437

g2o: disable shared Windows builds

1f75321

g2o: add support for CHOLMOD and CSparse

ad90c0d

valgur force-pushed the new/g2o branch from c0aefdd to ad90c0d Compare April 29, 2024 15:38

conan-center-bot added the Failed label Apr 29, 2024

This comment has been minimized.

Sign in to view

g2o: more robust SuiteSparse detection

c0290de

This comment has been minimized.

Sign in to view

valgur added 2 commits May 6, 2024 19:26

Merge remote-tracking branch 'refs/remotes/upstream/master' into new/g2o

5ea79f3

g2o: bump spdlog

86d1a4f

This comment has been minimized.

Sign in to view

g2o: fix CSparse support

3e3726d

valgur mentioned this pull request May 6, 2024

stella_vslam: new recipe #23893

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

g2o: new recipe #22337

g2o: new recipe #22337

valgur commented Jan 14, 2024 •

edited

This comment has been minimized.

This comment has been minimized.

jwillikers Mar 25, 2024

jwillikers Mar 25, 2024 •

edited

jwillikers Mar 25, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

conan-center-bot commented May 6, 2024

-        _add_component("opengl_helper", requires=["opengl::opengl", "glu::glu", "eigen::eigen"])
+        opengl_helper_requires = ["eigen::eigen"]
+        if self.settings.os in ["FreeBSD", "Linux"]:
+            opengl_helper_requires.append("libglvnd::gl")
+        else:
+           opengl_helper_requires.append("opengl::opengl")
+        if is_apple_os(self) or self.settings.os == "Windows":
+            opengl_helper_requires.append("glu::glu")
+        else:
+            opengl_helper_requires.append("mesa-glu::mesa-glu")
+        _add_component("opengl_helper", requires=opengl_helper_requires)

	from conan.tools.build import check_min_cppstd
	from conan.tools.apple import is_apple_os
	from conan.tools.build import check_min_cppstd

g2o: new recipe #22337

Are you sure you want to change the base?

g2o: new recipe #22337

Conversation

valgur commented Jan 14, 2024 • edited

This comment has been minimized.

This comment has been minimized.

jwillikers Mar 25, 2024

Choose a reason for hiding this comment

jwillikers Mar 25, 2024 • edited

Choose a reason for hiding this comment

jwillikers Mar 25, 2024

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

conan-center-bot commented May 6, 2024

Conan v1 pipeline ❌

Conan v2 pipeline ❌

valgur commented Jan 14, 2024 •

edited

jwillikers Mar 25, 2024 •

edited