-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#22506) arrow: fix config_options #22508
Conversation
I detected other pull requests that are modifying arrow/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
See #21669. Thank you for the PR, but this approach would break most of the handling of dependent option values. |
We can try to apply: #21669 to our sync PR: apache/arrow#39729 |
@valgur I have applied #21669 to apache/arrow#39729 and it works. Could you help moving forward #21669? Then I can sync it to the arrow repo. Thanks! |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@valgur Do you mind taking a look at my proposed fix? |
Conan v1 pipeline ✔️All green in build 9 (
Conan v2 pipeline ✔️
All green in build 8 (
|
Also ping @toge @RubenRBS @uilianries for help. To provide the context, this PR is based on #21669 (by @valgur) with a few lines to fix the |
Thanks for the review! @valgur |
@toge Could you help review this? It would be good to get this in before the Arrow community releasing 15.0.1. Thanks! |
@RubenRBS @toge @uilianries could we get a review and a merge, I am about to release 15.0.1 and it would be good for us to get this merged before. Thank you very much! |
Hi, we have just released 15.0.1 but I am not going to create a PR on conan until this is merged as we should merge this first. |
@RubenRBS Gentle ping. Could you help review this? |
Hi @wgtmac and sorry for the delayed response. This recipe has given us some trouble in the past with several PRs trying to improve the management of options. There are too many of them and some of them affect others or give them a spcific value. We have discussed this internally in the conan team and we think that we don't want to introduce more code in this recipe con manage options. Instead, we would like to simplify the recipe and remove any kind of automatic management of options (as it has proved to be problematic) and just restrict the combinations in the We believe this would be the less problematic approach that hopefully would solve the issues of this recipe regarding options and its management. Hope that it make sense. Thank you! |
Thanks for the reply! @danimtb
That sounds good to me. We could simply pass the Conan option to the corresponding CMake option and those CMake files in the Arrow repo have already handled the relationship of options. IMHO, the remaining challenge is to figure out the third-party dependency requirement based on the user options. Will someone from the Conan community work on this? |
Yes, we will try to work on that! |
That's awesome! Looking forward to the fix. @danimtb |
Can be closed after #23163 was merged. |
Specify library name and version: arrow/15.0.0
Fix #22506