Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add basu/0.2.1 #22950

Merged
merged 1 commit into from
Apr 10, 2024
Merged

add basu/0.2.1 #22950

merged 1 commit into from
Apr 10, 2024

Conversation

bobrofon
Copy link
Contributor

@bobrofon bobrofon commented Mar 1, 2024

Specify library name and version: basu/0.2.1

basu is the sd-bus library, extracted from systemd.

Some projects rely on the sd-bus library for DBus support. However not all systems have systemd or elogind installed. This library provides just sd-bus (and the busctl utility).


@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (21dc1c9a8e3ca2fb6b2010236efb9e7cca5b8fb7):

  • basu/0.2.1:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 2 (21dc1c9a8e3ca2fb6b2010236efb9e7cca5b8fb7):

  • basu/0.2.1:
    All packages built successfully! (All logs)

Copy link
Member

@RubenRBS RubenRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution! My first question here is, given that this comes from systemd, is the current recipe providing this already? Would it make sense to have a conflict if both are present as requirements?

The rest of the recipe looks good :D

@RubenRBS RubenRBS self-assigned this Mar 4, 2024
@bobrofon
Copy link
Contributor Author

bobrofon commented Mar 4, 2024

given that this comes from systemd, is the current recipe providing this already?

Well, yes. Kind of. basu is a subset of libsystemd. basu exports the same symbols, and it's probably binary compatible with libsystemd (but there are no guarantees). The major difference is that basu supports FreeBSD, and libsystemd doesn't. I think that the main usage of basu recipe will be something like this:

if self.settings.os == 'Linux':
    self.requires('libsystemd')
elif self.settings.os == 'FreeBSD':
    self.requires('basu')

Would it make sense to have a conflict if both are present as requirements?

Good question. Imagine the following situation. You have a package with two binaries (let's call them 'client' and 'server'). The server links with libsystemd (by historical reasons). And the client links with basu (maybe because basu is already it's indirect dependency). And the client communicates with the server using dbus. In this situation I don't see why it should be prohibited on the recipe level.

@conan-center-bot conan-center-bot merged commit c408d55 into conan-io:master Apr 10, 2024
13 checks passed
yhsng pushed a commit to yhsng/conan-center-index that referenced this pull request Apr 12, 2024
ericLemanissier pushed a commit to ericLemanissier/conan-center-index that referenced this pull request Apr 16, 2024
@bobrofon bobrofon deleted the basu/0.2.1 branch April 30, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants