[fastgltf] Update to 0.7.1 #22960
[fastgltf] Update to 0.7.1 #22960
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
spnda
force-pushed
the
fastgltf_0.7.1
branch
2 times, most recently
from
0667a81
to
3ffc908
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 1 (
Conan v2 pipeline ✔️
All green in build 1 ( |
| # See https://github.com/spnda/fastgltf/commit/aa90dfac290584f35f47dd7c1634f23d376a7207 | ||
| if Version(self.version) >= "0.6.0": | ||
| self.requires("simdjson/3.7.0") | ||
| else: | ||
| self.requires("simdjson/3.2.1") |
There was a problem hiding this comment.
| # See https://github.com/spnda/fastgltf/commit/aa90dfac290584f35f47dd7c1634f23d376a7207 | |
| if Version(self.version) >= "0.6.0": | |
| self.requires("simdjson/3.7.0") | |
| else: | |
| self.requires("simdjson/3.2.1") | |
| self.requires("simdjson/3.7.0") |
Are the older versions incompatible with the latest simdjson?
There was a problem hiding this comment.
Yes. I originally had what you are suggesting, but removed that since it caused build failures on older versions.
Version 3.2.2 moved around a lot of headers and includes, which broke my base64 decoders as they didn't include the headers properly, and the code only worked because simdjson.h leaked the SIMD intrinsics. I fixed that in 0.6.0, which is why all versions since then have supported any of the more recent versions of simdjson. See simdjson/simdjson#2039.
Specify library name and version: fastgltf/0.7.1
Just a bugfix patch with minor additions, and I've bumped the simdjson version to 3.7.0 in this recipe because I think there's nothing wrong with telling it to use the latest version directly?