Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[llvm-core] bring package up to date. Support for Conan 2. #22997

Open
wants to merge 59 commits into
base: master
Choose a base branch
from

Conversation

planetmarshall
Copy link
Contributor

@planetmarshall planetmarshall commented Mar 5, 2024

Specify library name and version: llvm-core/*

Attempt to bring the llvm-core recipe up to date. Includes contributions from @jusito and #17509. Fixes #20339

Note that I have opted not to add the latest version (18.1.3) as part of this PR, as the existing recipe needed updating and is already quite complex. I (or someone else) will add the latest version as a followup.


Copy link
Contributor

github-actions bot commented Mar 5, 2024

🤖 Beep Boop! This pull request is making changes to 'recipes/llvm-core//'.

👋 @Hopobcn @paulharris you might be interested. 😉

@planetmarshall planetmarshall marked this pull request as draft March 5, 2024 21:24
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@planetmarshall planetmarshall force-pushed the llvm-core-conan2 branch 3 times, most recently from b8f48e8 to 471320c Compare March 5, 2024 22:41
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@planetmarshall planetmarshall changed the title [llvm-core] bring package up to date. Initial support for 13.0.0 [llvm-core] bring package up to date. Support for Conan 2. Mar 7, 2024
@planetmarshall planetmarshall marked this pull request as ready for review March 7, 2024 22:48
Copy link
Contributor

@jwillikers jwillikers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woot!

@AbrilRBS
Copy link
Member

@planetmarshall sorry about that - llvm takes quite a long time to compile - I see that the compilation is now done and the results posted and they are passing, yay!! I'll get a review going for monday, thanks a lot for your patience and for the contribution in the first place, we really aprpeciate it :)

@planetmarshall
Copy link
Contributor Author

@planetmarshall sorry about that - llvm takes quite a long time to compile - I see that the compilation is now done and the results posted and they are passing, yay!! I'll get a review going for monday, thanks a lot for your patience and for the contribution in the first place, we really aprpeciate it :)

Thanks, I also appreciate the efforts of the CCI team.

@jacobfriedman
Copy link

@jusito possible to review this week? I opted not to use llvm-core and your PR instead (llvm-16) but am eagerly waiting on this PR and can help update/test/review the later PRs.

@jcar87 It would be a big plus to be able to simply pull down transparent/conan-compiled compilers in Dockerfiles e.g. https://github.com/conan-io/conan-docker-tools/blob/master/modern/clang/Dockerfile

# Older cmake versions may have issues generating the graphviz output used
# to model the components
build_requires = [
'cmake/3.20.5'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it not required anymore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because graphviz is not used to model component dependencies, as noted in the comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify further - the original recipe used graphviz output which was then parsed and sanitized to generate component dependencies. Instead of doing this I opted to just use the information that LLVM already outputs in its CMake files, I thought this was more robust since the best source of cmake dependencies is cmake itself rather than going via graphviz and back again.

Co-authored-by: Michael Keck <git@cr0ydon.com>
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 29 (4c50124dc6d0d84b364e22fbf286363e12cf66e4):

  • llvm-core/13.0.0:
    All packages built successfully! (All logs)

  • llvm-core/12.0.0:
    All packages built successfully! (All logs)

  • llvm-core/11.1.0:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 30 (4c50124dc6d0d84b364e22fbf286363e12cf66e4):

  • llvm-core/13.0.0:
    All packages built successfully! (All logs)

  • llvm-core/12.0.0:
    All packages built successfully! (All logs)

  • llvm-core/11.1.0:
    All packages built successfully! (All logs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

llvm-core/13.0.0: recipe is broken (conan 2)
9 participants