Update range list to add libpng (And mention libxml) #23016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RubenRBS
changed the title
|
🤖 Beep Boop! This pull request is making changes to 'docs//'. 👋 @prince-chrismc @MartinDelille @Croydon you might be interested. 😉 |
jcar87
reviewed
Mar 7, 2024
jcar87
reviewed
Mar 7, 2024
jcar87
reviewed
Mar 7, 2024
docs/adding_packages/dependencies.md
Outdated
| > We're adding them little by little to avoid missing binaries and conflict errors. | ||
| > Please do not open PRs moving Zlib to ranges for now, we'll update this page when PRs are free to add new ranges. | ||
| > Please do not open PRs moving Libpng to ranges for now, we'll update this page when PRs are free to add new ranges. |
There was a problem hiding this comment.
I'd mention to please not open PRs where the only change is adding a version range to a requirement, unless the PR is solving a conflict (in which case the PR is very much welcome and will be prioritised).
There was a problem hiding this comment.
Good catch! Let's do it explicit, otherwise we may have new PRs only changing it.
jcar87
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After consideration, we'll allow libpng to the range list
As for the libxml dependency, we're also open to it being added, but still need to do some more research