Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mathter: add new version: 1.1.0 #23114

Merged
merged 9 commits into from
Apr 4, 2024
Merged

mathter: add new version: 1.1.0 #23114

merged 9 commits into from
Apr 4, 2024

Conversation

petiaccja
Copy link
Contributor

Library:
mathter/1.1.0

Reason for pull-request:

  • Note: I'm the author of the library
  • The new version (1.1.0) of the library contains significant changes
  • This PR updates the recipe to support changed packaging requirements
  • This PR includes the new available version

@CLAassistant
Copy link

CLAassistant commented Mar 16, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

Sign in to view
@petiaccja
Copy link
Contributor Author

Could you guys give me some advice related to managing different dependencies for different package versions? In mathter's case, for example, different versions of mathter (will) depend on different versions of xsimd. I would like to specify this in the YAML as I find that cleaner than hacking it in the script. Is there a customary way for doing this? Cheers!

@conan-center-bot

This comment has been minimized.

Sign in to view
This was referenced Mar 16, 2024
Open
Open
@ericLemanissier ericLemanissier mentioned this pull request Mar 16, 2024
Closed
@petiaccja petiaccja changed the title update recipe to v1.1.0 with xsimd optional dependency mathter/1.1.0: update library Mar 16, 2024
@petiaccja petiaccja changed the title mathter/1.1.0: update library mathter/1.1.0: add new version Mar 16, 2024
@petiaccja petiaccja changed the title mathter/1.1.0: add new version mathter: add new version: 1.1.0 Mar 16, 2024
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

Hooks produced the following warnings for commit fa23615
mathter/1.0.0@#098c009aec7e1517a2ee44b2d062652b 
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './docs/html/classmathter_1_1_intersection_3_01_line_segment_3_01_t_00_01_dim_01_4_00_01_hyperplane_3_01_t_00_01_dim_01_4_01_4-members.html' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
mathter/1.0.1@#5d7a35239f57fb732b6613a9d71162d0 
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './docs/html/classmathter_1_1_intersection_3_01_line_segment_3_01_t_00_01_dim_01_4_00_01_hyperplane_3_01_t_00_01_dim_01_4_01_4-members.html' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.

@conan-center-bot

This comment has been minimized.

Sign in to view
@petiaccja petiaccja marked this pull request as ready for review March 28, 2024 15:01
@prince-chrismc prince-chrismc mentioned this pull request Mar 28, 2024
Open
@RubenRBS RubenRBS self-assigned this Apr 1, 2024
@RubenRBS
Copy link
Member

RubenRBS commented Apr 1, 2024

Hi @petiaccja thanks a lot for taking the time to keep the version updated and your patience while we were on Easter break, we appreciate it :)

I've pushed some changes to simplify and correctly handle the new xsimd dependency, feel free to take a look at it

@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 1, 2024

Hooks produced the following warnings for commit 688b83d
mathter/1.0.0@#ada4af207bfe491bb4b462b32b437515 
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './docs/html/classmathter_1_1_intersection_3_01_line_segment_3_01_t_00_01_dim_01_4_00_01_hyperplane_3_01_t_00_01_dim_01_4_01_4-members.html' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 9 (8637b45e4e3454788fead5816461fae17e635a2a):

  • mathter/1.0.0:
    All packages built successfully! (All logs)

  • mathter/1.1.0:
    All packages built successfully! (All logs)

  • mathter/1.0.1:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 9 (8637b45e4e3454788fead5816461fae17e635a2a):

  • mathter/1.1.0:
    All packages built successfully! (All logs)

  • mathter/1.0.1:
    All packages built successfully! (All logs)

  • mathter/1.0.0:
    All packages built successfully! (All logs)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2024

Hooks produced the following warnings for commit 8637b45
mathter/1.0.0@#6fce65dae355f6d007b81a937b41dcd4 
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './docs/html/classmathter_1_1_intersection_3_01_line_segment_3_01_t_00_01_dim_01_4_00_01_hyperplane_3_01_t_00_01_dim_01_4_01_4-members.html' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
mathter/1.0.1@#3ff38d072c2c43fcd2703b37bcd88886 
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './docs/html/classmathter_1_1_intersection_3_01_line_segment_3_01_t_00_01_dim_01_4_00_01_hyperplane_3_01_t_00_01_dim_01_4_01_4-members.html' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.

@petiaccja
Copy link
Contributor Author

Hey @RubenRBS, hope you had a nice break! Thanks for taking your time to review and improve the PR. I've checked your changes and it makes sense, so if you think the PR is up to the standards, we can go ahead with merging it.

RubenRBS
RubenRBS approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@RubenRBS RubenRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! :)

@conan-center-bot conan-center-bot merged commit d48a42d into conan-io:master Apr 4, 2024
23 checks passed
yhsng pushed a commit to yhsng/conan-center-index that referenced this pull request Apr 12, 2024
@petiaccja @RubenRBS
(conan-io#23114) mathter: add new version: 1.1.0
a226204 
* update recipe to v1.1.0 with xsimd optional dependency

* fix empty YAML blocks with explicit empty dict

* yaml linter

* add v1.1.0 to config.yml

* move dependencies into python file

* linter

* print XSimd option

* Improve xsimd option handling

* update package options for compiler definitions

---------

Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
ericLemanissier pushed a commit to ericLemanissier/conan-center-index that referenced this pull request Apr 16, 2024
@petiaccja @RubenRBS @ericLemanissier
(conan-io#23114) mathter: add new version: 1.1.0
a1a3b81 
* update recipe to v1.1.0 with xsimd optional dependency

* fix empty YAML blocks with explicit empty dict

* yaml linter

* add v1.1.0 to config.yml

* move dependencies into python file

* linter

* print XSimd option

* Improve xsimd option handling

* update package options for compiler definitions

---------

Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uilianries uilianries uilianries approved these changes

@RubenRBS RubenRBS RubenRBS approved these changes

Assignees

@RubenRBS RubenRBS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@petiaccja @CLAassistant @conan-center-bot @RubenRBS @uilianries