Logfault header only library #23126

jgaa · 2024-03-17T13:11:56Z

This is my first submission to the conan-center-index.

Specify library name and version: logfault/0.5.0

I am the author of the package Logfault. It has some users, so in order
to make it simpler to use for everyone, I'm submitting this PR to include it
in the ConanCenter.

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with conan 2.1.0

This is my first submission to the conan-center-index.

CLAassistant · 2024-03-17T13:12:01Z

All committers have signed the CLA.

…attribute 'test_requires'

RubenRBS

Hi! Thanks a lot for yout contribution and taking the time to submit your library to CCI, we appreciate it :)

The recipe looks great overall, the only thing on my side besides the minor review comments, would be to remoce the comments from the template to keep the recipe more readable, thanks!

recipes/logfault/all/conanfile.py

Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>

… review.

…in as generator to ensure its correct initialization'

uilianries

Thank you for your PR! Please, take a look on my review.

recipes/logfault/all/conanfile.py

Co-authored-by: Uilian Ries <uilianries@gmail.com>

recipes/logfault/all/conanfile.py

Co-authored-by: Uilian Ries <uilianries@gmail.com>

jgaa · 2024-03-22T09:43:39Z

I can't find any examples of other projects using gtest and cmake.build() for the target package in conan-center-index.

The problem with the build is that somehow the configuring of gtest does not produce (or appear so to me - I don't have the complete build logs) one of the expected CMake targets; GTest::gtest or gtest::gtest.

When I run the build locally with testing enabled, I get a message in output: Conan: Target declared 'gtest::gtest'. In the build from Conan Center, I don't see this. Just Found GTest: /home/conan/workspace/prod-v2/bsr/4772/dadbb/p/gtestf28c74556dabb/p/lib/libgtest.a.

For now I'm keeping the test code in conanfile.py, but disabling it so the project can pass. I would be good however to find the root cause so the unit tests can be ran while building at the Conan Center.

recipes/logfault/all/test_package/CMakeLists.txt

recipes/logfault/config.yml

recipes/logfault/all/conanfile.py

valgur

Thanks! LGTM. Only some minor change suggestions.

Co-authored-by: Martin Valgur <martin.valgur@gmail.com>

jgaa · 2024-03-28T15:57:14Z

Are there any pending tasks from my side?

jgaa · 2024-04-01T09:28:30Z

Ping @RubenRBS
Are you guys waiting for anything more from me?

RubenRBS · 2024-04-01T09:35:44Z

Hi @jgaa thanks for the ping

This PR is just waiting for a review from us again - we were out on easter holidays this last week so we didn't get to do much reviewing, I'll try to get this done today :)

RubenRBS

Looks good, minor question about the generate() method :)

recipes/logfault/all/conanfile.py

conan-center-bot · 2024-04-02T15:11:31Z

Conan v1 pipeline ✔️

All green in build 29 (c43dcd21221b4a223153f7fb2dc54d841c0f09d7):

logfault/0.5.2:
All packages built successfully! (All logs)

jgaa · 2024-04-12T10:37:18Z

Ping @RubenRBS
Are you guys waiting for any changes from me?

RubenRBS · 2024-04-15T20:35:50Z

Hi @jgaa sorry for the radio silence. There's nothing else needed from you right now, the CI systems will pick the PR up once they leave maintenance mode, thanks!

* First take on a conan-recipe for logfault This is my first submission to the conan-center-index. * Corrected yaml indention * Changed requirements. self.test_requires() failed with object has no attribute 'test_requires' * Update recipes/logfault/all/conanfile.py Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es> * Update recipes/logfault/all/conanfile.py Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es> * Update recipes/logfault/all/conanfile.py Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es> * Update recipes/logfault/all/conanfile.py Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es> * Removed comments and 'def export_sources(self):' as suggested in code review. * trying to fix build error: '... Check that you are using CMakeToolchain as generator to ensure its correct initialization' * Update recipes/logfault/all/conanfile.py Co-authored-by: Uilian Ries <uilianries@gmail.com> * Update recipes/logfault/all/conanfile.py Co-authored-by: Uilian Ries <uilianries@gmail.com> * Update recipes/logfault/all/conanfile.py Co-authored-by: Uilian Ries <uilianries@gmail.com> * Update recipes/logfault/all/conanfile.py Co-authored-by: Uilian Ries <uilianries@gmail.com> * Update recipes/logfault/all/conanfile.py Co-authored-by: Uilian Ries <uilianries@gmail.com> * Changed cmake.test() to cmake.ctest(). There is no 'test' target. * cmake.ctest() worked when I tested it locally, but failed v2_linter. Using cmake.test() with 'conan build .' with the original code checked out works. There is a 'test' target. Testing this receipie locally with 'conan create all/conanfile.py --version 0.5.0' fails because of a missing 'test' target. Changing the target of cmake.test() to 'all' works locally, and the test is executed. So trying that. * Fixed problems with GTest link target in logfault code. Now pointing to version 0.5.1 Set tools.build:skip_test setting consistently to False. It was mixed, causing problems with test target. * Updating version to 0.5.1 * Trying to restore the build by modifying the Cmake files in the origibnal code (bumpped to 0.5.2 to get a new tarball from github). Everything works fine locally and while building the original code with Github Actions on all platforms. But so it did for 0.5.1 as well. * Disabling unit tests. * Removed unit tests option * Update recipes/logfault/all/test_package/CMakeLists.txt Co-authored-by: Martin Valgur <martin.valgur@gmail.com> * Update recipes/logfault/config.yml Co-authored-by: Martin Valgur <martin.valgur@gmail.com> * Removed 'generate' method. --------- Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es> Co-authored-by: Uilian Ries <uilianries@gmail.com> Co-authored-by: Martin Valgur <martin.valgur@gmail.com>

First take on a conan-recipe for logfault

51b3588

This is my first submission to the conan-center-index.

prince-chrismc mentioned this pull request Mar 17, 2024

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

Corrected yaml indention

07240e9

conan-center-bot added the Failed label Mar 17, 2024

This comment has been minimized.

Sign in to view

Changed requirements. self.test_requires() failed with object has no …

108d93b

…attribute 'test_requires'

conan-center-bot removed the Failed label Mar 17, 2024

This comment has been minimized.

Sign in to view

RubenRBS self-assigned this Mar 18, 2024

RubenRBS reviewed Mar 18, 2024

View reviewed changes

jgaa and others added 6 commits March 18, 2024 18:22

Update recipes/logfault/all/conanfile.py

98fc9c1

Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>

Update recipes/logfault/all/conanfile.py

86f539f

Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>

Update recipes/logfault/all/conanfile.py

9677ed6

Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>

Update recipes/logfault/all/conanfile.py

800602a

Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>

Removed comments and 'def export_sources(self):' as suggested in code…

7a4f3dd

… review.

Merge branch 'master' into logfault-0.5.0

49c1fa0

conan-center-bot added the Failed label Mar 18, 2024

This comment has been minimized.

Sign in to view

trying to fix build error: '... Check that you are using CMakeToolcha…

8e3eeae

…in as generator to ensure its correct initialization'

conan-center-bot removed the Failed label Mar 18, 2024

This comment has been minimized.

Sign in to view

uilianries reviewed Mar 19, 2024

View reviewed changes

recipes/logfault/all/conanfile.py Outdated Show resolved Hide resolved

recipes/logfault/all/conanfile.py Outdated Show resolved Hide resolved

recipes/logfault/all/conanfile.py Outdated Show resolved Hide resolved

recipes/logfault/all/conanfile.py Outdated Show resolved Hide resolved

jgaa and others added 3 commits March 19, 2024 18:20

Update recipes/logfault/all/conanfile.py

b606bed

Co-authored-by: Uilian Ries <uilianries@gmail.com>

Update recipes/logfault/all/conanfile.py

bce3c08

Co-authored-by: Uilian Ries <uilianries@gmail.com>

Update recipes/logfault/all/conanfile.py

1563eb4

Co-authored-by: Uilian Ries <uilianries@gmail.com>

uilianries reviewed Mar 19, 2024

View reviewed changes

recipes/logfault/all/conanfile.py Outdated Show resolved Hide resolved

jgaa and others added 3 commits March 19, 2024 19:26

Update recipes/logfault/all/conanfile.py

d85c80d

Co-authored-by: Uilian Ries <uilianries@gmail.com>

Update recipes/logfault/all/conanfile.py

d14d3ce

Co-authored-by: Uilian Ries <uilianries@gmail.com>

Merge branch 'master' into logfault-0.5.0

e30fa28

Merge branch 'master' into logfault-0.5.0

00319ac

conan-center-bot removed the Failed label Mar 22, 2024

This comment has been minimized.

Sign in to view

Merge branch 'master' into logfault-0.5.0

476ad16

This comment has been minimized.

Sign in to view

valgur reviewed Mar 24, 2024

View reviewed changes

recipes/logfault/all/test_package/CMakeLists.txt Outdated Show resolved Hide resolved

valgur reviewed Mar 24, 2024

View reviewed changes

recipes/logfault/config.yml Outdated Show resolved Hide resolved

valgur reviewed Mar 24, 2024

View reviewed changes

recipes/logfault/all/conanfile.py Outdated Show resolved Hide resolved

valgur approved these changes Mar 24, 2024

View reviewed changes

RubenRBS assigned uilianries Mar 24, 2024

jgaa and others added 3 commits March 25, 2024 11:24

Removed unit tests option

2873dac

Update recipes/logfault/all/test_package/CMakeLists.txt

a58877a

Co-authored-by: Martin Valgur <martin.valgur@gmail.com>

Update recipes/logfault/config.yml

92354d7

Co-authored-by: Martin Valgur <martin.valgur@gmail.com>

valgur approved these changes Mar 25, 2024

View reviewed changes

This comment has been minimized.

Sign in to view

Merge branch 'master' into logfault-0.5.0

93fee90

This comment has been minimized.

Sign in to view

RubenRBS reviewed Apr 1, 2024

View reviewed changes

recipes/logfault/all/conanfile.py Outdated Show resolved Hide resolved

Removed 'generate' method.

c43dcd2

RubenRBS approved these changes Apr 15, 2024

View reviewed changes

toge approved these changes Apr 17, 2024

View reviewed changes

conan-center-bot merged commit 966ae31 into conan-io:master Apr 17, 2024
13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Logfault header only library #23126

Logfault header only library #23126

jgaa commented Mar 17, 2024

CLAassistant commented Mar 17, 2024 •

edited

This comment has been minimized.

This comment has been minimized.

RubenRBS left a comment

This comment has been minimized.

This comment has been minimized.

uilianries left a comment

This comment has been minimized.

jgaa commented Mar 22, 2024

This comment has been minimized.

valgur left a comment

This comment has been minimized.

This comment has been minimized.

jgaa commented Mar 28, 2024

jgaa commented Apr 1, 2024

RubenRBS commented Apr 1, 2024

RubenRBS left a comment

conan-center-bot commented Apr 2, 2024

jgaa commented Apr 12, 2024

RubenRBS commented Apr 15, 2024

Logfault header only library #23126

Logfault header only library #23126

Conversation

jgaa commented Mar 17, 2024

CLAassistant commented Mar 17, 2024 • edited

This comment has been minimized.

This comment has been minimized.

RubenRBS left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

uilianries left a comment

Choose a reason for hiding this comment

This comment has been minimized.

jgaa commented Mar 22, 2024

This comment has been minimized.

valgur left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

jgaa commented Mar 28, 2024

jgaa commented Apr 1, 2024

RubenRBS commented Apr 1, 2024

RubenRBS left a comment

Choose a reason for hiding this comment

conan-center-bot commented Apr 2, 2024

Conan v1 pipeline ✔️

jgaa commented Apr 12, 2024

RubenRBS commented Apr 15, 2024

CLAassistant commented Mar 17, 2024 •

edited