libcvd: new recipe #23216
libcvd: new recipe #23216
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit a92c02clibcvd/2.5.0@#0ef32e834debe07ec581f1b5775e3696 |
This comment has been minimized.
This comment has been minimized.
recipes/libcvd/all/conanfile.py
Outdated
| self.requires("libtiff/4.6.0") | ||
| if self.options.get_safe("with_opengl", True): | ||
| # https://github.com/edrosten/libcvd/blob/RELEASE_2_5_0/cvd/videodisplay.h#L18-L20 | ||
| self.requires("opengl/system", transitive_headers=True, transitive_libs=True) |
There was a problem hiding this comment.
Would it be possible to target libglvnd here on Linux and FreeBSD instead of opengl/system?
There was a problem hiding this comment.
That sounds good to me. My only general doubt is whether it could conflict with other packages still using opengl/system?
libglvnd does not set provides = "opengl", but doesn't it effectively conflict with opengl/system nevertheless?
There was a problem hiding this comment.
You're totally correct about that, and I think we need to add that to the libglvnd recipe. However, I'd prefer to have less recipes to update in the future to use libglvnd on Linux and FreeBSD. I don't think I've run into issues with the conflict yet, likely related to the fact that on Fedora, using the libglvnd Conan package just dispatches to the system drivers provided by Mesa without a problem. I haven't tested this specific case on Ubuntu, but I do think the Wayland compositor's I'm packaging have conflicts in the graph that pull in opengl/system and I haven't run into issues.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 8 (
Conan v2 pipeline ✔️
All green in build 8 (
|
There was a problem hiding this comment.
Thanks! (And to @jwillikers too for the opengl review, I'd have not catch that!)
* libcvd: new recipe * libcvd: OpenGL is required on Windows * libcvd: tidy conandata.yml * libcvd: fix Windows build * libcvd: add ws2_32 system dep * libcvd: use libglvnd * libcvd: bump to v2.5.1
Adds libCVD: https://github.com/edrosten/libcvd
libcvd - efficient and easy to use C++ computer vision library.
Resolves #23173