libssh: add recipe #23230
Merged
libssh: add recipe #23230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
valgur
suggested changes
Mar 24, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Added a new option for "with_symbol_versioning" and matched it to the default behaviour for libssh. Defaults to being enabled as per: Disabled if not Unix. I've implemented this as the option is deleted on Windows builds, is this the correct thing to do? |
This comment has been minimized.
This comment has been minimized.
uilianries
reviewed
Apr 2, 2024
This comment has been minimized.
This comment has been minimized.
uilianries
reviewed
Apr 3, 2024
This comment has been minimized.
This comment has been minimized.
uilianries
reviewed
Apr 3, 2024
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 9 (
|
uilianries
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
I just checked the upstream and they are actually using CMake targets in the master branch. So it should not be needed in the future.
franramirez688
approved these changes
Apr 4, 2024
yhsng
pushed a commit
to yhsng/conan-center-index
that referenced
this pull request
Apr 12, 2024
* libssh: add recipe Related: conan-io#13449 Related: conan-io#16899 Fixes: conan-io#16747 * libssh: add option for with_symbol_versioning instead of forcing it off * libssh: add reference links for target alias definitions * libssh: remove cmake_find_package generators * Add TODO info --------- Co-authored-by: Uilian Ries <uilianries@gmail.com>
ericLemanissier
pushed a commit
to ericLemanissier/conan-center-index
that referenced
this pull request
Apr 16, 2024
* libssh: add recipe Related: conan-io#13449 Related: conan-io#16899 Fixes: conan-io#16747 * libssh: add option for with_symbol_versioning instead of forcing it off * libssh: add reference links for target alias definitions * libssh: remove cmake_find_package generators * Add TODO info --------- Co-authored-by: Uilian Ries <uilianries@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #13449
Related: #16899
Fixes: #16747
Specify library name and version: libssh/0.10.6
Changed replace_in_file from previous PR with apply_conandata_patches
Added
tc.cache_variables["CMAKE_TRY_COMPILE_CONFIGURATION"]to support Visual Studio / Ninja Multi-Config generators